[Bug 14157] New: EnhancedMessagingPreferences and Notices tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Bug ID: 14157 Summary: EnhancedMessagingPreferences and Notices tab Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ed.veal@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you “Don’t Allow” the EnhancedMessagingPreferences then staff looses the “notice” tab in the patron record and they can’t see information about overdue notices being sent. So if you don’t want patrons to choose enhanced messages you can’t track the sending of overdue notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 44437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44437&action=edit Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|3.18 |master CC| |sophie.meynieux@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44437|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 44450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44450&action=edit Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44450|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44457&action=edit [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a small change in behaviour, but as we have no preference for "UsesOverdueNotices" it's a quick fix. The tab can still be hidden with jQuery. It would be nice to have a follow up adding an id to the element, to make it even easier. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I see it also checkes for "sentnotices". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|EnhancedMessagingPreference |Show notices tab with |s and Notices tab |EnhancedMessagingPreference | |s deactivated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org