[Bug 32204] New: in-page anchor to edititem on additem.pl not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Bug ID: 32204 Summary: in-page anchor to edititem on additem.pl not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1. Search the catalog and view a record detail page of a record with items 2. Click 'Edit items' 3. Choose one item from the list and click 'Edit' 4. The URL fragment or in-page anchor (#edititem) is appended to the end of the URL but you are not placed on it. Instead you are placed at the top of the page and must scroll down to edit the particular item. Note: This issue is present in master and 22.05.x, as far as I can tell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could the reason be the empty searchid param? This doesn't work: http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=126&itemnumber=263&searchid=#edititem This does work (sometimes) http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=126&itemnumber=263&searchid=5#edititem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- For me the empty searchid parameter doesn't seem to matter. If I click 'Edit item', I am still at the top of the page ( fragment doesn't work ) but if I then go to the address bar and press return to refresh I am taken to the #edititem location. ( fragment does work ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- I believe it is the tabs: koha-tmpl/intranet-tmpl/prog/js/staff-global.js 51 $(document).ready(function() { 52 $('#header_search').tabs({ 53 create: function( e, ui ){ 54 ui.panel.find("input:text:first").focus(); 55 }, 56 activate: function ( e, ui ) { 57 ui.newPanel.find("input:text:first").focus(); 58 } 59 }); They are moving the focus to the header search when the tabs are loaded - refreshing from the url doesn't fully reload the page, so the anchor works as we don't trigger the focus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |22.05 CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Confirmed 22.05.07 and up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Nick Clemens from comment #3)
I believe it is the tabs: koha-tmpl/intranet-tmpl/prog/js/staff-global.js 51 $(document).ready(function() { 52 $('#header_search').tabs({ 53 create: function( e, ui ){ 54 ui.panel.find("input:text:first").focus(); 55 }, 56 activate: function ( e, ui ) { 57 ui.newPanel.find("input:text:first").focus(); 58 } 59 });
They are moving the focus to the header search when the tabs are loaded - refreshing from the url doesn't fully reload the page, so the anchor works as we don't trigger the focus
100% correct. I think we could check for the existence of a hash before we set the focus. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145200&action=edit Bug 32204: Check for hash before setting focus 1. Search the catalog and view a record detail page of a record with items 2. Click 'Edit items' 3. Choose one item from the list and click 'Edit' 4. The URL fragment or in-page anchor (#edititem) is appended to the end of the URL but you are not placed on it. Instead you are placed at the top of the page and must scroll down to edit the particular item. 5. Apply patch 6. Try steps 1 - 3 again, now you should be placed in the correct location (#edititem) when editing an item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- This does interrupt workflows so I am setting the importance to normal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145200|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 145203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145203&action=edit Bug 32204: Check for hash before setting focus 1. Search the catalog and view a record detail page of a record with items 2. Click 'Edit items' 3. Choose one item from the list and click 'Edit' 4. The URL fragment or in-page anchor (#edititem) is appended to the end of the URL but you are not placed on it. Instead you are placed at the top of the page and must scroll down to edit the particular item. 5. Apply patch 6. Try steps 1 - 3 again, now you should be placed in the correct location (#edititem) when editing an item. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145203|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145572&action=edit Bug 32204: Check for hash before setting focus 1. Search the catalog and view a record detail page of a record with items 2. Click 'Edit items' 3. Choose one item from the list and click 'Edit' 4. The URL fragment or in-page anchor (#edititem) is appended to the end of the URL but you are not placed on it. Instead you are placed at the top of the page and must scroll down to edit the particular item. 5. Apply patch 6. Try steps 1 - 3 again, now you should be placed in the correct location (#edititem) when editing an item. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- This fix does not work with 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org