[Bug 32689] New: Host item entry (773) missing a space between label and content when $i is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Bug ID: 32689 Summary: Host item entry (773) missing a space between label and content when $i is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 16522 This problem appears with and without bug 16522, but since bug 16522 centralizes the template for displaying 773 information, I'll mark this is a dependency. To test: * Update default framework to display 773 a t w i by default in the editor, OPAC and staff. * Search for a record in the staff interface * Click New > Add child record from the detail page * Enter 245 and any mandatory fields * Add $i to 773 entry and make the indicators: 0 8 * On the detail page, the $i will be used a label, but there'll be no space between label and content. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145532&action=edit Bug 32689: Add missing space between 773$i label text and content When 777 Ind. 2 = 8, $i will be used as the label. In this case, we were missing a space between the $i and the other subfields. This patch makes sure there is a space. Note: the colon is expected to be part of the data here. To test: * Update default framework to display 773 a t w i by default in the editor, OPAC and staff interface. * Search for a record in the staff interface * Click New > Add child record from the detail page * Enter 245 and any mandatory fields * Add $i to 773 entry and make the indicators: 0 8 * On the detail page and the result lists, $i will be used a label, but there'll be no space between label and content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145532|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145547&action=edit Bug 32689: Add missing space between 773$i label text and content When 777 Ind. 2 = 8, $i will be used as the label. In this case, we were missing a space between the $i and the other subfields. This patch makes sure there is a space. Note: the colon is expected to be part of the data here. To test: * Update default framework to display 773 a t w i by default in the editor, OPAC and staff interface. * Search for a record in the staff interface * Click New > Add child record from the detail page * Enter 245 and any mandatory fields * Add $i to 773 entry and make the indicators: 0 8 * On the detail page and the result lists, $i will be used a label, but there'll be no space between label and content. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145547|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145867&action=edit Bug 32689: Add missing space between 773$i label text and content When 777 Ind. 2 = 8, $i will be used as the label. In this case, we were missing a space between the $i and the other subfields. This patch makes sure there is a space. Note: the colon is expected to be part of the data here. To test: * Update default framework to display 773 a t w i by default in the editor, OPAC and staff interface. * Search for a record in the staff interface * Click New > Add child record from the detail page * Enter 245 and any mandatory fields * Add $i to 773 entry and make the indicators: 0 8 * On the detail page and the result lists, $i will be used a label, but there'll be no space between label and content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All the little things really add up, thanks Katrin. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Bug 32689 depends on bug 16522, which changed state. Bug 16522 Summary: Add 773 (Host item entry) to the cart and list displays and e-mails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org