[Bug 25537] New: Page reload at branchtransfers.pl loses destination branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Bug ID: 25537 Summary: Page reload at branchtransfers.pl loses destination branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. To test: - Have an item waiting for hold pickup at Branch A - go to Circulation > Transfers, attempt to transfer your waiting item to branch C - Get error about the hold - get routed back to Transfers, but branch selector now shows Branch B This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105224&action=edit Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105224|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105476&action=edit Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25682 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682 [Bug 25682] Style transfers interface to match checkin page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105476|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105632&action=edit Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple and clear patch, no missing filters etc.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x. for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.13 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org