[Bug 22470] New: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Bug ID: 22470 Summary: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: gveranis@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Target Milestone: --- UPDATE marc_subfield_structure SET kohafield='seriestitle' - it's missing the table name it should be $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle' WHERE tagfield='490' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.volume' WHERE tagfield='490' AND tagsubfield='v'" ); # empty old koha fields $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.volume' AND tagfield='440' AND tagsubfield='v'" ); lines 232-249 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 George Veranis <gveranis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #1 from George Veranis <gveranis@gmail.com> --- $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle' WHERE tagfield='490' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblioitems.volume' WHERE tagfield='490' AND tagsubfield='v'" ); # empty old koha fields $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblioitems.volume' AND tagfield='440' AND tagsubfield='v'" ); lines 232-249 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #2 from George Veranis <gveranis@gmail.com> --- also add $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblioitems.number' AND tagfield='440' AND tagsubfield='n'" ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 George Veranis <gveranis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |gveranis@gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|gveranis@gmail.com |koha-bugs@lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Changing back to default assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104627&action=edit Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl This patch adds the table name to the SQL update statements. To test: 1) Apply the patch 2) Run the script. Check that there are no errors, and that the script behaves as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- I'm not 100% sure I understand what this script is meant to do, but I've made the suggested edits and as far as I can see the script runs without errors and moves series data into the different fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5608 CC| |a.roussos@dataly.gr --- Comment #6 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to David Roberts from comment #5)
I'm not 100% sure I understand what this script is meant to do, but I've made the suggested edits and as far as I can see the script runs without errors and moves series data into the different fields. As I understand it, this script was created in light of the changes in the MARC21 standard relating to field 440. According to the "FIELD DEFINITION AND SCOPE" section in https://www.loc.gov/marc/bibliographic/bd440.html, field 440 was made obsolete in 2008.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104627|0 |1 is obsolete| | --- Comment #7 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 104981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104981&action=edit Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl This patch adds the table name to the SQL update statements. To test: 1) Apply the patch 2) Run the script. Check that there are no errors, and that the script behaves as expected. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Created a test record with values in field 440. Applied the patch, ran the script with the -c -f flags and observed that the values were moved to field 490. Also, the relevant Koha to MARC mappings were changed accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104981|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105191&action=edit Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl This patch adds the table name to the SQL update statements. To test: 1) Apply the patch 2) Run the script. Check that there are no errors, and that the script behaves as expected. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Created a test record with values in field 440. Applied the patch, ran the script with the -c -f flags and observed that the values were moved to field 490. Also, the relevant Koha to MARC mappings were changed accordingly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.13 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org