[Bug 43362] New: URI validation for biblio MARC21 field 856$u and items.uri
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 Bug ID: 43362 Summary: URI validation for biblio MARC21 field 856$u and items.uri Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Would be nice to add (basic) URI validation for biblio MARC21 field 856$u and items.uri. Opening another report for authority records in relation to the use of external vocabularies, including corresponding biblio subfields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43363 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Comma delimited| |Rijksmuseum, Netherlands list of Sponsors| | Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206988&action=edit Bug 43362: Validate URIs in MARC21 856$u Introduces URI.js to allow parsing and validating URIs on the frontend, and uses this to validate the MARC21 856$u subfield when editing a biblio. To avoid breaking existing records, it is still possible to confirm saving with an invalid URI. 1. Ensure Koha is configured as MARC21. 2. Apply patch. 2. Navigate to an existing biblio, and under the "Edit" dropdown, select "Edit record". 3. Set the 856$u value to an invalid URI, such as "urn::fake". 4. Press "Save", and verify a popup asks you to confirm saving. 5. Decline saving, and verify a popup at the top of the page informs you of the invalid URI, and that it is highlighted. 6. Press "Save", but this time confirm saving with errors. Verify the save is successful. 7. Edit the record again, and this time specify a valid URI for 856$u, such as "https://example.com". 8. Press "Save", and verify there is no need to confirm saving. Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 --- Comment #2 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206989&action=edit Bug 43362: Validate URIs on items Introduce URI validation with URI.js for the relevant field on items, in line with the validation on biblios. Test plan: 1. Apply patch. 2. Navigate to a biblio with items, navigate to its "Items" tab, and edit one of the items. 3. Set the item's URI field (u) to an invalid URI, such as "urn::fake". 4. Press "Save changes", and verify you are asked to confirm saving with an invalid URI field. 5. Cancel saving, and verify the URI field is highlighted. 6. Press "Save changes", this time confirming saving with an invalid field. Verify the save is successful. 7. Return to editing the item, and this time specify a valid URI, such as "https://example.com". 8. Press "Save changes", and verify the item is saved without need to confirm an invalid field. Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Comma delimited|Rijksmuseum, Netherlands |Netherlands, Rijksmuseum, list of Sponsors| |Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206988|0 |1 is obsolete| | Attachment #206989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 207265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207265&action=edit Bug 43362: Validate URIs in MARC21 856$u Introduces URI.js to allow parsing and validating URIs on the frontend, and uses this to validate the MARC21 856$u subfield when editing a biblio. To avoid breaking existing records, it is still possible to confirm saving with an invalid URI. 1. Ensure Koha is configured as MARC21. 2. Apply patch. 2. Navigate to an existing biblio, and under the "Edit" dropdown, select "Edit record". 3. Set the 856$u value to an invalid URI, such as "urn::fake". 4. Press "Save", and verify a popup asks you to confirm saving. 5. Decline saving, and verify a popup at the top of the page informs you of the invalid URI, and that it is highlighted. 6. Press "Save", but this time confirm saving with errors. Verify the save is successful. 7. Edit the record again, and this time specify a valid URI for 856$u, such as "https://example.com". 8. Press "Save", and verify there is no need to confirm saving. Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43362 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 207266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207266&action=edit Bug 43362: Validate URIs on items Introduce URI validation with URI.js for the relevant field on items, in line with the validation on biblios. Test plan: 1. Apply patch. 2. Navigate to a biblio with items, navigate to its "Items" tab, and edit one of the items. 3. Set the item's URI field (u) to an invalid URI, such as "urn::fake". 4. Press "Save changes", and verify you are asked to confirm saving with an invalid URI field. 5. Cancel saving, and verify the URI field is highlighted. 6. Press "Save changes", this time confirming saving with an invalid field. Verify the save is successful. 7. Return to editing the item, and this time specify a valid URI, such as "https://example.com". 8. Press "Save changes", and verify the item is saved without need to confirm an invalid field. Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org