[Bug 43333] New: Restore the name of the vendor as h1 in vendor details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Bug ID: 43333 Summary: Restore the name of the vendor as h1 in vendor details page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- While testing 26.05 prior to rolling it out to our clients, the team noticed that in the vendor's details page, the name of the vendor is not prominent anymore. There is a h2 that says "Vendor #x" but the name of the vendor is only in the small section in the details. For most end users, they don't care that this is vendor #1, #2 or #38. They tell the vendors apart by their name. I can't tell which bug changed this because for some reason vue pages don't react well to git checkout (or maybe I just don't know how it works which is also a possibility). In 25.05.05 which is the version our clients currently use, the vendor name is in an h1. In main (and 26.05.02), the vendor # is in an h2 and, as far as I can tell, there is no h1. To recreate : 1. In KTD, go to Acquisitions 2. Click Search in the vendor search box 3. Click "My vendor" --> The biggest title on the page is "Vendor #1" --> "My vendor" is in the breadcrumbs and in the form, but both are small and a bit lost in the rest of the information 4. Inspect the title "Vendor #1" --> It's a h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|NEW |CONFIRMED --- Comment #1 from David Nind <david@davidnind.com> --- I agree that it should be an H1, and that: 1. The H1 should show the vendor name, instead of the number. 2. The page title (used in the tab) should be "Vendor name > Vendors > Koha", consistent with other Koha breadcrumbs. Ideally the sections, such as "Details" and "Ordering information" should be H2s instead of legends, but I have no idea on the constraints with using Vue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 CC| |jonathan.druart@gmail.com, | |katrin.fischer@bsz-bw.de --- Comment #2 from Michaela Sieber <michaela.sieber@kit.edu> --- I guess it was introduced in 25.11 with the VueJS architecture rethink (Bug 38201) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Yes in version 25.04 it is showing the vendor name, for example: Amazon but in 25.11 and higher versions, it is showing for example: Vendor #1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 206621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206621&action=edit Bug 43333: Allow the resource title to be a callback Converts the title of the ResourceShow view to be a callback to allow resources to inject their own properties into the title section Test plan: 1) Create a vendor and navigate to the display view 2) The title will be "Vendor #(id)" 3) Apply patches and yarn js:build 4) Hard refresh the page and the title should now be the vendor name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206621|0 |1 is obsolete| | --- Comment #5 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206656&action=edit Bug 43333: Allow the resource title to be a callback Bug 43333: Allow the resource title to be a callback Converts the title of the ResourceShow view to be a callback to allow resources to inject their own properties into the title section Test plan: 1) Create a vendor and navigate to the display view 2) The title will be "Vendor #(id)" 3) Apply patches and yarn js:build 4) Hard refresh the page and the title should now be the vendor name Work as suggested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #6 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206657&action=edit Bug 43333: Allow the resource edit title to be a callback Fix for the edit page. Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit <Vendor Name>" (or "Edit: <Vendor Name>"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- In this second patch, shouldn't + : $__("New vendor"); be replaced with instancedResource.i18n.newLabel so we don't repeat "New vendor"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Jonathan Druart from comment #7)
In this second patch, shouldn't
+ : $__("New vendor");
be replaced with
instancedResource.i18n.newLabel
so we don't repeat "New vendor"?
Thanks, Jonathan, for the comment. Will check and update the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206657|0 |1 is obsolete| | --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206669&action=edit Bug 43333: Allow the resource edit title to be a callback Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit: <Vendor Name>". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #10 from Amit Gupta <amitddng135@gmail.com> --- Added the comments shared by Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206656|0 |1 is obsolete| | Attachment #206669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #11 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 206670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206670&action=edit Bug 43333: Allow the resource title to be a callback Converts the title of the ResourceShow view to be a callback to allow resources to inject their own properties into the title section Test plan: 1) Create a vendor and navigate to the display view 2) The title will be "Vendor #(id)" 3) Apply patches and yarn js:build 4) Hard refresh the page and the title should now be the vendor name Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.ai> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 206671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206671&action=edit Bug 43333: Allow the resource edit title to be a callback Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit <Vendor Name>" (or "Edit: <Vendor Name>"). Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206671|0 |1 is obsolete| | --- Comment #13 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206703&action=edit Bug 43333: Allow the resource edit title to be a callback Bug 43333: Allow the resource edit title to be a callback Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit: <Vendor Name>". Fix with comments shared by Jonathan Druart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #14 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Biblibre Sandboxes from comment #12)
Created attachment 206671 [details] [review] Bug 43333: Allow the resource edit title to be a callback
Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation.
Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit <Vendor Name>" (or "Edit: <Vendor Name>").
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Seems you did the wrong signoff of my older patch. I have updated the new patch with Jonathan Druart's comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Michaela Sieber <michaela.sieber@kit.edu> --- Yes sorry, and I found one more thing: It should be Modify instead of Edit and without the : (colon) Then it would match the breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206703|0 |1 is obsolete| | --- Comment #16 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206841&action=edit Bug 43333: Allow the resource edit title to be a callback Bug 43333: Allow the resource edit title to be a callback Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Modify <Vendor Name>". Fixes for breadcrumbs Modify Informatics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #17 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Michaela Sieber from comment #15)
Yes sorry, and I found one more thing:
It should be Modify instead of Edit and without the : (colon)
Then it would match the breadcrumbs
Hi Michaela, Added the comments in the patch for breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from David Nind <david@davidnind.com> --- I've failed QA because: 1. The vendor name is an H2 instead of an H1 - this is an accessibility issue (headings should follow a logical structure and be semantically correct, for example: H2 headings should follow H1 headings, you shouldn't miss headings) In addition: 1. This is possibly a wider bug with Vue-based modules, but the browser page title, breadcrumb, and page title should all be consistent. A lot of work went into previous releases by Owen to make this consistent. Maybe this has been discussed on other bugs/elsewhere? 2. "Edit" changed to "Modify": this seems "consistent" with other pages - the label is "Edit", but on the page itself it is "Modify...". If there is not a coding guideline/user interface guideline, I think we should have one. (I personally think it is weird to have the action/label as "Edit", but then have the page title/form title as "Modify ...."). This is a separate issue for all of Koha though. Testing notes (using KTD): 1. Before the patch: - In KTD, there is one vendor already set up, "My Vendor" - Viewing a vendor: . Vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor: . Edit vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify vendor . Page title (browser title): Vendors > Koha 2. After the patch: - Rebuild everything: yarn build - Restart everything: restart_all - Viewing a vendor (Vendor #1 - My Vendor): . My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor (Vendor #1 - My Vendor): . Modify My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify My Vendor . Page title (browser title): Vendors > Koha -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org