https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 CC| |jonathan.druart@gmail.com, | |katrin.fischer@bsz-bw.de --- Comment #2 from Michaela Sieber <michaela.sieber@kit.edu> --- I guess it was introduced in 25.11 with the VueJS architecture rethink (Bug 38201) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Yes in version 25.04 it is showing the vendor name, for example: Amazon but in 25.11 and higher versions, it is showing for example: Vendor #1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 206621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206621&action=edit Bug 43333: Allow the resource title to be a callback Converts the title of the ResourceShow view to be a callback to allow resources to inject their own properties into the title section Test plan: 1) Create a vendor and navigate to the display view 2) The title will be "Vendor #(id)" 3) Apply patches and yarn js:build 4) Hard refresh the page and the title should now be the vendor name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #6 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206657&action=edit Bug 43333: Allow the resource edit title to be a callback Fix for the edit page. Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit <Vendor Name>" (or "Edit: <Vendor Name>"). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Jonathan Druart from comment #7)

In this second patch, shouldn't

+ : $__("New vendor");

be replaced with

instancedResource.i18n.newLabel

so we don't repeat "New vendor"?

Thanks, Jonathan, for the comment. Will check and update the patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #10 from Amit Gupta <amitddng135@gmail.com> --- Added the comments shared by Jonathan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #11 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 206670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206670&action=edit Bug 43333: Allow the resource title to be a callback Converts the title of the ResourceShow view to be a callback to allow resources to inject their own properties into the title section Test plan: 1) Create a vendor and navigate to the display view 2) The title will be "Vendor #(id)" 3) Apply patches and yarn js:build 4) Hard refresh the page and the title should now be the vendor name Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.ai> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206671|0 |1 is obsolete| | --- Comment #13 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 206703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206703&action=edit Bug 43333: Allow the resource edit title to be a callback Bug 43333: Allow the resource edit title to be a callback Follow-up to allow resources to inject custom titles on the edit view (ResourceFormSave) using a `getEditTitle` callback, matching the existing `getShowTitle` implementation. Test plan: 1) Edit an existing vendor. 2) Notice the heading is "Edit Vendor #<id>". 3) Apply patch and run `yarn js:build`. 4) Hard refresh and edit the vendor again. 5) The heading should now display "Edit: <Vendor Name>". Fix with comments shared by Jonathan Druart -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Michaela Sieber <michaela.sieber@kit.edu> --- Yes sorry, and I found one more thing: It should be Modify instead of Edit and without the : (colon) Then it would match the breadcrumbs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from David Nind <david@davidnind.com> --- I've failed QA because: 1. The vendor name is an H2 instead of an H1 - this is an accessibility issue (headings should follow a logical structure and be semantically correct, for example: H2 headings should follow H1 headings, you shouldn't miss headings) In addition: 1. This is possibly a wider bug with Vue-based modules, but the browser page title, breadcrumb, and page title should all be consistent. A lot of work went into previous releases by Owen to make this consistent. Maybe this has been discussed on other bugs/elsewhere? 2. "Edit" changed to "Modify": this seems "consistent" with other pages - the label is "Edit", but on the page itself it is "Modify...". If there is not a coding guideline/user interface guideline, I think we should have one. (I personally think it is weird to have the action/label as "Edit", but then have the page title/form title as "Modify ...."). This is a separate issue for all of Koha though. Testing notes (using KTD): 1. Before the patch: - In KTD, there is one vendor already set up, "My Vendor" - Viewing a vendor: . Vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor: . Edit vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify vendor . Page title (browser title): Vendors > Koha 2. After the patch: - Rebuild everything: yarn build - Restart everything: restart_all - Viewing a vendor (Vendor #1 - My Vendor): . My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor (Vendor #1 - My Vendor): . Modify My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify My Vendor . Page title (browser title): Vendors > Koha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Angela Berrett from comment #19)

I haven't had a chance to test this yet, but I have one quick question. Does this move the vendor number somewhere? Or just not show it at all anymore? We actually do use vendor numbers a lot, so I just want to check that the number isn't disappearing.

With the proposed patches, the Koha-assigned vendor number is not shown anywhere on the vendor page or search results. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 207263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207263&action=edit Screenshots - Before and after patches I've added some before and after screenshots with the current patches, along with the patron details page. Some options: 1. Put vendor number in brackets after the vendor name, for example: My Vendor (1) 2. Add in the details section under the "Vendor name field" - Vendor number: 1 OR - Koha vendor number: 1 Will add Owen to the bug to get his input from a user interface consistency perspective. -- You are receiving this mail because: You are watching all bug changes.