[Bug 21176] New: decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Bug ID: 21176 Summary: decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77761&action=edit Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77761|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79326&action=edit Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree with Jonathan that it would be better to fix this more thoroughly but that the patch is pragmatic and it resolves the problem for now. Signing off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79326|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 79788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79788&action=edit Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org