[Bug 6427] New: Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Bug #: 6427 Summary: Rewrite of the accounts system Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org The accounts system is in need of a rewrite. This will solve two purposes: 1) It'll make the code a lot nicer, and things won't be doing direct table access from all over the place. Also, some unused and long dead features will be stripped out. 2) It'll allow the account code to be a lot more flexible, making features like partial payments a whole lot seamless. This is in progress, it can be viewed here: http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bywater/wr7... And accessed via: git://git.catalyst.net.nz/git/public/koha.git, in the branch "bywater/wr78012" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10057 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8798 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robin@catalyst.net.nz |kyle.m.hall@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2454 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21922&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22704&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21922|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22705&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22705|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22708&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22704|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22709&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22708|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22710&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Also available at http://git.bywatersolutions.com/koha.git/shortlog/refs/heads/accounts_rewrit... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22710|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22741&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22709|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22870&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22741|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22871&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22870|0 |1 is obsolete| | Attachment #22871|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22872&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22872|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22873&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22873|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22874&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22874|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22875&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22875|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22876&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22876|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22881&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22881|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22889&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22889|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22940&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22940|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22948&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22948|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22949&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22949|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22995&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22995|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23000&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Kyle, I would like to start a development using DBIx and I am taking a look at this development. I think we should have some guided guidelines on about how to organize our classes. Looking at your code, I have some questions to ask: 1/ Don't you think we should avoid calls to Koha::Database in pl files ? 2/ Don't you think new module in the Koha namespace should be OOP (for ex. using Class::Accessor)? Outside the DBIx scope, I am wondering why do you have 2 scripts account_payment.pl and members/account_payment_do.pl. I suppose it is in order to remove the $op variable. I think it would be better to head towards a REST architecture. For example, here, we could imagine executing the AddCredit routine on a POST method and using the "show/list" view on a GET method. For discussion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- I add Galen, Chris and Paul in the loop. But maybe the discussion should be on the koha-devel mailing-list. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2546 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23000|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23137&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23137|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23158&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23158|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23161&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23161|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23171&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23171|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23186&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Sorry I missed this comment until now!
1/ Don't you think we should avoid calls to Koha::Database in pl files ?
Using DBIx::Class is, afaik, allowed in pl files. Requiring it to be called from modules only just requires yet another layer of abstraction. The only time this is necessary is when business logic needs to be applied. That is, we should definitely keep code DRY by moving repeated chunks of code into a module subroutine, but for a single line call that is not affected by system preferences, this is both unnecessary and unwanted. It would merely slow the system down. For repeated pieces of code that utilize system preferences, I think they *should* be in modules. Better yet, they should be part of the DBIx::Class files, but we haven't gotten to that stage yet. If I am violating my own person views written above, it's simply because I am attempting to implement this new accounting system while making as few modifications to existing code as possible. I think any violations will need to be taken care of eventually. This is of course, assuming everyone else agrees with my views. In any case, those violations can and should be taken care of post-push once we have formalized our policies regarding usage of DBIC.
2/ Don't you think new module in the Koha namespace should be OOP (for ex. using Class::Accessor)?
Modules in the Koha namespace are not required to be OOP, and I can see no advantage to making Koha::Accounts OOP. The data objects themselves are OO, and Koha::Accounts is just a layer around these objects to manage them.
Outside the DBIx scope, I am wondering why do you have 2 scripts account_payment.pl and members/account_payment_do.pl. I suppose it is in order to remove the $op variable. I think it would be better to head towards a REST architecture. For example, here, we could imagine executing the AddCredit routine on a POST method and using the "show/list" view on a GET
That is certainly an interesting proposition. What advantages do you see to this? I'd take it much further and say we should make *all* fetching, creating, and updating of data be via REST methods, and make our scripts use those methods via ajax. I think this will make Koha much more responsive, and allow far more flexible integration with other software. What do you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- One example of moving business logic into DBIC. Items should be smart enough to know that when item-level_itypes is set to biblio record, the call to $item->itype() should return $item->biblio->itemtype() instead. I imagine there is a way to override the existing itype() method, or we could just add a new method itemtype_by_preference() or similar. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23186|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23269&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23269|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23275&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23275|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #36 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 23276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276 Bug 6427 - Rewrite of the accounts system Review of attachment 23276: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6427&attachment=23276) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +1029,4 @@
sub GetAuthorisedValues { my ( $category, $selected, $opac ) = @_; + warn "GetAuthorisedValues( $category, $selected, $opac )";
This needs a debug switch, or to be removed @@ +1076,4 @@
push @results, $data; } $sth->finish; + warn "RET: " . Data::Dumper::Dumper( \@results );
And this too, or the logs get loud very very fast ::: misc/release_notes/release_notes_3_10_0.txt @@ +1762,4 @@
8996 normal In result page items with negative notforloan are available 9017 normal Quote of the day: Table footer not translated 5312 minor XHTML correction in authority summary + 8009 minor Item descriptive data not populated on account_payment.pl
Shouldnt be in the patch, this looks like a search and replace gone wrong ::: misc/release_notes/release_notes_3_12_0.txt @@ +579,4 @@
8429 minor Unnecessary use of Exporter in SIP/ILS objects 9292 minor Remove dead code related to 'publictype' 9401 minor Javascript used for tags handling wants access to CGISESSID cookie + 9582 minor Unused code in members/account_payment.pl
Hmm not sure why this is in the patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #37 from Galen Charlton <gmcharlt@gmail.com> --- In addition to the specific points that Chris has made -- which, to be frank, do not inspire confidence that the rewrite patch has been sufficiently tested by the patch submitter -- this patch is simply too large to evaluate as is. I *strongly* encourage you to break it up into a series of patches that, in effect, tell a story that can be evaluated, or at least read, a patch at a time. A possible sequence might look like this: * test cases: this is an opportunity for the test cases to describe the new API and provide some confidence that all aspect of the existing behavior have been covered. * DB schema updates * schema upgrade -- as this will require particularly close attention * introduction of the new API in the Koha namespace * elimination of the old C4 API and staff-side script changes * public catalog-side changes Other ways of organizing it are of course possible, but the main point is to break it up into smaller units that can be read one at a time, even if the entire series has to be applied for it to work at all. It would be even better, although not necessarily possible, to structure the patch series in such a way that parts of it can be independently applied. Also, to reiterate the point in my first paragraph: the more that you take care to eliminate debug code and trivial violations of the QA guidelines, the easier it will be for patch reviewers to focus on the substance. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2456 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2456 |2546 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2696 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23276|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23391&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23391|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23392&action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23392|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23400&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23401&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23402&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23403&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23404&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23405&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23406&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23407&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23408&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23409&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23410&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23411&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23412&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23413&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Good calls. I had expected koha-qa.pl to pick those warns up ( it usually does ). Spot on! Thanks for catching those! Kyle (In reply to Chris Cormack from comment #36)
Comment on attachment 23276 [details] [review] Bug 6427 - Rewrite of the accounts system
Review of attachment 23276 [details] [review]: -----------------------------------------------------------------
::: C4/Koha.pm @@ +1029,4 @@
sub GetAuthorisedValues { my ( $category, $selected, $opac ) = @_; + warn "GetAuthorisedValues( $category, $selected, $opac )";
This needs a debug switch, or to be removed
@@ +1076,4 @@
push @results, $data; } $sth->finish; + warn "RET: " . Data::Dumper::Dumper( \@results );
And this too, or the logs get loud very very fast
::: misc/release_notes/release_notes_3_10_0.txt @@ +1762,4 @@
8996 normal In result page items with negative notforloan are available 9017 normal Quote of the day: Table footer not translated 5312 minor XHTML correction in authority summary + 8009 minor Item descriptive data not populated on account_payment.pl
Shouldnt be in the patch, this looks like a search and replace gone wrong
::: misc/release_notes/release_notes_3_12_0.txt @@ +579,4 @@
8429 minor Unnecessary use of Exporter in SIP/ILS objects 9292 minor Remove dead code related to 'publictype' 9401 minor Javascript used for tags handling wants access to CGISESSID cookie + 9582 minor Unused code in members/account_payment.pl
Hmm not sure why this is in the patch?
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Galen Charlton from comment #37)
In addition to the specific points that Chris has made -- which, to be frank, do not inspire confidence that the rewrite patch has been sufficiently tested by the patch submitter -- this patch is simply too large to evaluate as is.
I assure you that I have tested it quite a bit, but I also agree with you. I plan to continue testing to with as many add edge cases as I can imagine. So far everything has been quite solid. My largest and foremost concern at that point is to ensure that updatedatabase.pl ports all existing accounting data to the new accounting system properly.
I *strongly* encourage you to break it up into a series of patches that, in effect, tell a story that can be evaluated, or at least read, a patch at a time. A possible sequence might look like this:
Other ways of organizing it are of course possible, but the main point is to break it up into smaller units that can be read one at a time, even if the entire series has to be applied for it to work at all.
Done! I hope I haven't swung too far the other way with this patch series. I've tried to break it up into functional components as you can see ( schema, modules, intranet, opac, etc... ).
It would be even better, although not necessarily possible, to structure the patch series in such a way that parts of it can be independently applied.
Each of these patches should be independently apply-able. However, I'm afraid some parts will not function without the patches after it ( I'm looking at you part 11 ). Splitting this patch was quite a task, and I'm afraid I did not keep it fully chronological such that each patch only requires the preceding patches to to be functional. If you have any suggestions on re-ordering the patches I will be happy to do so!
Also, to reiterate the point in my first paragraph: the more that you take care to eliminate debug code and trivial violations of the QA guidelines, the easier it will be for patch reviewers to focus on the substance.
I agree. This patch series currently passes koha-qa.pl, so I have a fair confidence that I have taken care of all violations at this point! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23400|0 |1 is obsolete| | Attachment #23401|0 |1 is obsolete| | Attachment #23402|0 |1 is obsolete| | Attachment #23403|0 |1 is obsolete| | Attachment #23404|0 |1 is obsolete| | Attachment #23405|0 |1 is obsolete| | Attachment #23406|0 |1 is obsolete| | Attachment #23407|0 |1 is obsolete| | Attachment #23408|0 |1 is obsolete| | Attachment #23409|0 |1 is obsolete| | Attachment #23410|0 |1 is obsolete| | Attachment #23411|0 |1 is obsolete| | Attachment #23412|0 |1 is obsolete| | Attachment #23413|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23420&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23421&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23422&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23423&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23424&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23425&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23426&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23427&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23428&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23429&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23430&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23431&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23432&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23433&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23420|0 |1 is obsolete| | Attachment #23421|0 |1 is obsolete| | Attachment #23422|0 |1 is obsolete| | Attachment #23423|0 |1 is obsolete| | Attachment #23424|0 |1 is obsolete| | Attachment #23425|0 |1 is obsolete| | Attachment #23426|0 |1 is obsolete| | Attachment #23427|0 |1 is obsolete| | Attachment #23428|0 |1 is obsolete| | Attachment #23429|0 |1 is obsolete| | Attachment #23430|0 |1 is obsolete| | Attachment #23431|0 |1 is obsolete| | Attachment #23432|0 |1 is obsolete| | Attachment #23433|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23440&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23440|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23441&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23442&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23443&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23444&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23445&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23446&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23447&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23448&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23449&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23450&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23451&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23452&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23453&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23454&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23441|0 |1 is obsolete| | Attachment #23442|0 |1 is obsolete| | Attachment #23443|0 |1 is obsolete| | Attachment #23444|0 |1 is obsolete| | Attachment #23445|0 |1 is obsolete| | Attachment #23446|0 |1 is obsolete| | Attachment #23447|0 |1 is obsolete| | Attachment #23448|0 |1 is obsolete| | Attachment #23449|0 |1 is obsolete| | Attachment #23450|0 |1 is obsolete| | Attachment #23451|0 |1 is obsolete| | Attachment #23452|0 |1 is obsolete| | Attachment #23453|0 |1 is obsolete| | Attachment #23454|0 |1 is obsolete| | --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23458&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23459&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23460&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23461&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23462&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23463&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23464&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23465&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23466&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23467&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23468&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23469&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23470&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23471&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11373 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23603&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23458|0 |1 is obsolete| | Attachment #23459|0 |1 is obsolete| | Attachment #23460|0 |1 is obsolete| | Attachment #23461|0 |1 is obsolete| | Attachment #23462|0 |1 is obsolete| | Attachment #23463|0 |1 is obsolete| | Attachment #23464|0 |1 is obsolete| | Attachment #23465|0 |1 is obsolete| | Attachment #23466|0 |1 is obsolete| | Attachment #23467|0 |1 is obsolete| | Attachment #23468|0 |1 is obsolete| | Attachment #23469|0 |1 is obsolete| | Attachment #23470|0 |1 is obsolete| | Attachment #23471|0 |1 is obsolete| | Attachment #23603|0 |1 is obsolete| | --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23643&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23644&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23645&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23646&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23647&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23648&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23649&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23650&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23651&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23652&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23653&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23654&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23655&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23656&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23657&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9448 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry@bywatersolutions.com --- Comment #115 from Larry Baerveldt <larry@bywatersolutions.com> --- Warning, this code seems to break SIP functionality. C4/ILS.pm is looking for C4/Accounts.pm, but this update removes it. Test: cd C4/SIP perl -c ILS.pm Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23. Please do not signoff until SIP functionality has been restored. - Larry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23643|0 |1 is obsolete| | Attachment #23644|0 |1 is obsolete| | Attachment #23645|0 |1 is obsolete| | Attachment #23646|0 |1 is obsolete| | Attachment #23647|0 |1 is obsolete| | Attachment #23648|0 |1 is obsolete| | Attachment #23649|0 |1 is obsolete| | Attachment #23650|0 |1 is obsolete| | Attachment #23651|0 |1 is obsolete| | Attachment #23652|0 |1 is obsolete| | Attachment #23653|0 |1 is obsolete| | Attachment #23654|0 |1 is obsolete| | Attachment #23655|0 |1 is obsolete| | Attachment #23656|0 |1 is obsolete| | Attachment #23657|0 |1 is obsolete| | --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23937&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23938&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #118 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23939&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23940&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #120 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23941&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23942&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #122 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23943&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23944&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #124 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23945&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23946&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #126 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23947&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #127 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23948&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #128 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23949&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #129 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23950&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #130 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23951&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #131 from Kyle M Hall <kyle@bywatersolutions.com> --- This new patch set fixes the SIP2 issue. (In reply to Larry Baerveldt from comment #115)
Warning, this code seems to break SIP functionality. C4/ILS.pm is looking for C4/Accounts.pm, but this update removes it.
Test: cd C4/SIP perl -c ILS.pm
Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23.
Please do not signoff until SIP functionality has been restored.
- Larry
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23937|0 |1 is obsolete| | Attachment #23938|0 |1 is obsolete| | Attachment #23939|0 |1 is obsolete| | Attachment #23940|0 |1 is obsolete| | Attachment #23941|0 |1 is obsolete| | Attachment #23942|0 |1 is obsolete| | Attachment #23943|0 |1 is obsolete| | Attachment #23944|0 |1 is obsolete| | Attachment #23945|0 |1 is obsolete| | Attachment #23946|0 |1 is obsolete| | Attachment #23947|0 |1 is obsolete| | Attachment #23948|0 |1 is obsolete| | Attachment #23949|0 |1 is obsolete| | Attachment #23950|0 |1 is obsolete| | Attachment #23951|0 |1 is obsolete| | --- Comment #132 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24612&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #133 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24613&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #134 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24614&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #135 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24615&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #136 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24616&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #137 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24617&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #138 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24618&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #139 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24619&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24620&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #141 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24621&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24622&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24623&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24624&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24625&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24626&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24627&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24627|0 |1 is obsolete| | --- Comment #148 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24628&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11622 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24612|0 |1 is obsolete| | Attachment #24613|0 |1 is obsolete| | Attachment #24614|0 |1 is obsolete| | Attachment #24615|0 |1 is obsolete| | Attachment #24616|0 |1 is obsolete| | Attachment #24617|0 |1 is obsolete| | Attachment #24618|0 |1 is obsolete| | Attachment #24619|0 |1 is obsolete| | Attachment #24620|0 |1 is obsolete| | Attachment #24621|0 |1 is obsolete| | Attachment #24622|0 |1 is obsolete| | Attachment #24623|0 |1 is obsolete| | Attachment #24624|0 |1 is obsolete| | Attachment #24625|0 |1 is obsolete| | Attachment #24626|0 |1 is obsolete| | Attachment #24628|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24757&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24758&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #151 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24759&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24760&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #153 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24761&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24762&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24763&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24764&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24765&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24766&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24767&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24768&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #161 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24769&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24770&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #163 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24771&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #164 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24772&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #165 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24777&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24757|0 |1 is obsolete| | Attachment #24758|0 |1 is obsolete| | Attachment #24759|0 |1 is obsolete| | Attachment #24760|0 |1 is obsolete| | Attachment #24761|0 |1 is obsolete| | Attachment #24762|0 |1 is obsolete| | Attachment #24763|0 |1 is obsolete| | Attachment #24764|0 |1 is obsolete| | Attachment #24765|0 |1 is obsolete| | Attachment #24766|0 |1 is obsolete| | Attachment #24767|0 |1 is obsolete| | Attachment #24768|0 |1 is obsolete| | Attachment #24769|0 |1 is obsolete| | Attachment #24770|0 |1 is obsolete| | Attachment #24771|0 |1 is obsolete| | Attachment #24772|0 |1 is obsolete| | Attachment #24777|0 |1 is obsolete| | --- Comment #166 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24792&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #167 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24793&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #168 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24794&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #169 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24795&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #170 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24796&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #171 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24797&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #172 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24798&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #173 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24799&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #174 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24800&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #175 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24801&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #176 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24802&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #177 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24803&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #178 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24804&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #179 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24805&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #180 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24806&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #181 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24807&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #182 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24808&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24792|0 |1 is obsolete| | Attachment #24793|0 |1 is obsolete| | Attachment #24794|0 |1 is obsolete| | Attachment #24795|0 |1 is obsolete| | Attachment #24796|0 |1 is obsolete| | Attachment #24797|0 |1 is obsolete| | Attachment #24798|0 |1 is obsolete| | Attachment #24799|0 |1 is obsolete| | Attachment #24800|0 |1 is obsolete| | Attachment #24801|0 |1 is obsolete| | Attachment #24802|0 |1 is obsolete| | Attachment #24803|0 |1 is obsolete| | Attachment #24804|0 |1 is obsolete| | Attachment #24805|0 |1 is obsolete| | Attachment #24806|0 |1 is obsolete| | Attachment #24807|0 |1 is obsolete| | Attachment #24808|0 |1 is obsolete| | --- Comment #183 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24809&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #184 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24810&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #185 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24811&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #186 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24812&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #187 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24813&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #188 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24814&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #189 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24815&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #190 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24816&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #191 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24817&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #192 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24818&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #193 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24819&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #194 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24820&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #195 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24821&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #196 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24822&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #197 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24823&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #198 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24824&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #199 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24825&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24809|0 |1 is obsolete| | Attachment #24810|0 |1 is obsolete| | Attachment #24811|0 |1 is obsolete| | Attachment #24812|0 |1 is obsolete| | Attachment #24813|0 |1 is obsolete| | Attachment #24814|0 |1 is obsolete| | Attachment #24815|0 |1 is obsolete| | Attachment #24816|0 |1 is obsolete| | Attachment #24817|0 |1 is obsolete| | Attachment #24818|0 |1 is obsolete| | Attachment #24819|0 |1 is obsolete| | Attachment #24820|0 |1 is obsolete| | Attachment #24821|0 |1 is obsolete| | Attachment #24822|0 |1 is obsolete| | Attachment #24823|0 |1 is obsolete| | Attachment #24824|0 |1 is obsolete| | Attachment #24825|0 |1 is obsolete| | --- Comment #200 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24826&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #201 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24827&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #202 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24828&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #203 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24829&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #204 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24830&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #205 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24831&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #206 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24832&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #207 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24833&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #208 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24834&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #209 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24835&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #210 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24836&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #211 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24837&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #212 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24838&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #213 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24839&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #214 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24840&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #215 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24841&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #216 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24842&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #217 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24843&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #218 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24844&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkopaczka@afm.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #219 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- I've looked quickly at this patch, got 2 issues (or not, correct me if I'm wrong): 1/ In part 4 patch, there is reference to js file that don't exist in repository, next parts also don't contain this file. Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface %]/[% theme %]/en/js/strings.js"></script> 2/ In part 3, function format_without_symbol don't handle properly, national currencies without leading symbol (eg PLN). It truncate always first character even if it's a number. return substr( $self->format( $amount, FMT_SYMBOL ), 1 ); We can't assume that format always return symbol before number. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11887 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24826|0 |1 is obsolete| | Attachment #24827|0 |1 is obsolete| | Attachment #24828|0 |1 is obsolete| | Attachment #24829|0 |1 is obsolete| | Attachment #24830|0 |1 is obsolete| | Attachment #24831|0 |1 is obsolete| | Attachment #24832|0 |1 is obsolete| | Attachment #24833|0 |1 is obsolete| | Attachment #24834|0 |1 is obsolete| | Attachment #24835|0 |1 is obsolete| | Attachment #24836|0 |1 is obsolete| | Attachment #24837|0 |1 is obsolete| | Attachment #24838|0 |1 is obsolete| | Attachment #24839|0 |1 is obsolete| | Attachment #24840|0 |1 is obsolete| | Attachment #24841|0 |1 is obsolete| | Attachment #24842|0 |1 is obsolete| | Attachment #24843|0 |1 is obsolete| | Attachment #24844|0 |1 is obsolete| | --- Comment #220 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25777&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #221 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25778&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #222 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25779&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #223 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25780&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #224 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25781&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #225 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25782&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #226 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25783&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #227 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25784&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #228 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25785&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #229 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25786&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #230 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25787&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #231 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25788&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #232 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25789&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #233 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25790&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #234 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25791&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #235 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25792&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #236 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25793&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #237 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25794&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #238 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25795&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25777|0 |1 is obsolete| | --- Comment #239 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25796&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25778|0 |1 is obsolete| | --- Comment #240 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25797&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25779|0 |1 is obsolete| | Attachment #25780|0 |1 is obsolete| | Attachment #25781|0 |1 is obsolete| | Attachment #25782|0 |1 is obsolete| | Attachment #25783|0 |1 is obsolete| | Attachment #25784|0 |1 is obsolete| | Attachment #25785|0 |1 is obsolete| | Attachment #25786|0 |1 is obsolete| | Attachment #25787|0 |1 is obsolete| | Attachment #25788|0 |1 is obsolete| | Attachment #25789|0 |1 is obsolete| | Attachment #25790|0 |1 is obsolete| | Attachment #25791|0 |1 is obsolete| | Attachment #25792|0 |1 is obsolete| | Attachment #25793|0 |1 is obsolete| | Attachment #25794|0 |1 is obsolete| | Attachment #25795|0 |1 is obsolete| | Attachment #25796|0 |1 is obsolete| | Attachment #25797|0 |1 is obsolete| | --- Comment #241 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25798&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #242 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25799&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #243 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25800&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #244 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25801&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #245 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25802&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #246 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25803&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #247 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25804&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #248 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25805&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #249 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25806&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #250 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25807&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #251 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25808&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #252 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25809&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #253 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25810&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #254 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25811&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #255 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25812&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #256 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25813&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #257 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25814&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #258 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25815&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #259 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25816&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #260 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks for letting me know! I've rolled the fixes for these 2 issues into the main patch set since they are still not signed off, rather than post a qa followup. (In reply to Rafal Kopaczka from comment #219)
I've looked quickly at this patch, got 2 issues (or not, correct me if I'm wrong):
1/ In part 4 patch, there is reference to js file that don't exist in repository, next parts also don't contain this file. Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface %]/[% theme %]/en/js/strings.js"></script>
2/ In part 3, function format_without_symbol don't handle properly, national currencies without leading symbol (eg PLN). It truncate always first character even if it's a number. return substr( $self->format( $amount, FMT_SYMBOL ), 1 ); We can't assume that format always return symbol before number.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #261 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25930&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #262 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25932&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #263 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25933&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25932|0 |1 is obsolete| | --- Comment #264 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25934&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #265 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 26033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26033&action=edit opac screen (In reply to Kyle M Hall from comment #260)
Thanks for letting me know! I've rolled the fixes for these 2 issues into the main patch set since they are still not signed off, rather than post a qa followup.
There are still issues with different currencies in "Amount to pay:" box. Previous is fixed, so there are new bugs :) 1/ For EUR and many other currencies, decimal separator is comma not dot. When page is loaded everything looks fine, but after any checkbox change, when amount is recalculated by javascript decimal part is cut off. Also for PLN, initial value in amount to pay box is ended with "PLN" chars. 2/ Not bug, but it would be nice to display title for manual created invoice, of course when barcode is filled. Now on Pay Fines page, only description and notes for manual fines are displayed. 3/ In OPAC: after expanding payment details there are many undefined value, I'm not sure if this should be empty or values aren't fetched properly? I'll attach some screens if something is unclear :) Nb. UTF-8 encoding from screens is IIRC, some other bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #266 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 26034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26034&action=edit Pay Fines Well, sum for decimal didn't go well... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #267 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 26035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26035&action=edit Currencies Different separators, for currencies. BTW is it possible to upload multiple attachment by 1 message? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26034|0 |1 is obsolete| | --- Comment #268 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 26036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26036&action=edit Pay Fines (In reply to Rafal Kopaczka from comment #266)
Created attachment 26034 [details] Pay Fines
Well, sum for decimal didn't go well... better content type :)
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #269 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 26107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26107&action=edit typo in fines header It says "Outsanding", not "Outstanding" on a Patron > Fines details page. See attached. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2696 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25798|0 |1 is obsolete| | Attachment #25799|0 |1 is obsolete| | Attachment #25800|0 |1 is obsolete| | Attachment #25801|0 |1 is obsolete| | Attachment #25802|0 |1 is obsolete| | Attachment #25803|0 |1 is obsolete| | Attachment #25804|0 |1 is obsolete| | Attachment #25805|0 |1 is obsolete| | Attachment #25806|0 |1 is obsolete| | Attachment #25807|0 |1 is obsolete| | Attachment #25808|0 |1 is obsolete| | Attachment #25809|0 |1 is obsolete| | Attachment #25810|0 |1 is obsolete| | Attachment #25811|0 |1 is obsolete| | Attachment #25812|0 |1 is obsolete| | Attachment #25813|0 |1 is obsolete| | Attachment #25814|0 |1 is obsolete| | Attachment #25815|0 |1 is obsolete| | Attachment #25816|0 |1 is obsolete| | Attachment #25930|0 |1 is obsolete| | Attachment #25933|0 |1 is obsolete| | Attachment #25934|0 |1 is obsolete| | --- Comment #270 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27167&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #271 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27168&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #272 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27169&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #273 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27170&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #274 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27171&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #275 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27172&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #276 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27173&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #277 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27174&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #278 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27175&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #279 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27176&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #280 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27177&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #281 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27178&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #282 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27179&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #283 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27180&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #284 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27181&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #285 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27182&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #286 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27183&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #287 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27184&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #288 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27185&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #289 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27186&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #290 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27187&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #291 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27189&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #292 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27190&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #293 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27197&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #294 from Owen Leonard <oleonard@myacpl.org> --- Auto-merging Koha/DateUtils.pm CONFLICT (content): Merge conflict in Koha/DateUtils.pm Failed to merge in the changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #295 from Galen Charlton <gmcharlt@gmail.com> --- Note that the push of bug 6273 adds (at least) three potential payment types to deal with: Pay00 - SIP2 cash payment Pay01 - SIP2 VISA payment Pay02 - SIP2 credit card payment Of course, it wouldn't be surprising if there are SIP2 devices that define non-standard payment types as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #296 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Galen Charlton from comment #295)
Note that the push of bug 6273 adds (at least) three potential payment types to deal with:
Pay00 - SIP2 cash payment Pay01 - SIP2 VISA payment Pay02 - SIP2 credit card payment
Of course, it wouldn't be surprising if there are SIP2 devices that define non-standard payment types as well.
We have two choices here, we can either hard code these payment types in ( which will rarely be used ) *or* we can add setup documentation to have the library define these as MANUAL_DEBIT authorised values! Considering your final statement, I think that would be the best way to go. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27167|0 |1 is obsolete| | Attachment #27168|0 |1 is obsolete| | Attachment #27169|0 |1 is obsolete| | Attachment #27170|0 |1 is obsolete| | Attachment #27171|0 |1 is obsolete| | Attachment #27172|0 |1 is obsolete| | Attachment #27173|0 |1 is obsolete| | Attachment #27174|0 |1 is obsolete| | Attachment #27175|0 |1 is obsolete| | Attachment #27176|0 |1 is obsolete| | Attachment #27177|0 |1 is obsolete| | Attachment #27178|0 |1 is obsolete| | Attachment #27179|0 |1 is obsolete| | Attachment #27180|0 |1 is obsolete| | Attachment #27181|0 |1 is obsolete| | Attachment #27182|0 |1 is obsolete| | Attachment #27183|0 |1 is obsolete| | Attachment #27184|0 |1 is obsolete| | Attachment #27185|0 |1 is obsolete| | Attachment #27186|0 |1 is obsolete| | Attachment #27187|0 |1 is obsolete| | Attachment #27189|0 |1 is obsolete| | Attachment #27190|0 |1 is obsolete| | Attachment #27197|0 |1 is obsolete| | --- Comment #297 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28067&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #298 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28068&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #299 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28069&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #300 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28070&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #301 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28071&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #302 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28072&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #303 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28073&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #304 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28074&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #305 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28075&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #306 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28076&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #307 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28077&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #308 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28078&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #309 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28079&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #310 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28080&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #311 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28081&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #312 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28082&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #313 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28083&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #314 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28084&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #315 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28085&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #316 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28086&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #317 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28087&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #318 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28088&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #319 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28089&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #320 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28090&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #321 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28091&action=edit Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance The total being treated as the total ammount of fines is actually the total amount of charges that are *not* fines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26107|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28067|0 |1 is obsolete| | Attachment #28068|0 |1 is obsolete| | Attachment #28069|0 |1 is obsolete| | Attachment #28070|0 |1 is obsolete| | Attachment #28071|0 |1 is obsolete| | Attachment #28072|0 |1 is obsolete| | Attachment #28073|0 |1 is obsolete| | Attachment #28074|0 |1 is obsolete| | Attachment #28075|0 |1 is obsolete| | Attachment #28076|0 |1 is obsolete| | Attachment #28077|0 |1 is obsolete| | Attachment #28078|0 |1 is obsolete| | Attachment #28079|0 |1 is obsolete| | Attachment #28080|0 |1 is obsolete| | Attachment #28081|0 |1 is obsolete| | Attachment #28082|0 |1 is obsolete| | Attachment #28083|0 |1 is obsolete| | Attachment #28084|0 |1 is obsolete| | Attachment #28085|0 |1 is obsolete| | Attachment #28086|0 |1 is obsolete| | Attachment #28087|0 |1 is obsolete| | Attachment #28088|0 |1 is obsolete| | Attachment #28089|0 |1 is obsolete| | Attachment #28090|0 |1 is obsolete| | Attachment #28091|0 |1 is obsolete| | --- Comment #322 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28527&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #323 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28528&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #324 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28529&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #325 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28530&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #326 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28531&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #327 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28532&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #328 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28533&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #329 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28534&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #330 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28535&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #331 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28536&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #332 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28537&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #333 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28538&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #334 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28539&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #335 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28540&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #336 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28541&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #337 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28542&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #338 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28543&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #339 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28544&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #340 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28545&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #341 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28546&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #342 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28547&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #343 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28548&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #344 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28549&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #345 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28550&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #346 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28551&action=edit Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance The total being treated as the total ammount of fines is actually the total amount of charges that are *not* fines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #347 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28552&action=edit Bug 6427 [Part 26] - Simplify and improve account normalization and balancing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28552|0 |1 is obsolete| | --- Comment #348 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28553&action=edit Bug 6427 [Part 26] - Simplify and improve account normalization and balancing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #349 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28555&action=edit Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28555|0 |1 is obsolete| | --- Comment #350 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28556&action=edit Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #351 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28561&action=edit Bug 6427 [Part 28] - Add ability to void payments * Adds ability to void payments * Adds missing setting up updated_on for debits and credits * Adds the display of the offset type if there is one * Adds a column showing the amount paid on a given fine in the payments view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28561|0 |1 is obsolete| | --- Comment #352 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28563&action=edit Bug 6427 [Part 28] - Add ability to void payments * Adds ability to void payments * Adds missing setting up updated_on for debits and credits * Adds the display of the offset type if there is one * Adds a column showing the amount paid on a given fine in the payments view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28563|0 |1 is obsolete| | --- Comment #353 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28564&action=edit Bug 6427 [Part 28] - Add ability to void payments * Adds ability to void payments * Adds missing setting up updated_on for debits and credits * Adds the display of the offset type if there is one * Adds a column showing the amount paid on a given fine in the payments view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28527|0 |1 is obsolete| | Attachment #28528|0 |1 is obsolete| | Attachment #28529|0 |1 is obsolete| | Attachment #28530|0 |1 is obsolete| | Attachment #28531|0 |1 is obsolete| | Attachment #28532|0 |1 is obsolete| | Attachment #28533|0 |1 is obsolete| | Attachment #28534|0 |1 is obsolete| | Attachment #28535|0 |1 is obsolete| | Attachment #28536|0 |1 is obsolete| | Attachment #28537|0 |1 is obsolete| | Attachment #28538|0 |1 is obsolete| | Attachment #28539|0 |1 is obsolete| | Attachment #28540|0 |1 is obsolete| | Attachment #28541|0 |1 is obsolete| | Attachment #28542|0 |1 is obsolete| | Attachment #28543|0 |1 is obsolete| | Attachment #28544|0 |1 is obsolete| | Attachment #28545|0 |1 is obsolete| | Attachment #28546|0 |1 is obsolete| | Attachment #28547|0 |1 is obsolete| | Attachment #28548|0 |1 is obsolete| | Attachment #28549|0 |1 is obsolete| | Attachment #28550|0 |1 is obsolete| | Attachment #28551|0 |1 is obsolete| | Attachment #28553|0 |1 is obsolete| | Attachment #28556|0 |1 is obsolete| | Attachment #28564|0 |1 is obsolete| | --- Comment #354 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28795&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #355 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28796&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #356 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28797&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #357 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28798&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #358 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28799&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #359 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28800&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #360 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28801&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #361 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28802&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #362 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28803&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #363 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28804&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #364 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28805&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #365 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28806&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #366 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28807&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #367 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28808&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #368 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28809&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #369 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28810&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #370 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28811&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #371 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28812&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #372 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28813&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #373 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28814&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #374 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28815&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #375 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28816&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #376 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28817&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #377 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28818&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #378 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28819&action=edit Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance The total being treated as the total ammount of fines is actually the total amount of charges that are *not* fines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #379 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28820&action=edit Bug 6427 [Part 26] - Simplify and improve account normalization and balancing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #380 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28821&action=edit Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #381 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28822&action=edit Bug 6427 [Part 28] - Add ability to void payments * Adds ability to void payments * Adds missing setting up updated_on for debits and credits * Adds the display of the offset type if there is one * Adds a column showing the amount paid on a given fine in the payments view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #382 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28887&action=edit Bug 6427 [Part 29] - Force the amount to pay to display as a two decimal float -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #383 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28888&action=edit Bug 6427 [Part 30] - Do not auto-print reciepts for manual invoices -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #384 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28889&action=edit Bug 6427 [Part 31] - Restore the lost item fee description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #385 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28890&action=edit Bug 6427 [Part 32] - Fix koha-qa.pl issues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #386 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28909&action=edit Bug 6427 [Part 33] - Remove unescaped key value pairs Titles and other values with double quotes will break the javascript. We do not need these unescaped values for any reason. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #387 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29176&action=edit Bug 6427 [Part 34] - Issues view should show Yes to fines only for items with associated debits in opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28795|0 |1 is obsolete| | Attachment #28796|0 |1 is obsolete| | Attachment #28797|0 |1 is obsolete| | Attachment #28798|0 |1 is obsolete| | Attachment #28799|0 |1 is obsolete| | Attachment #28800|0 |1 is obsolete| | Attachment #28801|0 |1 is obsolete| | Attachment #28802|0 |1 is obsolete| | Attachment #28803|0 |1 is obsolete| | Attachment #28804|0 |1 is obsolete| | Attachment #28805|0 |1 is obsolete| | Attachment #28806|0 |1 is obsolete| | Attachment #28807|0 |1 is obsolete| | Attachment #28808|0 |1 is obsolete| | Attachment #28809|0 |1 is obsolete| | Attachment #28810|0 |1 is obsolete| | Attachment #28811|0 |1 is obsolete| | Attachment #28812|0 |1 is obsolete| | Attachment #28813|0 |1 is obsolete| | Attachment #28814|0 |1 is obsolete| | Attachment #28815|0 |1 is obsolete| | Attachment #28816|0 |1 is obsolete| | Attachment #28817|0 |1 is obsolete| | Attachment #28818|0 |1 is obsolete| | Attachment #28819|0 |1 is obsolete| | Attachment #28820|0 |1 is obsolete| | Attachment #28821|0 |1 is obsolete| | Attachment #28822|0 |1 is obsolete| | Attachment #28887|0 |1 is obsolete| | Attachment #28888|0 |1 is obsolete| | Attachment #28889|0 |1 is obsolete| | Attachment #28890|0 |1 is obsolete| | Attachment #28909|0 |1 is obsolete| | Attachment #29176|0 |1 is obsolete| | --- Comment #388 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29230&action=edit Bug 6427 [Part 1] - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #389 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29231&action=edit Bug 6427 [Part 2] - Add new accounts related modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #390 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29232&action=edit Bug 6427 [Part 3] - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #391 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29233&action=edit Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #392 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29234&action=edit Bug 6427 [Part 5] - Implement new accounting system in the opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #393 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29235&action=edit Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #394 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29236&action=edit Bug 6427 [Part 7] - Update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #395 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29237&action=edit Bug 6427 [Part 8] - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #396 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29238&action=edit Bug 6427 [Part 9] - Update existing perl modules to support new accounting system -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #397 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29239&action=edit Bug 6427 [Part 10] - Update reports wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #398 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29240&action=edit Bug 6427 [Part 11] - Add new utility functions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #399 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29241&action=edit Bug 6427 [Part 12] - Add and update unit tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #400 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29242&action=edit Bug 6427 [Part 13] - Add database updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #401 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29243&action=edit Bug 6427 [Part 14] - Delete unused and unnecessary files This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #402 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29244&action=edit Bug 6427 [Part 15] - Auto-print payment and manual fee receipts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #403 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29245&action=edit Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #404 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29246&action=edit Bug 6427 [Part 17] - Add cron script to recalculate account balances -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #405 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29247&action=edit Bug 6427 [Part 18] - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #406 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29248&action=edit Bug 6427 [Part 19] - Add full debit and credit table Print and Download features -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #407 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29249&action=edit Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #408 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29250&action=edit Bug 6427 [Part 21] - Fix ILSDI::Services -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #409 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29251&action=edit Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #410 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29252&action=edit Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #411 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29253&action=edit Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #412 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29254&action=edit Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance The total being treated as the total ammount of fines is actually the total amount of charges that are *not* fines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #413 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29255&action=edit Bug 6427 [Part 26] - Simplify and improve account normalization and balancing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #414 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29256&action=edit Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #415 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29257&action=edit Bug 6427 [Part 28] - Add ability to void payments * Adds ability to void payments * Adds missing setting up updated_on for debits and credits * Adds the display of the offset type if there is one * Adds a column showing the amount paid on a given fine in the payments view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #416 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29258&action=edit Bug 6427 [Part 29] - Force the amount to pay to display as a two decimal float -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #417 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29259&action=edit Bug 6427 [Part 30] - Do not auto-print reciepts for manual invoices -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #418 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29260&action=edit Bug 6427 [Part 31] - Restore the lost item fee description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #419 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29261&action=edit Bug 6427 [Part 32] - Fix koha-qa.pl issues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #420 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29262&action=edit Bug 6427 [Part 33] - Remove unescaped key value pairs Titles and other values with double quotes will break the javascript. We do not need these unescaped values for any reason. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #421 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29263&action=edit Bug 6427 [Part 34] - Issues view should show Yes to fines only for items with associated debits in opac -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #422 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29264&action=edit Bug 6427 [Part 35] - Update ProcessOfflinePayment -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #423 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29265&action=edit Bug 6427 [Part 35] - Add type to note for SIP2 payments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #424 from Owen Leonard <oleonard@myacpl.org> --- Is there a reason why there are so many separate patches? Is there one all-encompassing test plan for all? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #425 from Jesse Maseto <jesse@bywatersolutions.com> --- Kyle, I think these patches need to be rebased. -Jesse -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29230|0 |1 is obsolete| | Attachment #29231|0 |1 is obsolete| | Attachment #29232|0 |1 is obsolete| | Attachment #29233|0 |1 is obsolete| | Attachment #29234|0 |1 is obsolete| | Attachment #29235|0 |1 is obsolete| | Attachment #29236|0 |1 is obsolete| | Attachment #29237|0 |1 is obsolete| | Attachment #29238|0 |1 is obsolete| | Attachment #29239|0 |1 is obsolete| | Attachment #29240|0 |1 is obsolete| | Attachment #29241|0 |1 is obsolete| | Attachment #29242|0 |1 is obsolete| | Attachment #29243|0 |1 is obsolete| | Attachment #29244|0 |1 is obsolete| | Attachment #29245|0 |1 is obsolete| | Attachment #29246|0 |1 is obsolete| | Attachment #29247|0 |1 is obsolete| | Attachment #29248|0 |1 is obsolete| | Attachment #29249|0 |1 is obsolete| | Attachment #29250|0 |1 is obsolete| | Attachment #29251|0 |1 is obsolete| | Attachment #29252|0 |1 is obsolete| | Attachment #29253|0 |1 is obsolete| | Attachment #29254|0 |1 is obsolete| | Attachment #29255|0 |1 is obsolete| | Attachment #29256|0 |1 is obsolete| | Attachment #29257|0 |1 is obsolete| | Attachment #29258|0 |1 is obsolete| | Attachment #29259|0 |1 is obsolete| | Attachment #29260|0 |1 is obsolete| | Attachment #29261|0 |1 is obsolete| | Attachment #29262|0 |1 is obsolete| | Attachment #29263|0 |1 is obsolete| | Attachment #29264|0 |1 is obsolete| | Attachment #29265|0 |1 is obsolete| | --- Comment #426 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29706&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #427 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29707&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #428 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29708&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #429 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29709&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #430 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29710&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #431 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29711&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #432 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29712&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #433 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29713&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #434 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29714&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #435 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29715&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #436 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29716&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #437 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29717&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29706|0 |1 is obsolete| | Attachment #29707|0 |1 is obsolete| | Attachment #29708|0 |1 is obsolete| | Attachment #29709|0 |1 is obsolete| | Attachment #29710|0 |1 is obsolete| | Attachment #29711|0 |1 is obsolete| | Attachment #29712|0 |1 is obsolete| | Attachment #29713|0 |1 is obsolete| | Attachment #29714|0 |1 is obsolete| | Attachment #29715|0 |1 is obsolete| | Attachment #29716|0 |1 is obsolete| | Attachment #29717|0 |1 is obsolete| | --- Comment #438 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29719&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #439 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29720&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #440 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29721&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #441 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29722&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #442 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29723&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #443 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29724&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #444 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29725&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #445 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29726&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #446 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29727&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26033|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #447 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29728&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #448 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29729&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26035|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #449 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29730&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26036|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29719|0 |1 is obsolete| | Attachment #29720|0 |1 is obsolete| | Attachment #29721|0 |1 is obsolete| | Attachment #29722|0 |1 is obsolete| | Attachment #29723|0 |1 is obsolete| | Attachment #29724|0 |1 is obsolete| | Attachment #29725|0 |1 is obsolete| | Attachment #29726|0 |1 is obsolete| | Attachment #29727|0 |1 is obsolete| | Attachment #29728|0 |1 is obsolete| | Attachment #29729|0 |1 is obsolete| | Attachment #29730|0 |1 is obsolete| | --- Comment #450 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30271&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #451 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30272&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #452 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30273&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #453 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30274&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #454 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30275&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #455 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30276&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #456 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30277&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #457 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30278&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #458 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30279&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #459 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30280&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #460 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30281&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #461 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30282&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30271|0 |1 is obsolete| | --- Comment #462 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30320&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30272|0 |1 is obsolete| | --- Comment #463 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30321&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30273|0 |1 is obsolete| | --- Comment #464 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30322&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30274|0 |1 is obsolete| | --- Comment #465 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30323&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30275|0 |1 is obsolete| | --- Comment #466 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30324&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30276|0 |1 is obsolete| | --- Comment #467 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30325&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30277|0 |1 is obsolete| | --- Comment #468 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30326&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30278|0 |1 is obsolete| | --- Comment #469 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30327&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30279|0 |1 is obsolete| | --- Comment #470 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30328&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30280|0 |1 is obsolete| | --- Comment #471 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30329&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30281|0 |1 is obsolete| | --- Comment #472 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30330&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30282|0 |1 is obsolete| | --- Comment #473 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30331&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30320|0 |1 is obsolete| | Attachment #30321|0 |1 is obsolete| | Attachment #30322|0 |1 is obsolete| | Attachment #30323|0 |1 is obsolete| | Attachment #30324|0 |1 is obsolete| | Attachment #30325|0 |1 is obsolete| | Attachment #30326|0 |1 is obsolete| | Attachment #30327|0 |1 is obsolete| | Attachment #30328|0 |1 is obsolete| | Attachment #30329|0 |1 is obsolete| | Attachment #30330|0 |1 is obsolete| | Attachment #30331|0 |1 is obsolete| | --- Comment #474 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30416&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #475 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30417&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #476 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30418&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #477 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30419&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #478 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30420&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #479 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30421&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #480 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30422&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #481 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30423&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #482 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30424&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #483 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30425&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #484 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30426&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #485 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30427&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30416|0 |1 is obsolete| | Attachment #30417|0 |1 is obsolete| | Attachment #30418|0 |1 is obsolete| | Attachment #30419|0 |1 is obsolete| | Attachment #30420|0 |1 is obsolete| | Attachment #30421|0 |1 is obsolete| | Attachment #30422|0 |1 is obsolete| | Attachment #30423|0 |1 is obsolete| | Attachment #30424|0 |1 is obsolete| | Attachment #30425|0 |1 is obsolete| | Attachment #30426|0 |1 is obsolete| | Attachment #30427|0 |1 is obsolete| | --- Comment #486 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31477&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #487 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31478&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #488 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31479&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #489 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31480&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #490 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31481&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #491 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31482&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #492 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31483&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #493 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31484&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #494 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31485&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #495 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31486&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #496 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31487&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #497 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31488&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31477|0 |1 is obsolete| | Attachment #31478|0 |1 is obsolete| | Attachment #31479|0 |1 is obsolete| | Attachment #31480|0 |1 is obsolete| | Attachment #31481|0 |1 is obsolete| | Attachment #31482|0 |1 is obsolete| | Attachment #31483|0 |1 is obsolete| | Attachment #31484|0 |1 is obsolete| | Attachment #31485|0 |1 is obsolete| | Attachment #31486|0 |1 is obsolete| | Attachment #31487|0 |1 is obsolete| | Attachment #31488|0 |1 is obsolete| | --- Comment #498 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31754&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #499 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31755&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #500 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31756&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #501 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31757&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #502 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31758&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #503 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31759&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #504 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31760&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #505 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31761&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #506 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31762&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #507 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31763&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #508 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31764&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #509 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31765&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31754|0 |1 is obsolete| | Attachment #31755|0 |1 is obsolete| | Attachment #31756|0 |1 is obsolete| | Attachment #31757|0 |1 is obsolete| | Attachment #31758|0 |1 is obsolete| | Attachment #31759|0 |1 is obsolete| | Attachment #31760|0 |1 is obsolete| | Attachment #31761|0 |1 is obsolete| | Attachment #31762|0 |1 is obsolete| | Attachment #31763|0 |1 is obsolete| | Attachment #31764|0 |1 is obsolete| | Attachment #31765|0 |1 is obsolete| | --- Comment #510 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31766&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #511 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31767&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #512 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31768&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #513 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31769&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #514 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31770&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #515 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31771&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #516 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31772&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #517 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31773&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #518 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31774&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #519 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31775&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #520 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31776&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #521 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31777&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #522 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Good work on this one Kyle! I hope we get this to master some day! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31766|0 |1 is obsolete| | Attachment #31767|0 |1 is obsolete| | Attachment #31768|0 |1 is obsolete| | Attachment #31769|0 |1 is obsolete| | Attachment #31770|0 |1 is obsolete| | Attachment #31771|0 |1 is obsolete| | Attachment #31772|0 |1 is obsolete| | Attachment #31773|0 |1 is obsolete| | Attachment #31774|0 |1 is obsolete| | Attachment #31775|0 |1 is obsolete| | Attachment #31776|0 |1 is obsolete| | Attachment #31777|0 |1 is obsolete| | --- Comment #523 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32478&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #524 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32479&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #525 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32480&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #526 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32481&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #527 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32482&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #528 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32483&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #529 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32484&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #530 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32485&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #531 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32486&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #532 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32487&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #533 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32488&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #534 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32489&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13104 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32478|0 |1 is obsolete| | Attachment #32479|0 |1 is obsolete| | Attachment #32480|0 |1 is obsolete| | Attachment #32481|0 |1 is obsolete| | Attachment #32482|0 |1 is obsolete| | Attachment #32483|0 |1 is obsolete| | Attachment #32484|0 |1 is obsolete| | Attachment #32485|0 |1 is obsolete| | Attachment #32486|0 |1 is obsolete| | Attachment #32487|0 |1 is obsolete| | Attachment #32488|0 |1 is obsolete| | Attachment #32489|0 |1 is obsolete| | --- Comment #535 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32591&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #536 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32592&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #537 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32593&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #538 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32594&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #539 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32595&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #540 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32596&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #541 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32597&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #542 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32598&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #543 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32599&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #544 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32600&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #545 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32601&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #546 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32602&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32591|0 |1 is obsolete| | Attachment #32592|0 |1 is obsolete| | Attachment #32593|0 |1 is obsolete| | Attachment #32594|0 |1 is obsolete| | Attachment #32595|0 |1 is obsolete| | Attachment #32596|0 |1 is obsolete| | Attachment #32597|0 |1 is obsolete| | Attachment #32598|0 |1 is obsolete| | Attachment #32599|0 |1 is obsolete| | Attachment #32600|0 |1 is obsolete| | Attachment #32601|0 |1 is obsolete| | Attachment #32602|0 |1 is obsolete| | --- Comment #547 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32827&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #548 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32828&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #549 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32829&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #550 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32830&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #551 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32831&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #552 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32832&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #553 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32833&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #554 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32834&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #555 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32835&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #556 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32836&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #557 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32837&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #558 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32838&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32827|0 |1 is obsolete| | Attachment #32828|0 |1 is obsolete| | Attachment #32829|0 |1 is obsolete| | Attachment #32830|0 |1 is obsolete| | Attachment #32831|0 |1 is obsolete| | Attachment #32832|0 |1 is obsolete| | Attachment #32833|0 |1 is obsolete| | Attachment #32834|0 |1 is obsolete| | Attachment #32835|0 |1 is obsolete| | Attachment #32836|0 |1 is obsolete| | Attachment #32837|0 |1 is obsolete| | Attachment #32838|0 |1 is obsolete| | --- Comment #559 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33251&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #560 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33252&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #561 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33253&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #562 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33254&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #563 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33255&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #564 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33256&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #565 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33257&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #566 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33258&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #567 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33259&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #568 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33260&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #569 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33261&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #570 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33262&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33251|0 |1 is obsolete| | Attachment #33252|0 |1 is obsolete| | Attachment #33253|0 |1 is obsolete| | Attachment #33254|0 |1 is obsolete| | Attachment #33255|0 |1 is obsolete| | Attachment #33256|0 |1 is obsolete| | Attachment #33257|0 |1 is obsolete| | Attachment #33258|0 |1 is obsolete| | Attachment #33259|0 |1 is obsolete| | Attachment #33260|0 |1 is obsolete| | Attachment #33261|0 |1 is obsolete| | Attachment #33262|0 |1 is obsolete| | --- Comment #571 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34096&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #572 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34097&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #573 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34098&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #574 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34099&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #575 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34100&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #576 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34101&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #577 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34102&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #578 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34103&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #579 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34104&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #580 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34105&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #581 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34106&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #582 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34107&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #583 from Jonathan Druart <jonathan.druart@biblibre.com> --- Super quick look: 1/ TableTool: Could you explain what is the goal of this plugin (I just have seen a (+) with a 'print receipt' button)? All the files included are needed (html?) 2/ It seems that some tests are missing (AddIssue and AddReturn for instance) 3/ Is this patch set introduced changes compared to master or it's just a rewrite? 4/ What's the interest of splitting pl in 2 files (*_go.pl)? I am really not sure it's useful. (The updatedatabase.pl changes are not at the right place (not at the end)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34096|0 |1 is obsolete| | Attachment #34097|0 |1 is obsolete| | Attachment #34098|0 |1 is obsolete| | Attachment #34099|0 |1 is obsolete| | Attachment #34100|0 |1 is obsolete| | Attachment #34101|0 |1 is obsolete| | Attachment #34102|0 |1 is obsolete| | Attachment #34104|0 |1 is obsolete| | Attachment #34105|0 |1 is obsolete| | Attachment #34106|0 |1 is obsolete| | Attachment #34107|0 |1 is obsolete| | --- Comment #584 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34204&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways bsoletes: 34103 - Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #585 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34205&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #586 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34206&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #587 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34207&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #588 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34208&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #589 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34209&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #590 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34210&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34103|0 |1 is obsolete| | --- Comment #591 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34211&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #592 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34212&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #593 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34213&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #594 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34214&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #595 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34215&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #596 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this re-write meant to deprecate the 'accountlines' table? If so, there are still a few references to it that I can see... and the table is still present after the updatedb run: 1) C4/Reports/Guided.pm 2) C4/Overdues.pm 3) offline_circ/download.pl And a few tests ;) 1) /db_dependent/Circulation_Branch.t 2) /db_dependent/Members.t 3) /db_dependent/Circulation_issue.t -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #597 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 34204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34204 Bug 6427 - Update database Review of attachment 34204: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6427&attachment=34204) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +9709,5 @@
+ 'W' => Koha::Accounts::CreditTypes::WriteOff, + 'C' => Koha::Accounts::CreditTypes::Credit, + 'CR' => Koha::Accounts::CreditTypes::Credit, + }; +
Should there be any additional handling for existing authorised values for types here... ? @@ +9767,5 @@
+ } + ); + } + } +
Should there also be a 'DROP TABLE accountlines' somewhere in here...? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #598 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The installer wizard currently gives the below error with these patches: ERROR 1064 (42000) at line 3466: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #599 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Testing feedback spreadsheet available at: https://docs.google.com/a/ptfs-europe.com/spreadsheets/d/1EcBAPmPAF0L95uYxWt... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|0 |1 is obsolete| | Attachment #34205|0 |1 is obsolete| | Attachment #34206|0 |1 is obsolete| | Attachment #34207|0 |1 is obsolete| | Attachment #34208|0 |1 is obsolete| | Attachment #34209|0 |1 is obsolete| | Attachment #34210|0 |1 is obsolete| | Attachment #34211|0 |1 is obsolete| | Attachment #34212|0 |1 is obsolete| | Attachment #34213|0 |1 is obsolete| | Attachment #34214|0 |1 is obsolete| | Attachment #34215|0 |1 is obsolete| | --- Comment #600 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35196&action=edit [SIGNED-OFF] Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #601 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35197&action=edit [SIGNED-OFF] Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #602 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35198&action=edit [SIGNED-OFF] Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #603 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35199&action=edit [SIGNED-OFF] Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #604 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35200&action=edit [SIGNED-OFF] Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #605 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35201&action=edit [SIGNED-OFF] Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #606 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35202&action=edit [SIGNED-OFF] Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #607 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35203&action=edit [SIGNED-OFF] Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #608 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35204&action=edit [SIGNED-OFF] Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #609 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35205&action=edit [SIGNED-OFF] Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #610 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35206&action=edit [SIGNED-OFF] Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #611 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35207&action=edit [SIGNED-OFF] Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #612 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35208&action=edit [SIGNED-OFF] Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #613 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35302&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #614 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd really like to see some testing notes about this feature with the sign-off. This is huge and no library uses all features. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #615 from Jonathan Druart <jonathan.druart@biblibre.com> --- Applying: Bug 6427 - Update existing Koha perl modules CONFLICT (content): Merge conflict in C4/SIP/ILS/Transaction/FeePayment.pm CONFLICT (content): Merge conflict in C4/Reserves.pm -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #616 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't see how this got to a signed off state, a large part of the testing spreadsheet recording test results shows half of it is untested. I know when I tested it, I found all sorts of issues with display on the staff client. I also found issues with the code when delving into it to try and fix said bugs, I'd love to see a good comprehensive re-write of accounts, but this code shows that it was written some time ago and I don't believe it actually improved matters. PTFS Europe spent a fair chunk of time attempting to get this in shape for passing through community so we could base our Cash Management work upon it, but we didn't even complete testing before we realised how difficult it would be to extend/enhance it further. I also found that too much changed in this one bug.. The db backend and th display both change dramatically, which means doing a side by side comparison to check that the db update it actually catching everything is near impossible. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #617 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing. Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team. I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #618 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing. Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team. I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #619 from Kyle M Hall <kyle@bywatersolutions.com> --- I must disagree. This work closely resembles the original RFC some table and column name changes, as well as a few additions. I've spend countless hours to track this feature against master. Nothing has moved on. It has simply been a lack of persons willing to test and qa this feature that has been the problem so far. (In reply to Martin Renvoize from comment #618)
Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing.
Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team.
I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #620 from Nicole C. Engard <nengard@gmail.com> --- I'd like to add that 2 libraries are using it in production and have given their sign off to the features. They are not having issues with anything - and since we're talking money related issues you'd expect a lot of screaming if there were issues. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Sean McGarvey <smcgarvey@pascocountyfl.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smcgarvey@pascocountyfl.net --- Comment #621 from Sean McGarvey <smcgarvey@pascocountyfl.net> --- I think i can help out here, Pasco County Library system has been using this patch in production for almost an entire year. We've tested pretty much every way this upgrade works and have made a lot of improvements. We've even found new and interesting ways to break things that no one but a patron could have thought of. Just to confirm I even stepped out to talk to my head of finance who agreed that the system is solid and is functioning as described. We've had 7 libraries using it 5 days a week. At this point human error is what is causing the vast majority of our problems. When this is live in master we hope that other libraries can help us make more tweaks. I can confirm that the system is tested and functioning. Had it not been our county clerk would have made it perfectly clear. If there are individual questions about aspects ill try and answer them as best i can regarding actual function in the library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35196|0 |1 is obsolete| | Attachment #35197|0 |1 is obsolete| | Attachment #35198|0 |1 is obsolete| | Attachment #35199|0 |1 is obsolete| | Attachment #35200|0 |1 is obsolete| | Attachment #35201|0 |1 is obsolete| | Attachment #35202|0 |1 is obsolete| | Attachment #35203|0 |1 is obsolete| | Attachment #35204|0 |1 is obsolete| | Attachment #35205|0 |1 is obsolete| | Attachment #35206|0 |1 is obsolete| | Attachment #35207|0 |1 is obsolete| | Attachment #35208|0 |1 is obsolete| | Attachment #35302|0 |1 is obsolete| | --- Comment #622 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36324&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #623 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36326&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #624 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36327&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #625 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36328&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #626 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36329&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #627 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36330&action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #628 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36331&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #629 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36332&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #630 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36333&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #631 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36334&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #632 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36335&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #633 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36337&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #634 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36338&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #635 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36340&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #636 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Kyle M Hall from comment #619)
I must disagree. This work closely resembles the original RFC some table and column name changes, as well as a few additions.
I've spend countless hours to track this feature against master. Nothing has moved on. It has simply been a lack of persons willing to test and qa this feature that has been the problem so far.
Hmmm, Martin and others have spent hours trying to QA this. They found problems, they reported them in the spreadsheet. Have you read through the spreadsheet? Or the comment proceeding the one you replied to? I find it quite insulting you just dismiss their findings, and blame them instead. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Sherry Sakovich <ssakovich@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssakovich@hmcpl.org --- Comment #637 from Sherry Sakovich <ssakovich@hmcpl.org> --- Here at Huntsville-Madison County Public Library, we've been using the accounts re-write in production since we went live on Koha a year ago. We absolutely love the granularity this feature allows for payment types and reporting. As a public library, our city/county auditors strictly require this type of detailed information. Also, as a 12 branch county-wide library system, we're able to make better decisions as we now have better accounting. Finally, our patrons really appreciate that our system tracks what they've paid for and by what method. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Aaron Sakovich <asakovich@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asakovich@hmcpl.org --- Comment #638 from Aaron Sakovich <asakovich@hmcpl.org> --- As Sherry said, we at HMCPL have been using this code in production for a whole year. We have tested this exhaustively, on both 3.14 and 3.16, during that period. And by "we", I mean a 12 branch library system open 7 days a week, with well over 2 million items circulated in that time, exclusively using this code. The current code base is functioning nominally, and even relatively gracefully handled the upgrade from 3.14 to 3.16, as well as multiple patches since. We've no outstanding bugs logged against this current version of the code on our internal nor ByWater's ticketing systems. This current piece of kit is rock solid and well tested; it is well beyond the beta stage that we started with a year ago, and I humbly suggest that it is suitably ready for production. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #639 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Chris Cormack from comment #636)
(In reply to Kyle M Hall from comment #619)
I must disagree. This work closely resembles the original RFC some table and column name changes, as well as a few additions.
I've spend countless hours to track this feature against master. Nothing has moved on. It has simply been a lack of persons willing to test and qa this feature that has been the problem so far.
Hmmm, Martin and others have spent hours trying to QA this. They found problems, they reported them in the spreadsheet. Have you read through the spreadsheet? Or the comment proceeding the one you replied to?
I find it quite insulting you just dismiss their findings, and blame them instead.
Hi All - Please let's not read any tone into any message. We are all friends here and we speak many different languages - I am at fault for using the wrong word with Katrin (someone that I would go to battle for and have the most respect for). So that being said. I think Kyle needs to know how to work with this "BIG IDEA" of the accounts rewrite and work with everyone - from the most experienced (Tomas and Jonathan) to the most experienced me (Brendan). It may take 10 times of telling us to change certain things - but we are more than will to work with anyone of you all - to make those changes. Tempers fly - and I say that is lost in translation. ok - how to change this. Well we are going to sit down with Katrin, Tomas, Jonathan, and hopefully Martin (on google hangouts), and talk about what needs to be changed and how to submit the patches so that it works for everyone. Please remember that all of us - LOVE LOVE LOVE to be part of this community - and all we ever want is to be part of this community. many things are lost in translation - if you need proof - just ask Paul about baseball. Seriously - all we want is to show that we've got so good code and we totally realize that we need tons of help to get it in. Tons of Respect, Brendan Gallagher -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #640 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Brendan Gallagher from comment #639)
(In reply to Chris Cormack from comment #636)
(In reply to Kyle M Hall from comment #619)
I must disagree. This work closely resembles the original RFC some table and column name changes, as well as a few additions.
I've spend countless hours to track this feature against master. Nothing has moved on. It has simply been a lack of persons willing to test and qa this feature that has been the problem so far.
Hmmm, Martin and others have spent hours trying to QA this. They found problems, they reported them in the spreadsheet. Have you read through the spreadsheet? Or the comment proceeding the one you replied to?
I find it quite insulting you just dismiss their findings, and blame them instead.
Hi All -
Please let's not read any tone into any message. We are all friends here and we speak many different languages - I am at fault for using the wrong word with Katrin (someone that I would go to battle for and have the most respect for). That should be the most INexperienced me (bag) darn typos
So that being said. I think Kyle needs to know how to work with this "BIG IDEA" of the accounts rewrite and work with everyone - from the most experienced (Tomas and Jonathan) to the most experienced me (Brendan).
It may take 10 times of telling us to change certain things - but we are more than will to work with anyone of you all - to make those changes. Tempers fly - and I say that is lost in translation.
ok - how to change this. Well we are going to sit down with Katrin, Tomas, Jonathan, and hopefully Martin (on google hangouts), and talk about what needs to be changed and how to submit the patches so that it works for everyone.
Please remember that all of us - LOVE LOVE LOVE to be part of this community - and all we ever want is to be part of this community. many things are lost in translation - if you need proof - just ask Paul about baseball.
Seriously - all we want is to show that we've got so good code and we totally realize that we need tons of help to get it in.
Tons of Respect, Brendan Gallagher
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #641 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #616)
I don't see how this got to a signed off state, a large part of the testing spreadsheet recording test results shows half of it is untested.
The signer was an independent tester.
I know when I tested it, I found all sorts of issues with display on the staff client.
Please let me know what those issue are!
I also found issues with the code when delving into it to try and fix said bugs, I'd love to see a good comprehensive re-write of accounts, but this code shows that it was written some time ago and I don't believe it actually improved matters.
Again, pleases let me know what these bugs are! I believe that this feature improves matters very much. The partners that have been testing this have been able to do far more advanced reporting on fees and payments than is possible with our current schema. I don't see how it *doesn't* improve matters!
PTFS Europe spent a fair chunk of time attempting to get this in shape for passing through community so we could base our Cash Management work upon it, but we didn't even complete testing before we realised how difficult it would be to extend/enhance it further.
I can understand that you want to add a new feature to Koha, and this feature is making it more difficult for you. I've been in the same situation. However, I don't think that's reasonable justification for tossing it out. If you can outline what parts of this are limiting for you, and how I can help resolve this, I would be more than happy to! Have you posted an RFC for your Cash Management feature? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #642 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36380&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #643 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36391&action=edit Bug 6427 [QA Followup] - Further improvments to updatadatabase -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #644 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36393&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10021 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36391|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2546, 8798 |13790 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36324|0 |1 is obsolete| | Attachment #36326|0 |1 is obsolete| | Attachment #36327|0 |1 is obsolete| | Attachment #36328|0 |1 is obsolete| | Attachment #36329|0 |1 is obsolete| | Attachment #36330|0 |1 is obsolete| | Attachment #36331|0 |1 is obsolete| | Attachment #36332|0 |1 is obsolete| | Attachment #36333|0 |1 is obsolete| | Attachment #36334|0 |1 is obsolete| | Attachment #36335|0 |1 is obsolete| | Attachment #36337|0 |1 is obsolete| | Attachment #36338|0 |1 is obsolete| | Attachment #36340|0 |1 is obsolete| | Attachment #36380|0 |1 is obsolete| | Attachment #36393|0 |1 is obsolete| | --- Comment #645 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37127&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #646 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37128&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #647 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37129&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #648 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37130&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #649 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37131&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #650 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37133&action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #651 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37134&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #652 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37135&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #653 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37136&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #654 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37137&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #655 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37138&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #656 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37139&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #657 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37140&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #658 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37141&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #659 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37142&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #660 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37143&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37127|0 |1 is obsolete| | Attachment #37128|0 |1 is obsolete| | Attachment #37129|0 |1 is obsolete| | Attachment #37130|0 |1 is obsolete| | Attachment #37131|0 |1 is obsolete| | Attachment #37133|0 |1 is obsolete| | Attachment #37134|0 |1 is obsolete| | Attachment #37135|0 |1 is obsolete| | Attachment #37136|0 |1 is obsolete| | Attachment #37137|0 |1 is obsolete| | Attachment #37138|0 |1 is obsolete| | Attachment #37139|0 |1 is obsolete| | Attachment #37140|0 |1 is obsolete| | Attachment #37141|0 |1 is obsolete| | Attachment #37142|0 |1 is obsolete| | Attachment #37143|0 |1 is obsolete| | --- Comment #661 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37147&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #662 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37148&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #663 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37149&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #664 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37150&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #665 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37151&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #666 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37152&action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #667 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37153&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #668 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37154&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #669 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37155&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #670 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37156&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #671 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37157&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #672 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37158&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #673 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37159&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #674 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37160&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #675 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37161&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #676 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37162&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37147|0 |1 is obsolete| | Attachment #37148|0 |1 is obsolete| | Attachment #37149|0 |1 is obsolete| | Attachment #37150|0 |1 is obsolete| | Attachment #37151|0 |1 is obsolete| | Attachment #37152|0 |1 is obsolete| | Attachment #37153|0 |1 is obsolete| | Attachment #37154|0 |1 is obsolete| | Attachment #37155|0 |1 is obsolete| | Attachment #37156|0 |1 is obsolete| | Attachment #37157|0 |1 is obsolete| | Attachment #37158|0 |1 is obsolete| | Attachment #37159|0 |1 is obsolete| | Attachment #37160|0 |1 is obsolete| | Attachment #37161|0 |1 is obsolete| | Attachment #37162|0 |1 is obsolete| | --- Comment #677 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37229&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #678 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37230&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #679 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37231&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #680 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37232&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #681 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37233&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #682 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37234&action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #683 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37235&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #684 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37236&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #685 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37237&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #686 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37238&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #687 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37239&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #688 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37240&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #689 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37241&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #690 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37242&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #691 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37243&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #692 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37244&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #693 from Josef Moravec <josef.moravec@gmail.com> --- I tried this by creating new instance, but web installer presented an SQL error when creating db structure: ERROR 1064 (42000) at line 3484: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1 I think the problem is on this line in kohastructure.sql: 3484 CREATE TABLE IF account_credits ( -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #694 from Josef Moravec <josef.moravec@gmail.com> --- I think that account_credits table should have foreign key to account_debits.debit_id, without this key, it´s impossible to group payments by fee type in reports. But this work is almost done, so it may be the best approach to open new bug for this enhancement... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #695 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #694)
I think that account_credits table should have foreign key to account_debits.debit_id, without this key, it´s impossible to group payments by fee type in reports.
But this work is almost done, so it may be the best approach to open new bug for this enhancement...
I am sorry, I just missed the table account_offsets... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jeremy Wellner <jwellner@stanwood.wednet.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwellner@stanwood.wednet.ed | |u --- Comment #696 from Jeremy Wellner <jwellner@stanwood.wednet.edu> --- With Stanwood-Camano School District our textbook libraries really need this functionality to the point that we will offer to have this move onto our production server for more testing. Fines are a big deal for us as it prevents 12th graders from being allowed to graduate. What can we do to help this along further? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #697 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There have been some commnts that need to be addressed - I am switching to failed QA for the moment. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37234|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14027 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37229|0 |1 is obsolete| | Attachment #37230|0 |1 is obsolete| | Attachment #37231|0 |1 is obsolete| | Attachment #37232|0 |1 is obsolete| | Attachment #37233|0 |1 is obsolete| | Attachment #37235|0 |1 is obsolete| | Attachment #37236|0 |1 is obsolete| | Attachment #37237|0 |1 is obsolete| | Attachment #37238|0 |1 is obsolete| | Attachment #37239|0 |1 is obsolete| | Attachment #37240|0 |1 is obsolete| | Attachment #37241|0 |1 is obsolete| | Attachment #37242|0 |1 is obsolete| | Attachment #37243|0 |1 is obsolete| | Attachment #37244|0 |1 is obsolete| | --- Comment #698 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38247&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #699 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38248&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #700 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38249&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #701 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38250&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #702 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38251&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #703 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38252&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #704 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38253&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #705 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38254&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #706 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38255&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #707 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38256&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #708 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38257&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #709 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38258&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #710 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38259&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #711 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38260&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #712 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38261&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #713 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38262&action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12159 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38247|0 |1 is obsolete| | Attachment #38248|0 |1 is obsolete| | Attachment #38249|0 |1 is obsolete| | Attachment #38250|0 |1 is obsolete| | Attachment #38251|0 |1 is obsolete| | Attachment #38252|0 |1 is obsolete| | Attachment #38253|0 |1 is obsolete| | Attachment #38254|0 |1 is obsolete| | Attachment #38255|0 |1 is obsolete| | Attachment #38256|0 |1 is obsolete| | Attachment #38257|0 |1 is obsolete| | Attachment #38258|0 |1 is obsolete| | Attachment #38259|0 |1 is obsolete| | Attachment #38260|0 |1 is obsolete| | Attachment #38261|0 |1 is obsolete| | Attachment #38262|0 |1 is obsolete| | --- Comment #714 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39063&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #715 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39064&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #716 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39065&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #717 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39066&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #718 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39067&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #719 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39069&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #720 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39070&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #721 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39071&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #722 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39072&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #723 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39073&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #724 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39074&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #725 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39075&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #726 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39076&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #727 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39077&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #728 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39078&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #729 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39079&action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39063|0 |1 is obsolete| | Attachment #39064|0 |1 is obsolete| | Attachment #39065|0 |1 is obsolete| | Attachment #39066|0 |1 is obsolete| | Attachment #39067|0 |1 is obsolete| | Attachment #39069|0 |1 is obsolete| | Attachment #39070|0 |1 is obsolete| | Attachment #39071|0 |1 is obsolete| | Attachment #39072|0 |1 is obsolete| | Attachment #39073|0 |1 is obsolete| | Attachment #39074|0 |1 is obsolete| | Attachment #39075|0 |1 is obsolete| | Attachment #39076|0 |1 is obsolete| | Attachment #39077|0 |1 is obsolete| | Attachment #39078|0 |1 is obsolete| | Attachment #39079|0 |1 is obsolete| | --- Comment #730 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39671&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #731 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39672&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #732 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39673&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #733 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39674&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #734 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39675&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #735 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39676&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #736 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39677&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #737 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39678&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #738 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39679&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #739 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39680&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #740 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39681&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #741 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39682&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #742 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39683&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #743 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39684&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #744 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39685&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #745 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39686&action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14373 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11622 | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13098 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2696 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine Payments Should Show What Was Paid For -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14825 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #746 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, not sure about the dependency on 13790 - maybe this should be blocked by it and not the other way around (might have made a mistake there)? Also I saw you split of some patches for a more granular approach - what shall we do here? Patch currently doesn't apply - so choosing that for now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #747 from Kyle M Hall <kyle.m.hall@gmail.com> --- *** This bug has been marked as a duplicate of bug 14825 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org