http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Kyle, I would like to start a development using DBIx and I am taking a look at this development. I think we should have some guided guidelines on about how to organize our classes. Looking at your code, I have some questions to ask: 1/ Don't you think we should avoid calls to Koha::Database in pl files ? 2/ Don't you think new module in the Koha namespace should be OOP (for ex. using Class::Accessor)? Outside the DBIx scope, I am wondering why do you have 2 scripts account_payment.pl and members/account_payment_do.pl. I suppose it is in order to remove the $op variable. I think it would be better to head towards a REST architecture. For example, here, we could imagine executing the AddCredit routine on a POST method and using the "show/list" view on a GET method. For discussion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.