http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |jonathan.druart@bugs.koha-c |u |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14123 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression on adding |Add several patrons to a |several patrons to a new |new batch will create a new |batch |batch per patron added -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |nick@quecheelibrary.org |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #4 from Nick Clemens <nick@quecheelibrary.org> --- I tried an easy fix (update batch_id after adding an item), but if a user clicks on several patrons to add without waiting for background page to reload the batch_id doesn't have time to update. Barton said he is taking a look today and I will touch base with him when I get in this afternoon -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #7 from bondiurbano <costalc@gmail.com> --- Also "Select", "Select all", "Select none" checkbox and links are missing. See attached image. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Heinrich.Hartl@email.de --- Comment #10 from Nick Clemens <nick@quecheelibrary.org> --- *** Bug 14800 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 42474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42474&action=edit [Signed-off] Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron searhc, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popupo 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items hsoul;d be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14131 --- Comment #12 from Marc Véron <veron@veron.ch> --- BTW: A couple of months ago, I implemented a possibility to print patron cards from patronlists. Patron lists are easier to create and to handle. See Bug 14131 (Needs sign-off) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #13 from Marc Véron <veron@veron.ch> --- *** Bug 14123 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42474|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42623&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron searhc, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popupo 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items hsoul;d be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42623|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42965&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- I'm sorry but I still have problems.... Try this: 1. Go to patron label creator -> manage batches 2. Remove all batches (just to be sure we have the same environment) 3. Click on "new batch" 4. Click on "add items" and pick 5 patrons 5. Close the patron picker window and click on "add items" again, the batch is created as expected 6. Go back to manage batches 7. Click on "new batch" 8. insert one right borrowernumber and one wrong borrowernumber 9. click on "add items" 10. the one right is added, but the five patrons from previous batch is added too -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try it on another machine with MySQL tomorow... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Hm, on another machine everything works perfect... So probably some problem with my specific data, or something on that one VM. So please, ignore me ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- I tried it on non-empty table, but have the same issue... I am not able to figure out where is the problem.... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #27 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Barton Chittenden from comment #26)

Getting

Software error:

Can't call method "get_attr" without a package or object reference at /home/barton/kohaclone/patroncards/edit-batch.pl line 125.

To re-create:

1/ go to Home › Tools › Patron card creator › Manage card Batches (cgi-bin/koha/patroncards/manage.pl?card_element=batch) 2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new) 3/ click 'Add items' (opens new window -- cgi-bin/koha/patroncards/add_user_search.pl) 4/ click 'Search' to show all patrons (I don't have that many) 5/ click 'Add' on first patron -> Software error.

This was user error on my part. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43034|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 43038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43038&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #31 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Barton Chittenden from comment #30)

Created attachment 43040 [details] [review] [SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a new batch per patron added

This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search

To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not

Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>

I've tested without error, and I'm signing off, but I know that Jonathan wants to see if we can replicate the errors that Josef Moravec was seeing, so I'm not going to set the status of the bug as a whole to 'Signed Off'. This is simply saying 'the patch works for me'. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43050&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43040|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 43052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43052&action=edit [SIGNED-OFF] Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42474|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is something wrong in the first patch 59 my @item_numbers; #= $cgi->param('item_number') if $cgi->param('item_number'); Could someone re-upload a valid patch? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43040|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The second patch does not apply anymore, but maybe it was not based on the good one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43052|0 |1 is obsolete| | --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 43061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43061&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---

From the first patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0;

From the second patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef;

Initially my patch (the second one) didn't modify this line. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43061|0 |1 is obsolete| | --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 43063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43063&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43062|0 |1 is obsolete| | Attachment #43063|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43107&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43109&action=edit Bug 14739: Adapt wording in breadcrumbs if a new batch is created Don't display "Manage batch number 0" but "Create new batch" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #52 from Liz Rea <liz@catalyst.net.nz> --- This change might require documentation updates. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15224 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 [Bug 15224] Typo: Leave empty to add via item search (itemnunber). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |molinga@mubs.ac.ug --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 15393 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.