[Bug 14735] New: cache_expiry is not saved when updating a SQL report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Bug ID: 14735 Summary: cache_expiry is not saved when updating a SQL report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Steps to duplicate (must have memcached enabled): 1. Create and save a report using the default values for "Report is public" and cache time. 2. Run the report. 3. Edit the report changing the setting for "Report is public" to yes. 4. Save the report. The cache time is now 0. 5. Edit the report changing the cache time to 300. 6. Save the report. The cache time is now 0 again. This seems to be due to the fact that cache_expiry is not passed to the update_sql function in the phase 'Update SQL'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|minor |critical --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Data is lost.. upgrading severity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44709&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44709|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44715&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Repeatable bug. Solved with this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44715|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44719&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Repeatable bug. Solved with this patch. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Enjoy your beer Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org