[Bug 17472] New: Borrower Previously Checked Out: Display title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Bug ID: 17472 Summary: Borrower Previously Checked Out: Display title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When the dialog with previous checkout confirmation appers, there should be displayed the title of current document, which the librarian is trying to check out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6906 CC| |josef.moravec@gmail.com, | |mail@jkozlovsky.cz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 56717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56717&action=edit Bug 17472: Add title, barcode to warning message. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add Title and Barcode to PREVISSUE message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |alex.sassmannshausen@ptfs-e | |urope.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Thinking about it, my patch adds title and barcode. It may be preferable to add only the title, given that the same bib may have been issued in the past, but not necessarily the same item. WDYT? Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56717|0 |1 is obsolete| | --- Comment #3 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 56718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56718&action=edit Bug 17472: Add title, not barcode, to warning. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add item title, reword message, for PREVISSUE. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #4 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- I've decided to remove the barcode, as the request itself only mentions title too. Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56717|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56717|0 |1 is obsolete| | Attachment #56718|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56721&action=edit [SIGNED-OFF] Bug 17472: Add title to warning message for PREVCHECKOUT * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add Title to PREVISSUE message. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Thank Alex, I agree, the important thing is the title, not barcode. As your second patch was written on top of the previous one, I squashed them. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is not a good mark-up for translation: + <li>Title <i>[% getTitleMessageIteminfo %]</i> has previously been checked out to this patron. Check out anyway?</li> The use of <i> splits the sentence into multiple parts. Please reformat in a way that will be easier to translate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56721|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57247&action=edit Bug 17472: Borrower Previously Checked Out: Display title Test plan: 0) apply the patch 1) turn on checking previously checkouts - syspref CheckPrevCheckout 2) checkout an item to borrower 3) check the item in and check it out again, you should see the dialog, with information that the current item was previously checked out to this patron. With this patch, the information includes title and author of the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #57247|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am lost with the different patches. Could someone tell me which one is the good one? Authorship has changed between the first submission and the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 --- Comment #11 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Hi Jonathan, This is probably clear by now (I saw you obsoleted a patch). The right patch is Josef's. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57247|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58161&action=edit Bug 17472: Borrower Previously Checked Out: Display title Test plan: 0) apply the patch 1) turn on checking previously checkouts - syspref CheckPrevCheckout 2) checkout an item to borrower 3) check the item in and check it out again, you should see the dialog, with information that the current item was previously checked out to this patron. With this patch, the information includes title and author of the item Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17472 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org