[Bug 15990] New: Moving record matching rules actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Bug ID: 15990 Summary: Moving record matching rules actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48713&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think we should not make dropdowns where there are only two options. I would like to propose that we start using Bootstrap-styled buttons like this when there are only two links: <a class="btn btn-mini" href="[% available_matching_rule.script_name %]?op=edit_matching_rule&matcher_id=[% available_matching_rule.matcher_id |html %]"><i class="fa fa-pencil"></i> Edit</a> <a class="btn btn-mini" href="[% available_matching_rule.script_name %]?op=delete_matching_rule&matcher_id=[% available_matching_rule.matcher_id |html %]"><i class="fa fa-remove"></i> Delete</a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The pull down adds another click - so in cases with not so many options I think the buttons could work nicely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48713|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48821&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48821|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48848&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48848|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48902&action=edit Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moving record matching |Making record matching |rules actions into a |rules actions buttons |drop-down menu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48902|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49057&action=edit [SIGNED-OFF] Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49057|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49124&action=edit Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49125&action=edit Bug 15990: (follow-up) Making record matching rules actions buttons Adds the actions class to the td elt to keep the buttons next to each other. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org