[Bug 15993] New: Moving currency actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Bug ID: 15993 Summary: Moving currency actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991, Bug 15992 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48720&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48720|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48826&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48826|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48850&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15962 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that the deletion does not work, I have fixed that yesterday on bug 15962. The 2 patches do not conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |oleonard@myacpl.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48850|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48903&action=edit Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moving currency actions |Making currency actions |into a drop-down menu |buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48903|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49043&action=edit [SIGNED-OFF] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49044&action=edit Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49043|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49065&action=edit [SIGNED-OFF] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> https://bugs.koha-community.org/show_bug.cgi?id=15593 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49066&action=edit [SIGNED-OFF] Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=15593 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49065|0 |1 is obsolete| | Attachment #49066|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49119&action=edit Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49120&action=edit Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org