https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103055&action=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103055|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103316&action=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103316|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103524&action=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % git grep '<i class="fa' koha-tmpl/opac-tmpl/|grep -v aria-hidden koha-tmpl/opac-tmpl/bootstrap/js/global.js: <a href="#" id="bootstrap-confirm-box-modal-submit" class="btn btn-danger"><i class="fa fa-check"></i></a>\ koha-tmpl/opac-tmpl/bootstrap/js/global.js: <a href="#" id="bootstrap-confirm-box-modal-cancel" data-dismiss="modal" class="btn btn-default"><i class="fa fa-remove"></i></a>\ Are not they valid? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is that regex I should improve to have a single one (no grep -v), so yes it can be added. But I wanted to know if it caught false positives (the 2 output lines) or not. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://gitlab.com/koha-community/qa-test-tools/-/issues/31 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add "aria-hidden = true" to |Add aria-hidden = "true" to |Font Awesome icons in the |Font Awesome icons in the |OPAC |OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.