[Bug 25271] New: Add floating toolbar to OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Bug ID: 25271 Summary: Add floating toolbar to OPAC cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I think it would be useful for the OPAC cart window's toolbar to float. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 [Bug 25274] JavaScript error in OPAC cart when more details are shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103670&action=edit Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- For me, it works except in More details view as you can see here: https://youtu.be/-z0nZ0oLyGs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Frédéric Demians from comment #2)
For me, it works except in More details view as you can see here:
This is the same problem I had without the patch for Bug 25274. Did you test with that patch applied? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103670|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 103777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103777&action=edit Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Owen Leonard from comment #3)
This is the same problem I had without the patch for Bug 25274. Did you test with that patch applied?
That's it. It works with this patch (it wasn't yet pushed on master this morning when I tested...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA script complains a bit, but this will be fixed by bug 25166 - so I suggest we forego a follow-up here. FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt OK filters FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 23) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 25) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 28) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 30) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 31) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 32) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 34) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 44) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 47) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 50) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 53) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103777|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103881&action=edit Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Owen.. not sure which bug I just pushed that breaks this, but the rebase looks like your expert eyes would do better than mine in this case.. pretty please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103881|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103970&action=edit Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org