[Bug 6934] New: New report Cash Register Statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bug #: 6934 Summary: New report Cash Register Statistics Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Reports AssignedTo: gmcharlt@gmail.com ReportedBy: pelletiermaxime@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5634 new report Report that ouputs cash register stats by selecting everything paid in accountlines for a specific period. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-28 21:43:46 UTC --- Created attachment 5635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5635 screenshot of the report -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-29 13:42:09 UTC --- I have to say that this is sponsored by our client, http://www.ccsr.qc.ca/. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5634|0 |1 is patch| | Attachment #5634|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 14:04:58 UTC --- Created attachment 5640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5640 few problems This is awesome. There are a few issues though. See my attachment. The date isn't showing for me and the date tooltip says MM/DD/YY but the dates when I choose them from the calendar come out YYYY-MM-DD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com Patch Status|--- |Failed QA AssignedTo|gmcharlt@gmail.com |pelletiermaxime@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 14:06:39 UTC --- Also, this isn't necessary to get the patch pushed, but it would be awesome to also show the librarian/branch who collected the money (maybe a future enhancement to this feature). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5634|0 |1 is obsolete| | --- Comment #5 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-29 14:59:01 UTC --- Created attachment 5641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5641 New patch with date format fixes and better indentation -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5641|0 |1 is obsolete| | --- Comment #6 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-10-06 17:22:40 UTC --- Comment on attachment 5641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5641 New patch with date format fixes and better indentation I'm afraid that this was not meant to be sent yet. I will update this bug once we can really share it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5641|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Looks like I forgot to update the bug. I hope it stills applies to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is this code unencumbered, license-wise, and suitable for inclusion at this time into Koha's GPL codebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #9 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Yes. Sorry if I was unclear. Also sorry to have copied the header form another file. The Katipo copyright is of course wrong and should be removed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mathilde.formery@ville-nime | |s.fr --- Comment #10 from MathildeF <mathilde.formery@ville-nimes.fr> --- The report works only with "Pay fines" and not when we create manual invoice or credit -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments (even if the patch is not signed off, I watched it with Mathilde a few minuts ago): + Join borrowers t2 On t1.borrowernumber=t2.borrowernumber + Where amount<0 AND accounttype like 'Pay' AND CAST(t1.date AS DATE) between ? AND ? => you must write SQL keywords in capital cases (WHERE, JOIN,...) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #10)
The report works only with "Pay fines" and not when we create manual invoice or credit
A "manual invoice" should not appear in this report, we agree. but a manual credit should, that's why the patch failed QA The SQL request should not be "accounttype ='Pay' " but "accounttype in('L','Pay')" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5640|0 |1 is obsolete| | Attachment #5641|0 |1 is obsolete| | --- Comment #13 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 9379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9379&action=edit New patch that fixes problems Here is a new patch that fixes indentation, wrong documentation and licences, coding style and fixes the last reported problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Maxime, Thanks for your patch. Sorry but can you repropose it with tabulation characters replaced with 4 spaces please ? You can read the Koha guidelines on the wiki: http://wiki.koha-community.org/wiki/Coding_Guidelines#Perl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9379|0 |1 is obsolete| | --- Comment #15 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 9419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9419&action=edit Patch with 4 spaces Sorry for that! Totally mixed up the coding standards with another project. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #16 from Maxime Pelletier <pelletiermaxime@gmail.com> --- (In reply to comment #12)
(In reply to comment #10)
The report works only with "Pay fines" and not when we create manual invoice or credit
A "manual invoice" should not appear in this report, we agree. but a manual credit should, that's why the patch failed QA
The SQL request should not be "accounttype ='Pay' " but "accounttype in('L','Pay')"
Just realized that I blindly copy and pasted this, but I think it's wrong. L is for lost. Manual credits are 'C' or 'FOR'. I will send a new patch soon if this makes sense to you. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Changing this bug's status back to "assigned" since it appears we're waiting for a new patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9419|0 |1 is obsolete| | --- Comment #18 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 12602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12602&action=edit New patch rebased on 3.8.5 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 12660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12660&action=edit Calendar icon missing - The calendar icons are not displayed, only text "Show calendar". The image path points to (...)/koha-tmpl/intranet-tmpl/prog/en/lib/calendar/cal.gif (does not exist). With other reports (e.g. Patrons), the path points to (..)/intranet-tmpl/prog/img/famfamfam/silk/calendar.png - While loading the page I get a JavaScript Reference Error: Calendar is not defined. As a result, date picker does not work. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #20 from Maxime Pelletier <pelletiermaxime@gmail.com> --- We made many changes to this report recently. I will try to send a new patch soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m Assignee|pelletiermaxime@gmail.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #21 from simith.doliveira@inlibro.com --- Created attachment 31210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31210&action=edit Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5635|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12602|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12660|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #22 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36476&action=edit [SIGNED-OFF] Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #31210|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 36476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36476 [SIGNED-OFF] Bug 6934 New report Cash Register Statistics Review of attachment 36476: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6934&attachment=36476) ----------------------------------------------------------------- Hi Simith, I have added a few comments from code review - please fix in a follow-up. I have only marked the first occurrence of each, please also look below and above to make sure to get them all. Thx! ::: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc @@ +10,4 @@
<li><a href="/cgi-bin/koha/reports/catalogue_stats.pl">Catalog</a></li> <li><a href="/cgi-bin/koha/reports/issues_stats.pl">Circulation</a></li> <li><a href="/cgi-bin/koha/reports/serials_stats.pl">Serials</a></li> + <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash Register</a></li>
Please fix capitalization here and in the other template files to obey our rules. Thx! ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt @@ +7,5 @@
+<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> +<script type="text/javascript" id="js">$(document).ready(function() { + $(document).ready(function() { + $("#tbl_cash_register_stats").dataTable($.extend(true, {}, dataTablesDefaults, { + "iDisplayLength": 50
Be careful, without adding a paging option here, the paging on the table is broken (see recent 'paging' bugs for examples on how to fix) @@ +143,5 @@
+ <option value="F">Fine</option> + [% END %] + + [% IF transaction_type == "FU" %] + <option value="FU" selected="selected">Fine - long period</option>
Please check fine descriptions with those in the other templates - I think this one is not quite right. @@ +233,5 @@
+ <thead> + <tr> + <th>Manager name</th> + <th>Borrower cardnumber</th> + <th>Borrower name</th>
Please use patron instead of borrower. @@ +234,5 @@
+ <tr> + <th>Manager name</th> + <th>Borrower cardnumber</th> + <th>Borrower name</th> + <th>Branch</th>
Please use library instead of branch. @@ +240,5 @@
+ <th>Transaction type</th> + <th>Amount</th> + <th>Biblio title</th> + <th>Barcode</th> + <th>Document type</th>
Please use item type. ::: reports/cash_register_stats.pl @@ +14,5 @@
+# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +use strict; +use warnings;
Please use Modern::Perl; instead. @@ +22,5 @@
+use C4::Reports; +use C4::Output; +use C4::Koha; +use C4::Circulation; +use C4::Dates qw/format_date format_date_in_iso/;
Please avoid use of C4::Dates as it's deprecated. @@ +45,5 @@
+my $output = $input->param("output"); +my $basename = $input->param("basename"); +my $transaction_type = $input->param("transaction_type") || 'ACT'; +my $branchcode = $input->param("branch") || C4::Context->userenv->{'branch'}; +our $sep = ",";
I think the separator should not be hardcoded, it would be better to use a pull down like on the other reports or using the delimiter system preference. @@ +49,5 @@
+our $sep = ","; + +$template->param( + do_it => $do_it, + DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),
We are no longer using DHTML calendar, please use the TT Dates plugin instead. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira@inlibro.co |maxime.beaulieu@inlibro.com |m | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #24 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42564&action=edit Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #25 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42565&action=edit Bug 6934 - Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |genevieve.plantin@inlibro.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |In Discussion --- Comment #26 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Genevieve Sorry but patch fails This is when invalid date is enter in both dates. Marc can help you with this kind of issues. Or see bugs related with Remove C4::Dates. Software error: The 'month' parameter ("32") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/lib/i386-linux-gnu/perl5/5.20/DateTime.pm line 197. DateTime::new(undef, "month", 32, "minute", 0, "hour", 0, "year", 2015, ...) called at /var/koha/koha/Koha/DateUtils.pm line 164 Koha::DateUtils::dt_from_string("12/32/2015", "metric") called at /var/koha/koha/reports/cash_register_stats.pl line 75 Another think is patch does not follow dateformat sypref at all I can see "Cash Register statistics 2015-11-12 to 2015-11-12" in form title but in interval from 12/11/2015 to 12/11/2015, both most display equal. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #27 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Fix capitalization in form title "Cash Register statistics 2015-11-12 to 2015-11-12" Patch still apply, cvs exported successful data in screen display OK. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #28 from Marc Véron <veron@veron.ch> --- (In reply to Héctor Eduardo Castro Avalos from comment #26) (...)
Marc can help you with this kind of issues. Or see bugs related with Remove C4::Dates. (...)
- Jonathan introduced Bug 15166 - Make output_pref accept a string as parameter. An example is to be found in acqui/invoice.pl line 84 (with Bug 14946 applied). - Todays date as dt: dt_from_string without any params. See example from Bug 14946, acqui/histsearch.pl, line 81: my $from_placed_on = eval { dt_from_string( $input->param('from') ) } || dt_from_string; -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- according to comment #26 it's more failed QA than need discussion -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42565|0 |1 is obsolete| | --- Comment #30 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 44847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44847&action=edit Bug 6934 - Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #31 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Thanks for the tips, I obsoleted the previous patch and I fix the rest in it. I understood the KohaDates better, thanks really. There are some features and improvements that I need to add, it will come in another path soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #32 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 44853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44853&action=edit Bug 6934 - New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Thanks for the tips, I obsoleted the previous patch and I fix the rest in it. I understood the KohaDates better, thanks really. There are some features and improvements that I need to add, it will come in another path soon. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #34 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Sorry, I didn't notice the comments #33 was duplicated. This patch is ready to be tested :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42564|0 |1 is obsolete| | --- Comment #35 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45972&action=edit [SIGNED-OFF]Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home > Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44847|0 |1 is obsolete| | --- Comment #36 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45973&action=edit [SIGNED-OFF]Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44853|0 |1 is obsolete| | --- Comment #37 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45974&action=edit [SIGNED-OFF]Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ +function isNull(f,noalert) { not used later 2/ The datepicker from/to should be done using the datepickerfrom and datepickerto css class (see acqui/histsearch.tt for an example). 3/ Why do we have to fill a date? 4/ Ergonomic: the date interval is in a table with only 1 column and 1 row, it could be better to move them in the same fieldset as the 2 dropdown lists. 5/ $fullreportname is only used once, not needed. 6/ +my $fromDate = dt_from_string; and later + beginDate => dt_from_string($fromDate), You are passing a DT to dt_from_string, a string is expected. 7/ Remove the unneeded commented lines ("^###") 8/ The csv file should be generated using Text::CSV::Encoded 9/ The column names should be retrieved using C4::Reports::Guided to get the translated values -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15654 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org