[Bug 15285] New: Upgrade DataTables to 1.10.10 or later
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Bug ID: 15285 Summary: Upgrade DataTables to 1.10.10 or later Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org As of today DataTables is at version 1.10.10. The current version DataTables and its associated plugins (colVis, columnFilter, rowGrouping) blocks upgrade of jQuery from 1.7.x because the colVis plugin uses jQuery features which were deprecated in 1.7.x and removed in 1.11.x. The DataTables ColVis plugin is now "retired:" http://datatables.net/extensions/colvis/ ...and the functionality moved into "buttons:" http://datatables.net/reference/button/colvis -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can someone tell yet how bad of a rewrite this will cause? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45639&action=edit Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45640&action=edit Bug 15285: Update common files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45641&action=edit Bug 15285: POC with currency.tt This change will have to be done for all templates currently using the ColVis plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #1)
Can someone tell yet how bad of a rewrite this will cause?
Looks quite easy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Glad to hear that :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15471 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 [Bug 15471] Add column settings and filters to Holds queue table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Tested, works with currency table and with Bug 15471. Status is "New" at the moment, does it need Sign-off or are there updates to come? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45640|0 |1 is obsolete| | Attachment #45641|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46484&action=edit Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46485&action=edit Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I let CSS experts modify the style of the new button :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 46683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46683&action=edit Screenshots table 'All funds' With patch the table "All funds" looks weird. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46686&action=edit Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #11)
Created attachment 46683 [details] Screenshots table 'All funds'
With patch the table "All funds" looks weird.
Thanks, good catch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45639|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 47261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47261&action=edit Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46484|0 |1 is obsolete| | --- Comment #15 from Marc Véron <veron@veron.ch> --- Created attachment 47263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47263&action=edit Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46485|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 47264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47264&action=edit Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46686|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 47266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47266&action=edit Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org