[Bug 28734] New: Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Bug ID: 28734 Summary: Koha::Biblio->get_marc_notes should use XSLTParse4Display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 27268 moved C4::Biblio::GetMarcNotes to Koha::Biblio->get_marc_notes, but neglected to include the call to XSLTParse4Display. This means that authorised values aren't being replaced with their descriptions. To reproduce: 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. <-- BUG -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Depends on| |27268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123016&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123346&action=edit Bug 28774: Don't store blank values for rental discount This patch adds 'can_be_blank => 0' for the rentaldiscount rule to prevent storing blank values in the database Additionally, if there is no charge we do not need to check for a discount and can simply return To test: 1 - Set rental discount to "" to a rule in circulation rules 2 - Checkout an item that will follow this rule 3 - Check the intranet log: [WARN] Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/C4/Circulation.pm line 3385. 4 - Apply patch and restart all 5 - Update database 6 - Set the rule to "" again 7 - Check the DB, no rule is stored SELECT * FROM circulation_rules WHERE rule_name = 'rentaldiscount'; 8 - Checkout the item again 9 - No warns in log Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #123346|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Comment on attachment 123346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123346 Bug 28774: Don't store blank values for rental discount My bad - accidently used the wrong bug number! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123016|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 123349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123349&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123349|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124231&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks all good, but I feel like we'll need a regression test as this is a change to a module method. Holding off PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #6)
This looks all good, but I feel like we'll need a regression test as this is a change to a module method. Holding off PQA.
As QA manager you are allowed to change status, Katrin :) Let me do it for you now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124231|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125574&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125575&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Biblio->get_marc_note |Koha::Biblio->get_marc_note |s should use |s should parse authorised |XSLTParse4Display |values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125574|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 125634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125634&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125575|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 125635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125635&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125634|0 |1 is obsolete| | Attachment #125635|0 |1 is obsolete| | --- Comment #12 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125660&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #13 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125661&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #14 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125662&action=edit Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125663&action=edit Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Looks good to me, passing QA. Aleisha, btw, please in the future don't add unrelated changes to the same commit, ("xml_escape" -> "C4::Koha::xml_escape"), it takes more reviewer's time when the change is not explained and it makes harder to backport the patch to stable releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. -use Koha::AuthorisedValueCategories; -use Koha::AuthorisedValues; +use Koha::AuthorisedValueCategory; +use Koha::AuthorisedValue; Joonas, Aleisha was correct. We load the plurals modules, which will load the singulars. 2. I first got the tests fail: # Failed test 'Authorised value is correctly parsed to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 617. # got: 'CODE' # expected: 'Description should show' # Failed test 'Authorised value is correctly parsed for OPAC to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 624. # got: 'CODE' # expected: 'Description should show OPAC' # Looks like you failed 2 tests of 13. After a restart_all they passed. We should deal with the cache. 3. - $value = GetAuthorisedValueDesc( $tag, $letter, $value, '', $tagslib ) + $value = GetAuthorisedValueDesc( $tag, $letter, $value, $frameworkcode, $tagslib, undef, $opac ) Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode (especially when it's used at 75 my $av = getAuthorisedValues4MARCSubfields($frameworkcode)), but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- About 3. actually GetAuthorisedValueDesc does not case about $framework (it does not do anything with it). To prevent confusion we should not modify it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125687&action=edit Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Remove uneeded C4::Koha:: prefix 3. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #17)
2. I first got the tests fail:
Hum, cannot longer recreate that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #22 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #17)
1. -use Koha::AuthorisedValueCategories; -use Koha::AuthorisedValues; +use Koha::AuthorisedValueCategory; +use Koha::AuthorisedValue;
Joonas, Aleisha was correct. We load the plurals modules, which will load the singulars.
Oh, I didn't know this was the preferred way, we could add it maybe to the coding guidelines? To me it seemed more logical to always import directly the modules we are using and not trust that the other module will do it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125660|0 |1 is obsolete| | Attachment #125661|0 |1 is obsolete| | Attachment #125662|0 |1 is obsolete| | Attachment #125663|0 |1 is obsolete| | Attachment #125687|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125724&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Remove uneeded C4::Koha:: prefix 3. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected but I failed to understand what's going on. (In reply to Joonas Kylmälä from comment #22)
(In reply to Jonathan Druart from comment #17)
1. -use Koha::AuthorisedValueCategories; -use Koha::AuthorisedValues; +use Koha::AuthorisedValueCategory; +use Koha::AuthorisedValue;
Joonas, Aleisha was correct. We load the plurals modules, which will load the singulars.
Oh, I didn't know this was the preferred way, we could add it maybe to the coding guidelines? To me it seemed more logical to always import directly the modules we are using and not trust that the other module will do it.
For Koha::Object-based objects, all plurals needs their respective singular. It avoid to have the 2 use statements. We could indeed add that to the guidelines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125724|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125725&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #24)
I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected but I failed to understand what's going on.
This was very weird right! Glad it wasn't just an odd bug happening for me.
(In reply to Joonas Kylmälä from comment #22)
(In reply to Jonathan Druart from comment #17)
Thanks both! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Please rebase for 21.05.x if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126052&action=edit Bug 28734: Clear cache to prevent random failures MSS is modified, we must clear the cache before and after # Failed test 'Authorised value is correctly parsed to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 617. # got: 'CODE' # expected: 'Description should show' # Failed test 'Authorised value is correctly parsed for OPAC to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 624. # got: 'CODE' # expected: 'Description should show OPAC' # Looks like you failed 2 tests of 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #31 from Pablo AB <pablo.bianchi@gmail.com> --- Will be backported to 21.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Pablo AB from comment #31)
Will be backported to 21.05.x?
Yes, it should be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 [Bug 29970] 500 Error when a record cannot be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Bug 28734 depends on bug 27268, which changed state. Bug 27268 Summary: Move C4::Biblio::GetMarcNotes to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org