https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected but I failed to understand what's going on. (In reply to Joonas Kylmälä from comment #22)
(In reply to Jonathan Druart from comment #17)
1. -use Koha::AuthorisedValueCategories; -use Koha::AuthorisedValues; +use Koha::AuthorisedValueCategory; +use Koha::AuthorisedValue;
Joonas, Aleisha was correct. We load the plurals modules, which will load the singulars.
Oh, I didn't know this was the preferred way, we could add it maybe to the coding guidelines? To me it seemed more logical to always import directly the modules we are using and not trust that the other module will do it.
For Koha::Object-based objects, all plurals needs their respective singular. It avoid to have the 2 use statements. We could indeed add that to the guidelines. -- You are receiving this mail because: You are watching all bug changes.