https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40955 --- Comment #1 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 187473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187473&action=edit Bug 40995: SIP add a message at checkin for document with hold Bug 40995: SIP add a message at checkin for document with hold Add a screen message (AF) when a document with a hold is checked in. Only show when the parameter show_checkin_message is set to 1. To test: 1- Checkout a document to a patron A 2- Place a hold for patron B for this document 3- Do a checking using SIP 4- Check that the screen message (AF field) contain a text warning that the item is on hold, and that the return has been correctly done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |marion.durand@biblibre.com |ity.org | Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marion, some first notes: 1) QA tests pass 2) Code review a) Terminology "Item reserved by another patron" We need to use "hold" instead of "reserve" See: https://wiki.koha-community.org/wiki/Terminology#R Suggestion: "There is a hold for another patron on the item" Do we need the information, that the hold is for another patron or could it just be: "There is a hold on the item" ? b) Unit tests I wonder if there should be a unit test. We do have tests for the other message in this section in t/db_dependent/SIP/Transaction.t. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.