https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187098&action=edit Bug 40908: Remove JS confirmation, fix link, fix modal To test: 1. Without the patch: -Clicking delete from the Actions button -> delete pops up both a JS alert and a BS confirmation modal. The deletion works. -Clicking the "Delete item" button that appears when you hover over any cell pops up both a JS alert and a BS confirmation modal. The deletion does NOT work. -The "Cancel" button in the delete-item-modal does nothing. 2. APPLY THE PATCH: -Clicking delete from the Actions button -> 1 modal for confirmation. The deletion works. -Clicking the "Delete item" button that appears when you hover over any cell pops up only a modal confirmation. The deletion works. -The "Cancel" button in the delete-item-modal properly closes the modal. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187098|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187111&action=edit Bug 40908: Remove JS confirmation, fix link, fix modal To test: 1. Without the patch: -Clicking delete from the Actions button -> delete pops up both a JS alert and a BS confirmation modal. The deletion works. -Clicking the "Delete item" button that appears when you hover over any cell pops up both a JS alert and a BS confirmation modal. The deletion does NOT work. -The "Cancel" button in the delete-item-modal does nothing. 2. APPLY THE PATCH: -Clicking delete from the Actions button -> 1 modal for confirmation. The deletion works. -Clicking the "Delete item" button that appears when you hover over any cell pops up only a modal confirmation. The deletion works. -The "Cancel" button in the delete-item-modal properly closes the modal. Signed-off-by: Jason <jvasche@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- This changes make sense and fix the bugs describes with deleting items on the additem page: Remove call to confirmDelete() to get rid of the alert that pops up before the modal. Change the delete_link data- attribute in cataloging_additem.js to match the way the Delete link is rendered in the actions drop down in additem.tt to fix the delete button in the cells. data-itemnumber="[% item.itemnumber | html %]" Add the bs prefix in data-bs-dismiss="modal" for Bootstrap 5 to fic the Cancel button in the modal. Nice work. Passing QA! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Depends on| |37115 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bug affecting Bug 37115, not in 24.11.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 [Bug 37115] Add the option to delete linked serials when deleting items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 40859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.