https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49692&action=edit Bug 16174: Warning in tt_valid.t due to bug 15527 Bug 15527 introduced a new directory (xslt) on the top level OPAC templates directory. The tt_valid.t script should include that top level dir on the list of excluded dirs so it doesn't look for themes there. To test: - Run $ prove xt/tt_valid.t => FAIL: You get the following warning: Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory at xt/tt_valid.t line 8 - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests pass and don't raise warnings. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49693&action=edit Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49693|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49703&action=edit Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are some more: git grep readdir|grep lib|grep js|grep -v xslt xt/author/icondirectories.t:my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh); xt/author/translatable-templates.t:my @opac_themes = grep { not /^\.|lib|js/ } readdir($dh); xt/author/translatable-templates.t:my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh); xt/author/valid-templates.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { xt/author/valid-templates.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { xt/single_quotes.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { xt/single_quotes.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { xt/tt_valid.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { Not the ones for the staff interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49737&action=edit Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49778&action=edit Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.