[Bug 16172] New: OAI Server tests broken by bug 15946
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Bug ID: 16172 Summary: OAI Server tests broken by bug 15946 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Bug 15946 fixed a couple problems regarding schema and metadata namespaces, but forgot to adjust the tests to reflect this behaviour change, thus, the tests are broken. To reproduce: - Run $ prove t/db_dependent/OAI/Server.t => FAIL: Tests fail due to differences in the output. Patch to come. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49687&action=edit Bug 16172: fix OAI Server tests broken by bug 15946 This patch makes t/db_dependent/OAI/Server.t test for the correct schema and metadata namespace. To test: - Run $ prove t/db_dependent/OAI/Server.t => FAIL: Tests fail due to differences in the output. - Apply the patch - Run $ prove t/db_dependent/OAI/Server.t => SUCCESS: Tests now pass - Sign off Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49687|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49704&action=edit Bug 16172: fix OAI Server tests broken by bug 15946 This patch makes t/db_dependent/OAI/Server.t test for the correct schema and metadata namespace. To test: - Run $ prove t/db_dependent/OAI/Server.t => FAIL: Tests fail due to differences in the output. - Apply the patch - Run $ prove t/db_dependent/OAI/Server.t => SUCCESS: Tests now pass - Sign off Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49704|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49735&action=edit Bug 16172: fix OAI Server tests broken by bug 15946 This patch makes t/db_dependent/OAI/Server.t test for the correct schema and metadata namespace. To test: - Run $ prove t/db_dependent/OAI/Server.t => FAIL: Tests fail due to differences in the output. - Apply the patch - Run $ prove t/db_dependent/OAI/Server.t => SUCCESS: Tests now pass - Sign off Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just quick big note: our Koha::OAI::Server::Repository is broken if HTTP::OAI 4.03 is installed (testing): Can't locate object method "xslt" via package "Koha::OAI::Server::ListMetadataFormats" at Koha/OAI/ Server/Repository.pm line 139. Everything is ok using Jessie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16172 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org