[Bug 36757] New: Add assignee to catalog concern/ticket detail view when opened from catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Bug ID: 36757 Summary: Add assignee to catalog concern/ticket detail view when opened from catalog detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 35657 You can access the detail information about a cataloguing concern either from the cataloguing module (cat) or the bibliographic record (bib) bib: The assignee doesn't display in the upper right corner cat: The assignee DOES display in the upper right corner For both: If no update text was written, we miss a space in the info on the right side: Nicole SchneiderPrivate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 [Bug 35657] Add ability to assign tickets to librarians for catalog concerns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166241&action=edit Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36800 [Bug 36800] Move tickets/concerns table to include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I'm not seeing any changes (I even reset_all). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, that's interesting.. it's all working for me here. I set an assignee and that displays in the table.. I create some status and resolved AV's and use them, and those appear in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh.. the Modal is also displayed different.. let me look at that now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166241|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166259&action=edit Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch David, I've corrected that now too.. I'd missed passing the assignee via the table action button.. it's now there too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166259|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 166295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166295&action=edit Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #8 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #0)
For both: If no update text was written, we miss a space in the info on the right side: Nicole SchneiderPrivate
I confirmed that this patch makes the form match up when accessing it via a bib and via the concerns tool. It did not correct the spacing issue Katrin mentioned, and I didn't immediately see how to do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The spacing issues predate these patches and followups. I'd like to try to resolve those in a distinct bug as I've been round in circles a few times with that already and don't think doing so in this bug would be beneficial at this time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36807 [Bug 36807] Missing space in concerns update line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #10 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Martin Renvoize from comment #9)
The spacing issues predate these patches and followups. I'd like to try to resolve those in a distinct bug as I've been round in circles a few times with that already and don't think doing so in this bug would be beneficial at this time
Filed BZ 36807 for that, agreed it's not critical to this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166295|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 166361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166361&action=edit Bug 36757: Sync concerns tables This patch re-syncs the two catalog concerns display tables markup. We add the 'Title' field into the catalog/detail version of the table and split the columns settings so you can control the table distinctly from the cataloguing module version so we can hide 'title' by default in the details display tab. This results in the table matching the display from the cataloguing module page, i.e. the assignee and status detail displays. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #12 from David Nind <david@davidnind.com> --- Adding my sign off, in case that helps with QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I will push this as is, but I still see some differences on the detail page itself: "Details" button in last column: * Shows assignee in top right corner * Shows the "update" button after concern was resolved "speaking bubble icon" in details column: * Doesn't show assignee in top right corner * Shows the "update" and the "resolve" button after concern was resolved I'll still push this as is, but will set additional_work_needed. Can you please check? I ran yarn build and reset_all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166453&action=edit Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Paul Derscheid <me@paulderscheid.xyz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166453|0 |1 is obsolete| | --- Comment #16 from Paul Derscheid <me@paulderscheid.xyz> --- Created attachment 166455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166455&action=edit Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paulderscheid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but with the follow-up the modal no longer opens when I click on the number of "changes". Can you please double check? I tried a reset_all, restart_all, private browser window... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166455|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166548&action=edit Bug 36757: (QA follow-up) Fix for action on different triggers This patch updates the 'title' and 'comment count' links to action the same ticket detail/update modal as the 'details' button. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paulderscheid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh.. I missed a class on that page.. the sooner I get bug 36800 done the better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35657 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Bug 36757 depends on bug 35657, which changed state. Bug 35657 Summary: Add ability to assign tickets to librarians for catalog concerns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/957 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org