[Bug 17134] New: Facet's area shoes itemtypes' code instead of names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Bug ID: 17134 Summary: Facet's area shoes itemtypes' code instead of names Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: costalc@gmail.com QA Contact: testopia@bugs.koha-community.org In OPAC's search results, Koha shows itemtypes' codes instead name. See file attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #1 from bondiurbano <costalc@gmail.com> --- Created attachment 54491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54491&action=edit OPAC display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Facet's area shoes |Facet's area shows |itemtypes' code instead of |itemtypes' code instead of |names |item's description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Did you enter a description? The screenshot highlights 'Search category,' not 'Description.' Description is what should show in the facet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #3 from bondiurbano <costalc@gmail.com> --- Hi Owen! Yes, it should show item's Description instead of code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #4 from Claudio <costalc@gmail.com> --- Owen, this happens when an itemtype category (LIBRO) is assigned to an itemtype. Otherwise it works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did you set up your authorised value with both descriptions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #6 from Claudio <costalc@gmail.com> --- Hi Katrin, Yes, I did. See image attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #7 from Claudio <costalc@gmail.com> --- Created attachment 54493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54493&action=edit image -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the screenshot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #9 from Claudio <costalc@gmail.com> --- You're welcome! It did not happen in prior versions of Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #10 from Claudio <costalc@gmail.com> --- Owen, Katrin, would you please help me with this? It's a specific 16.05 error... Thanks a lot... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |10937 Component|OPAC |Searching Assignee|oleonard@myacpl.org |gmcharlt@gmail.com Version|16.05 |master --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Confirmed in master. I also find that searching by itemtype category doesn't work at all. No results. Claudio when you perform a search in the OPAC using an itemtype search category does it work? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #12 from Claudio <costalc@gmail.com> --- Owen! Thanks for working around this issue. Please see file attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #13 from Claudio <costalc@gmail.com> --- Created attachment 55364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55364&action=edit Search results and comparissons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #14 from Claudio <costalc@gmail.com> --- Owen, Reviewing my last file attached may be that comparissons between partial facet counts and total results are not important but the fact that advanced search with item category cirteria works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #15 from Claudio <costalc@gmail.com> --- Plese discard file attachment in comment#13 I will attach a better one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #16 from Claudio <costalc@gmail.com> --- I found the error. Line 619 in /usr/share/koha/opac/cgi-bin/opac/opac-search.pl See highlight word in image file attached. It must say: $itemtypes_nocategory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #17 from Claudio <costalc@gmail.com> --- Created attachment 55895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55895&action=edit Line 619 in opac-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Claudio, I tried to make your comment into a patch, but it seems like the grouping is broken on master? Not sure where my mistake is. I added BK into a group IGROUP. The search from advanced search brings up nothing - the facets don't show the group term but the normal itemtype description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #19 from Claudio <costalc@gmail.com> --- Created attachment 56573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56573&action=edit Error sample Katrin, please see file attached. I hope this help... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some issues with this feature, but I think we can still try and fix the issue Claudio reported. When testing this, make sure that you use the search on the itemtype group together with another search criteria (see bug 175319 To test: - add items for at least 2 itemtypes - create an authorised_value for ITEMTYPECAT - assign your used itemtypes to that category in administration > itemtypes - search for items in combination with another search criteria (title or whatever) - verify that the facet description for item tpyes is not correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #21 from Claudio <costalc@gmail.com> --- Hi Katrin! I attached a PDF with a test about this bug (item type descriptions). It is running in a production environment of mine and works fine. If you agree I can sign this bug off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #22 from Claudio <costalc@gmail.com> --- Created attachment 59123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59123&action=edit Item type description in OPAC search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Claudio, first we need a patch :) Would you be able to provide one? I have added the 'Academy' keyword, as there are some students working on bugs at Catalyst IT in NZ this week, but not sure if they will get to take a look at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #24 from Claudio <costalc@gmail.com> --- Line 614 in /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes,$query_type,$scan,1); should be replaced by this: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes_nocategory,$query_type,$scan,1); ====== Tested in 16.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #25 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59182&action=edit Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #26 from Claudio <costalc@gmail.com> --- I have already tested it in 2 production installations and in a local development one. May I sign-off this bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59182|0 |1 is obsolete| | --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59504&action=edit [SIGNED-OFF] Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that this has been introduced by bug 12478. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59504|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59572&action=edit Bug 17134: Replace item types codes with category in facets (opac) To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Emma! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. At last :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org