[Bug 18076] New: Plack error when placing a hold and holds per record is set to 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Bug ID: 18076 Summary: Plack error when placing a hold and holds per record is set to 999 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Ran into something odd today: When you have a 'holds per record' setting of 999 in your circulation conditions and try to place a hold in the staff client, you will get an 'internal server error' under Plack after looking up the patron to place the hold for. To test: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is shown The plack error logs show: Template process failed: undef error - WHILE loop terminated (> 1000 iterations) This has been verified on 2 different 16.11.x and on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plack error when placing a |Error when placing a hold |hold and holds per record |and holds per record is set |is set to 999 |to 999 CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE
""" The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. I'd suggest to replace it with an input box (type=number). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for the input box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60021&action=edit Bug 18076: Replace holds_to_place_count with an input type=text
From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE
""" The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60021|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 60041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60041&action=edit [SIGNED OFF] Bug 18076: Replace holds_to_place_count with an input type=text
From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE
""" The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60041|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60201&action=edit Bug 18076: Replace holds_to_place_count with an input type=text
From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE
""" The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org