http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25115&action=edit Bug 11708: Add aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25117&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11847 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by juliette levast <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26003&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26006&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this now, mostly small things: 1) Change wording from "Basket grouping" to "Basket groups" to be more consistent with other pages in Koha and also match the navigation link. 2) When using the link in the navigation, you end up with the heading: Basket grouping for (because no vendor was selected) 3) I am missing the vendor in the basket group table, I think the new view for all baskets would make more sense with it. 4) Use "Amount spent" instead of "Amount charged" - also to match other pages 5) Add correct bug number in database update It's only small things, I think only 3) is a bit bigger - everything else looks ok so far. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11438 --- Comment #10 from mathieu saby <mathsabypro@gmail.com> --- I did not look at your code, but from the description, some features (adding closeddate) reminds me a patch I wrote some time ago, and which needs sign off: Bug 11438 If your patch is pushed first, I suppose mine will need a rebase. I mark it in "see also" Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #12 from mathieu saby <mathsabypro@gmail.com> --- As I wrote, I made a patch adding the same feature (bug 11438). It does not apply, and I prefer not to rewrite it, but to wait for Jonathan's patches to be pushed. I put here the differences between my patch and Jonathan ones. Maybe it can be useful for QA, maybe not... Functionaly : My patch creates a field for closedate, but also an other for creationdate of the bg. I think it can be useful, but can be added in a 2d time after bug 11708 is pushed In the templates, the 2 dates are displayed in - in lists of opened/closed basketgroups - in an individual basketgroup. Internaly: I named the new fields "bg_closedate" and "bg_creationdate", to be sure there won't be any conflict with fields present in other tables with ambiguous names like "closedate" or "creationdate" I removed "closed" field, because I don't think it is needed anymore And finally, updatedatabase.pl creates the 2 columns and removes closed column, but also populates the 2 new columns: - bg_creationdate with the most recent closing date of the baskets included in each basketgroup - bg_closingdate with NULL is the bg is open, or with the most recent closing date of the baskets included in each basketgroup Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26004|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28869&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28871&action=edit Bug 11708: explicitly remove pagination The use of columnfilter seems to keep the pagination even if the sDom is 't'. We want to remove the pagination here in order to show all data in the table. To reproduce: Add 10+ closed basketgroup and verify all are displayed. Without this patch, only the 10 first are displayed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #8)

3) I am missing the vendor in the basket group table, I think the new view for all baskets would make more sense with it.

I didn't added the vendor in tables because it is already displayed before each pair of tables ("Basket groups for <vendor>") -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #22 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch against master 3.17.00.011 Applying: Bug 11708: Add aqbasketgroups.closeddate Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 11708: Add aqbasketgroups.closeddate When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28869|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31306&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28871|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31308&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #28 from Alessandra Carassiti <a.carassiti@cineca.it> --- I tried to test this patch with the sandbox system, it does not work, here is the result & paste what is written: 'Some problems occurred applying patches from bug 11708: <h1>Something went wrong !</h1>Applying: Bug 11708: Add aqbasketgroups.closeddate Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Applying: Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Renaming intranet-tmpl/prog/en/css/datatables.css => koha-tmpl/opac-tmpl/prog/en/css/datatables.css Auto-merging koha-tmpl/opac-tmpl/prog/en/css/datatables.css CONFLICT (rename/modify): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/datatables.css Failed to merge in the changes. Patch failed at 0001 Bug 11708: basketgroup.pl can now display basketgroups for all suppliers When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11708 - Display all basketgroups on one page, and new column aqbasketgroups.closeddate 31305 - Bug 11708: Add aqbasketgroups.closeddate 31306 - Bug 11708: Unit tests for aqbasketgroups.closeddate 31307 - Bug 11708: basketgroup.pl can now display basketgroups for all suppliers 31308 - Bug 11708: explicitly remove pagination 31309 - Bug 11708: All basketgroups on one page - several fixes Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11708-basketgrouppl-can-now-display-basketgrou-rdAn9M.patch .' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31306|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31531&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31308|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31533&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31530|0 |1 is obsolete| | --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31535&action=edit Bug 11708: Add aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31532|0 |1 is obsolete| | --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31537&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31534|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31539&action=edit Bug 11708: All basketgroups on one page - several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31536|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31541&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31538|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31543&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Ok, took me a while to figure out why these patches didn't apply well on sandbox. I was using "diff.noprefix=true" git option, thinking it was just a cosmetic option, but it also generate patches that don't apply well with "git am". The last patches should apply correctly everywhere now ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31703&action=edit Bug 11708: explicitly remove pagination The use of columnfilter seems to keep the pagination even if the sDom is 't'. We want to remove the pagination here in order to show all data in the table. To reproduce: Add 10+ closed basketgroup and verify all are displayed. Without this patch, only the 10 first are displayed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31705&action=edit Bug 11708: Remove the amount columns This should be managed in a specific bug. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #51 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch against 3.17.00.025 The patches can be applied with the following note. NB. The 5-th patch: All basketgroups on one page - several fixes changes updatadatabase.pl So, upgrading the database has to be done after having applied the 5-th patch. Otherwise, if database is upgraded soon after the 1-st patch, the 6-th patch can't be applied. That is the error: Applying: Bug 11708: Remove the amount columns Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Failed to merge in the changes. ------------------------------------------------------------------------------ So I pass the patch to "Signed Off" status. ------------------------------------------------------------------------------ Having no test plan, I've made some tests on basket groups and written the following notes. The first notes esplicitly relate to the new all bgs' page. IMO the 7-th and 8-th notes come straightforward using the basket groups. I invite to consider the 9-th note to define a better use (I can't suggest) for that option. In the case described in 10-th the name of the basket group is empty in the db, so perhaps the bug can be described better. I beg your pardon if some of the following notes/errors are out of this patch. In any case I hope the following notes can help in QA. basketgroup = bg 1) On the page of all bgs, after having selected "Delete" action on a bg, the next page is not the current one; the next page is about only one vendor [he is the one whose bg I've asked to delete] and it is the bgs' page of the vendor selected on the closed bgs' tag (ERROR). I think that the next page should be on the open bgs, at least. The closed bgs are completely different from deleted bgs. Moveover no closed bg can be deleted. So the current next page after deleting bgs can be misleading, and is unfriendly. 2) Displaying all bgs on one page, the "Delete" action is shown for all the open bgs. But only bgs without baskets inside are really deleted. So, the "Delete" action should not be shown [, or the delete should be done,] for open bgs with baskets inside. 3) On the page of all bgs, after having selected "Delete" action on a bg with baskets inside, now no message was shown if the bg is not deleted (see above, 2)). 4) : starting from a single vendor's bg, the behaviours described in 1), 2) and 3) are exactly the same. I beg your pardon if this point 4) is certainly out of this patch, but the problem is the same. 5) : the 2) and 3) problems occurred also deleting from the tag "xDelete basket group" [shown at the top of a just reopened bg, "Edit"ing an open bg, ...]. 6) On the all bgs page, I had a closed bg whose Billing place and Delivery place fields were none ("--"). I selected the "View" action of the bg: on the contrary the two fields were shown filled [with the current user's library]. This error occurred also: : 6b) on open bgs page, using "Edit" action in the all bgs page 6c) from the basket page, selecting the link to the linked closed bg 6d) editing a closed bg, using the "Reopen this bg" tag at the top of the page. Perhaps the case of a closed bg with Billing place and Delivery place fields set to none might be prevented by koha at all. 7) On the all baskets page, you can consider if the bg closeddate' column might be added. On the all baskets page, the "Bg" column is at the left of the column of the "Closed" date (which is the basket's close date). No basket can be attached to a bg before it (the basket) has been closed, so exchanging the two columns would be consistent with the sequence of events. If added, the bg's closeddate column would be the last column on the right before the actions' one. 8) On ACQ, I select a vendor. Under the right permission, in the "New" tag the Basketgroup option might be added to the current ones: Basket, Contract and Vendor. 9) baskets can be homonymous; bgs can be homonymous too. Closing an open basket, the option "Attach this basket to a new basket group with the same name" can easely create homonymous bgs, adding new closed ones to already existent open and closed ones. 10) For a vendor I created a new bg without filling the Basket group name. Then I selected a closed basket: but, using "Change bg" option, I saw an empty row added to the drop down list of the attachable bgs. ------------------------------------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31541|0 |1 is obsolete| | --- Comment #53 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31749&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31703|0 |1 is obsolete| | --- Comment #55 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31751&action=edit Bug 11708: explicitly remove pagination -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31705|0 |1 is obsolete| | --- Comment #57 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31753&action=edit Bug 11708: Remove the amount columns -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31748|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32909&action=edit Bug 11708: Add aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31750|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32911&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31752|0 |1 is obsolete| | --- Comment #63 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32913&action=edit Bug 11708: All basketgroups on one page - several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32909|0 |1 is obsolete| | --- Comment #66 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 33308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33308&action=edit Bug 11708: Add aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32911|0 |1 is obsolete| | --- Comment #68 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 33310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33310&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32913|0 |1 is obsolete| | --- Comment #70 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 33312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33312&action=edit Bug 11708: All basketgroups on one page - several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #72 from Julian Maurice <julian.maurice@biblibre.com> --- There were a couple of conflicts about [% yuipath %] being removed in favor of [% interface %]. Oddly, I didn't had the same problem as you Katrin about the 5th patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Turns out I missed some of the conflicts when trying to resolve them - it's related to the push of the new Booksellers module from Jonathan. :( Julian, could you please rebase? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33309|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34937&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast@iepg.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33311|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34939&action=edit Bug 11708: explicitly remove pagination The use of columnfilter seems to keep the pagination even if the sDom is 't'. We want to remove the pagination here in order to show all data in the table. To reproduce: Add 10+ closed basketgroup and verify all are displayed. Without this patch, only the 10 first are displayed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33313|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34941&action=edit Bug 11708: Remove the amount columns This should be managed in a specific bug. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #84 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34977&action=edit Bug 11708: Fix bad resolution conflict with bug 12896 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #85 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Having a look at this one now.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply currently. Please also take a loot at Marcel's questions in comment#86. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34937|0 |1 is obsolete| | --- Comment #89 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35749&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34939|0 |1 is obsolete| | --- Comment #91 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35751&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34941|0 |1 is obsolete| | --- Comment #93 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35753&action=edit Bug 11708: Remove the amount columns Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #95 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35755&action=edit Bug 11708: Add descriptions in unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #97 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to M. de Rooy from comment #86)

QA Comment:

Passes qa tools.

Verified Basketgroups.t. This test does not contain any testnames in the calls to ok, is, etc. It is encouraged to do so. Could you please add?

Added by attachment 35755

Question: Do we still need the column closed, if you add a closeddate in aqbasketgroups? Do we create redundancy? And what about confusion like: Hey closed=0 but there is a closeddate? Please convince me that we should have both columns.

We probably don't need both. Removed in attachment 35756

[PATCH 6/7] Bug 11708: Remove the amount columns Commit message says only: This should be managed in a specific bug. Please explain.

The amount columns show wrong amounts (comment 45) so they are removed until a specific bug addresses this issue. If you think it's better to keep them, we can remove this patch I think. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35748|0 |1 is obsolete| | --- Comment #98 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35971&action=edit Bug 11708: Add aqbasketgroups.closeddate I've applied the 9 patches against master 3.19.00.011 head 7741 . The first patch: Add aqbasketgroups.closeddate needed a trivial rebase. Just as required, this patch : 1) on ACQ start page, basketgroup.pl displayed basketgroups for all suppliers 2) added these columns in basketgroups' table: -- No. of ordered titles -- No. of received titles -- closed date in closed basketgroups tables. 3) Added filters to basketgroup tables columns. 4) Shew "Basket groups" link only if the user has "group_manage" permission. 5) Removed basketgroups pagination (20+ tested). 6) Instead of "Basket grouping" used "Basket groups" . 7) Displayed vendor name in front of "Basket groups for" . 8) Added bug number in updatedatabase.pl. 9) Verified Basketgroups.t. 10) From the ACQ start page, the Baskets groups link could be run. The upgrading of DB set the current date as the closed date to the closed existent basket groups. So I pass this patch to "Signed Off" status. IMO in the 2 tags "Open" and "Closed" the numbers of the related basket groups could be added: "Open (X)" "Closed (X)" increasing the plainness of the resulting list. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35750|0 |1 is obsolete| | --- Comment #100 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35973&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35752|0 |1 is obsolete| | --- Comment #102 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35975&action=edit Bug 11708: All basketgroups on one page - several fixes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35754|0 |1 is obsolete| | --- Comment #104 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35977&action=edit Bug 11708: Fix bad resolution conflict with bug 12896 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35756|0 |1 is obsolete| | --- Comment #106 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35979&action=edit Bug 11708: Remove column aqbasketgroups.closed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some first findings from the code review: 1) Database update removes closed column, but it's still in kohastructure.sql. 2) I wonder if Basket groups should go first in the side navigation, as in the workflow the basket group happens before the orders are late or invoices can be done. 3) Why no paging on the basket groups datatable? 4) The database update statement is missing the version XXX - so it cannot be run from commandline. Mostly small things, please fix. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35972|0 |1 is obsolete| | --- Comment #110 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40261&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast@iepg.fr> Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35974|0 |1 is obsolete| | --- Comment #112 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40263&action=edit Bug 11708: explicitly remove pagination The use of columnfilter seems to keep the pagination even if the sDom is 't'. We want to remove the pagination here in order to show all data in the table. To reproduce: Add 10+ closed basketgroup and verify all are displayed. Without this patch, only the 10 first are displayed. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35976|0 |1 is obsolete| | --- Comment #114 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40265&action=edit Bug 11708: Remove the amount columns This should be managed in a specific bug. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35978|0 |1 is obsolete| | --- Comment #116 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40267&action=edit Bug 11708: Add descriptions in unit tests Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #118 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patches rebased and updated with use of atomic updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #120 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #108)

Some first findings from the code review: Rebased/updated patch and last folow-up fix some of them:

1) Database update removes closed column, but it's still in kohastructure.sql. Fixed in followup

2) I wonder if Basket groups should go first in the side navigation, as in the workflow the basket group happens before the orders are late or invoices can be done. Done in the followup

3) Why no paging on the basket groups datatable? Jonathan tells it "conflict" with using columnfilter. I didn't manage to reproduce this. So i wonder if anyone already has this problem.

4) The database update statement is missing the version XXX - so it cannot be run from commandline. I updated the patches to replace statement in updatedatabase with atomic updates.

Mostly small things, please fix.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13487 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.