http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 35672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35672&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO This patch adds a policy flag in SIPConfig.xml that allows overriding branch on SIP2 checkout with the AO (institution id) field. Since SIP2 also uses C4::Context this patch has to modify C4::Context->userenv->{'branch'} Test plan: 1) Either use telnet or apply patch from bug #13159 to use sip command line client 2) Checkout book with SIP2 using a modified institution id (field AO) than the one defined in SIPConfig.xml for the account 3) Notice returned AO is still same as in SIPConfig account 4) Also notice checkout history in admin gives same 'checked out from' 5) Apply this patch and add 'allow_branch_override="true" to the policy of your ILS 6) Restart SIP server 7) Repeat 2) 8) Notice that 3) and 4) now reports the modified institution id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13159 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |benjamin.rokseth@kul.oslo.k |ity.org |ommune.no -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Hi Olli! To recap: the SIP-server infers the transaction branch from the C4::Context->userenv->{'branch'}, but for some reason only on checkouts. This has to do with how SIP2 uses AddIssue and ModReserve to handle reserves and circulation. AddIssue uses patron context, while AddReturn takes branch as param. This is probably good enough for intranet use, but not for a service. Use-case that illustrate this enhancement: - library has need for a centralised handling of SIP connections, for handling e.g. 10 or, say, 50 concurrent connections. SIP clients range from SelfCheck automats to RFID clients and automated circulation systems. - this is best handled by a centralised service which maintains a pool of connections (users sippool1, sippool2, ...) - centralised service handles connections and could easily open and close connections at need, so we don't have to open connection, login, and close for each transaction, (poor performance) or worse, spawn 100+ workers with keep-alive connections - more dynamic solution than maintaining two sets of "SIP users", one in SIPConfig.xml and the other in Koha - centralised service could handle retry logic, logging, message rewriting, etc, and SIP server can focus on transactions. I believe any library with a hope to use SIP2 effectively would benefit from this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 --- Comment #5 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Actually, AO is respected in checkins already, as AddReturn takes $branch as param, whereas AddIssue does not. I suppose the only reason AO was not respected in checkout initially was due to the fact that AddIssue doesn't take $branch as param, and this probably was left to be solved in AddIssue at a later stage. The web interface requires user to specify branch before checkout, so C4::Context->userenv->{'branch'} is set which is the same as this patch does. For Renew, location has no effect, and hold takes its own param, pickup_location (BR), so that's the reason only checkout is handled in this patch, which, in my opinion, should have been handled by AO in the first place, as SIP is a transport protocol and should not have other dependencies than authentication. Also, the protocol specifies that AO is a required field in all transactions and maps to the library’s institution ID, so SIP clients should adher to this. Anyway, if AO is left empty, the transaction will fallback to user context, so the patch will not cause anyone trouble -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40767|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 40768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40768&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO last patch failed tests due to fuzzy patching -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.