[Bug 15607] New: Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Bug ID: 15607 Summary: Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org The 'batch parton modification' tool seems to overwrite 'dateenrolled' and 'expirydate' fields with $todaysdate, if any of these fields are left unpopulated when updating confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07 to test... 1/ Set 'dateenrolled' and/or 'expirydate' fields of a test user 2/ Use 'batch parton modification' tool to update any other field (eg: 'State') 3/ Confirm that user's 'dateenrolled' and/or 'expirydate' fields have been incorrectly updated to $todays date :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 46928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46928&action=edit updating 'state' field -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 46930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46930&action=edit 'dateenrolled' and 'expirydate' fields have now been modified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15332 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12309 Depends on|15332 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15332 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #0)
The 'batch parton modification' tool seems to overwrite 'dateenrolled' and 'expirydate' fields with $todaysdate, if any of these fields are left unpopulated when updating
confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07
..this bug will also exist in 3.22.2 and 3.20.8 releases -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46980&action=edit Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46980|0 |1 is obsolete| | CC| |karamqubsi@gmail.com --- Comment #5 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 46983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46983&action=edit [SIGNED-OFF] Bug 15607: batch patron mod - do not update dates if not given batch works as described before applying this batch if you make (Batch patrons modification) all the Registration date and Expiry date fields for the affected patrons will be with today date and the original data will be lost . After applying this batch everything work fine . Thank you Jonathan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr, | |julian.maurice@biblibre.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CCing Rmaint 3.22 and 3.20: this fix must be in the 3.22.2 and 3.20.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46983|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 47055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47055&action=edit [PASSED QA] Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- PUshed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org