[Bug 15560] New: holding branch missing in pending reserves report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Bug ID: 15560 Summary: holding branch missing in pending reserves report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In pending reserves report, when there are several items spread into several branches, libraries are not displaid any more. It's due to Bug 12152 that replaces branchcode with branchname but can't deal with a list of branchcodes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12152 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- why not changing directly the SQL to get branchname rather than branchcode ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Sophie, sorry for causing the bug. :( I will try to fix, but not sure when I will have the time - so if someone wants to have a go, please do! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46964&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |--- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|holding branch missing in |Multiple holding branchs |pending reserves report |and locations not | |displaying in pending holds | |report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot a step in my test plan: To test: - Add a record with at least 2 items from different locations and holdingbranches >>> Place a hold on it! - Open the 'holds to pull' report - Verify all branches and locations show with their correct description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 natasha <tasham_8@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46964|0 |1 is obsolete| | --- Comment #5 from natasha <tasham_8@hotmail.com> --- Created attachment 46967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46967&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha <tasham_8@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46967|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46981&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha <tasham_8@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46982&action=edit Bug 15560: Fix display of multiple item types in pending reserves report Same fix as previous patch, but for item types. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org