https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182833&action=edit Bug 40024: Update requested_partners check Test plan, k-t-d, don't apply patch: 1) Enable ILLModule 2) Install a backend that does not provide the 'get_requested_partners' capability, e.g. the libkey lending tool (IncDocs) backend plugin: https://github.com/openfifth/koha-ill-libkey-lending-tool/releases/tag/v2.0.... 3) Restart plack $ koha-plack --restart kohadev 4) Create a new IncDocs ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=IncDocs 5) Add a DOI '123', a cardnumber '42' and any library. Click 'Make request'. 6) You should now be on the 'Manage request' page. Notice there's a '(0)' after the status 'New request'. This happens because '_backend_capability' method returns '0' if the backend does not implement the capability. The template checks for 'length', and length of '0' is '1'. 7) Apply patch. Refresh the 'Manage request' page. Notice the '(0)' is no longer shown. Additional testing, ensure no regression is added: 1) Edit the only ILL partner present in k-t-d: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 2) Add a 'primary email'. Click 'Save'. 3) Do the same but for a Standard request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add a type, a cardnumber '42' and any library. Click 'Make request'. 5) You should now be on the 'Manage request' page. Click 'Place request with partners'. Select the only one available 'FRL - Walker' and click 'Send email'. 6) Notice the status shows 'Requested from partners (<the_email_you_entered_in_step_2)'. This is the expected behavior and working as before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement removes release notes| |the '(0)' for the ILL | |request status field, where | |the ILL backend does not | |support the | |'get_requested_partners' | |capability. (The method | |returns '0' if the backend | |does not implement the | |capability. The template | |checks for 'length', and | |length of '0' is '1'.) --- Comment #3 from David Nind <david@davidnind.com> --- I've attempted a release note - please correct if I have got things wrong. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182892|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186718&action=edit Bug 40024: Update requested_partners check Test plan, k-t-d, don't apply patch: 1) Enable ILLModule 2) Install a backend that does not provide the 'get_requested_partners' capability, e.g. the libkey lending tool (IncDocs) backend plugin: https://github.com/openfifth/koha-ill-libkey-lending-tool/releases/tag/v2.0.... 3) Restart plack $ koha-plack --restart kohadev 4) Create a new IncDocs ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=IncDocs 5) Add a DOI '123', a cardnumber '42' and any library. Click 'Make request'. 6) You should now be on the 'Manage request' page. Notice there's a '(0)' after the status 'New request'. This happens because '_backend_capability' method returns '0' if the backend does not implement the capability. The template checks for 'length', and length of '0' is '1'. 7) Apply patch. Refresh the 'Manage request' page. Notice the '(0)' is no longer shown. Additional testing, ensure no regression is added: 1) Edit the only ILL partner present in k-t-d: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 2) Add a 'primary email'. Click 'Save'. 3) Do the same but for a Standard request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add a type, a cardnumber '42' and any library. Click 'Make request'. 5) You should now be on the 'Manage request' page. Click 'Place request with partners'. Select the only one available 'FRL - Walker' and click 'Send email'. 6) Notice the status shows 'Requested from partners (<the_email_you_entered_in_step_2)'. This is the expected behavior and working as before. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.