[Bug 39773] New: OPAC ILL form does not use client-side form validation for required fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Bug ID: 39773 Summary: OPAC ILL form does not use client-side form validation for required fields Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@openfifth.co.uk Reporter: pedro.amorim@openfifth.co.uk QA Contact: tomascohen@gmail.com CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com We're already using a required parameter. We should make use of it in the HTML and add the 'required' attribute to the HTML inputs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181649&action=edit Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181649|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181650&action=edit Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181650|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 182009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182009&action=edit Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182009|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184650&action=edit Bug 39773: Add 'required' attribute for required fields Test plan, apply patch: 1) Enable ILLModule 2) Create a new OPAC request, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Press 'Create'. Notice the required 'type 'is now validated before the form is submitted. Additional testing: 1) Enable ILLOpacUnauthenticatedRequest. Log out. Repeat 2) 2) Press 'Create'. Notice the required unauthenticated fields are highlighted as required. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|tomascohen@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |38340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38340 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Keywords|release-notes-needed | Text to go in the| |The OPAC interlibrary loan release notes| |request form now uses | |browser-based client-side | |validation for required | |fields. When creating a new | |ILL request, required | |fields (such as request | |type) are validated before | |the form is submitted, | |providing immediate | |feedback to users if | |required information is | |missing. | | | |This enhancement improves | |the user experience by: | |- Highlighting required | |fields that are empty when | |the user attempts to submit | |- Preventing incomplete | |forms from being submitted | |to the server | |- Reducing unnecessary page | |reloads for validation | |errors | | | |This validation applies to | |both authenticated ILL | |requests and | |unauthenticated requests | |(when the | |ILLOpacUnauthenticatedReque | |st system preference is | |enabled). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39773 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |aude.charillon@openfifth.co | |.uk --- Comment #8 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No update to the Koha Manual needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org