[Bug 39201] New: Escape double quotes for strings going into Javascript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 Bug ID: 39201 Summary: Escape double quotes for strings going into Javascript Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com As noted by Owen on the listserv, there are times where translators inject double quotes: #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt:379 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:100 #, c-format msgid "Not for loan status" msgstr "Статус \"на дом не выдается\"" Which leads to this: + ' <th id="items_status" data-colname="notforloan_status">' + _("Статус "на дом не выдается"") + '</th>' But really those backslash escapes should've been preserved or during the text replacement process they should've been escaped again. -- Personally, I don't know enough about the translation mechanisms to know the finer details, but I suspect that would be the answer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- All users can create suggestions. You must be part of the language team to accept suggestions or translate directly. There is a check in koha-i18n to prevent xss coming from weblate https://gitlab.com/koha-community/koha-i18n/-/blob/main/lib/KohaI18N.pm?ref_... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35043 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Related to commit 6757cd5f861e6f2972b48f669750003195e67304 Bug 35043: Use Locale::PO->quote And koha-i18n's commit 2460c96ab283407f9729f9a925129823b9012a8b Do not use Locale::PO to quote Looks like an historical behaviour. Will need more thoughts to know if it can be fixed (easily). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
Related to commit 6757cd5f861e6f2972b48f669750003195e67304 Bug 35043: Use Locale::PO->quote
And koha-i18n's commit 2460c96ab283407f9729f9a925129823b9012a8b Do not use Locale::PO to quote
Looks like an historical behaviour. Will need more thoughts to know if it can be fixed (easily).
Hmmm interesting. Looks like I have more to learn here about the translation process. I had hoped we'd be able to just deal with the Javascript tokens specifically, but looks like we might not be quite so lucky. In the case of itemsearch.tt and itemslost.tt, I think we could avoid needing _() if we used <template> instead, but I imagine there may be times it's difficult to avoid the _(). (I was looking a bit at the Vue.js and I think we're still using _() there a swell?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
(In reply to Jonathan Druart from comment #3)
Related to commit 6757cd5f861e6f2972b48f669750003195e67304 Bug 35043: Use Locale::PO->quote
And koha-i18n's commit 2460c96ab283407f9729f9a925129823b9012a8b Do not use Locale::PO to quote
Looks like an historical behaviour. Will need more thoughts to know if it can be fixed (easily).
Hmmm interesting. Looks like I have more to learn here about the translation process.
I had hoped we'd be able to just deal with the Javascript tokens specifically, but looks like we might not be quite so lucky.
In the case of itemsearch.tt and itemslost.tt, I think we could avoid needing _() if we used <template> instead, but I imagine there may be times it's difficult to avoid the _(). (I was looking a bit at the Vue.js and I think we're still using _() there a swell?)
We are using __() in vue components. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't think I will spend time on this soon if there is only one single occurrence of the problem. It can still be worked around using single quote. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39201 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #5)
We are using __() in vue components.
It's a shame we didn't go with something like the Vue i18n plugin but I can understand wanting to be consistently. (In reply to Jonathan Druart from comment #6)
I don't think I will spend time on this soon if there is only one single occurrence of the problem.
It can still be worked around using single quote.
It could happen in lots of other cases, but it seems to me like something that could also be caught in translation approval/review instead/as well. After looking at the Koha translation code, I can understand not wanting to make changes to it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org