[Bug 7758] New: Koha allowing LOST items to check out without alert
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Priority: P5 - low Change sponsored?: --- Bug ID: 7758 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Koha allowing LOST items to check out without alert QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha Currently, if an item marked as lost is missed at checkin, the system does not alert the librarian that the item was lost when issuing the item to a patron. We should add an alert with an ok/cancel box similar to the one for checking out items that are already issued to another patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8927&action=edit Bug 7758 - Koha allowing LOST items to check out without alert Adds a confirmation alert when issuing an item that has been marked as lost. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- patch looks good - one caveat, I suspect someone will propose that this should be a syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8927|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8931&action=edit Bug 7758 - Koha allowing LOST items to check out without alert Adds a confirmation alert when issuing an item that has been marked as lost. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, works as advertiesd Tested: - checking out an item that is marked lost performs all usual lost operations - checking out an item that is marked lost prompts for confirmation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- In check-in we show a non-blocking message that something was lost. I'm curious why we should block check-out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #4) If the consensus is that this should be non-blocking, I can modify the patch.
In check-in we show a non-blocking message that something was lost. I'm curious why we should block check-out.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #2)
patch looks good - one caveat, I suspect someone will propose that this should be a syspref.
Let me be that guy, non blocking and a syspref that can turn the alert off altogether if wanted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, nothing to say from QA point of view Pushing this patch before string-freeze because it contains a string ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8931|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9082&action=edit Bug 7758 - Followup - Make alert non-blocking -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9082|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9087&action=edit Bug 7758 - Followup - Make alert non-blocking Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, works as expected. I prefer the original, but this will suffice for the purposes of the original bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- Honestly, I prefer the original as well. Let's set this to in discussion for now. Maybe we can get some more people to weigh in on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- If you did a syspref you could have all 3 ; no alert, non blocking alert, blocking alert. Seems easiest to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #12 from Kyle M Hall <kyle.m.hall@gmail.com> --- That sounds like a good plan, I'll write another followup to implement that. (In reply to comment #11)
If you did a syspref you could have all 3 ; no alert, non blocking alert, blocking alert. Seems easiest to me.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9087|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9116&action=edit Bug 7758 - Followup - Add syspref allow a choice of blocking, non-blocking, or do nothing when issuing lost items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patch that was included in master will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tdavis@uttyler.edu --- Comment #15 from Elliott Davis <tdavis@uttyler.edu> --- This follow up patch works for all 3 scenarios. On a side note there is a conflict in the updatedatabase file, not really sure if that is noteworthy since it happens often. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9116|0 |1 is obsolete| | --- Comment #16 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9625&action=edit Bug 7758 - Followup - Add syspref allow a choice of blocking, non-blocking, or do nothing when issuing lost items. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * shouldn't this patch be in another bug ? I've pushed something for 7758 already, and can't push the follow-up/new patch in this branch without pain. Plus it's not really a follow-up, it's a 3.10 enhancement. * Adding an "alert" hash to CanBookBeIssued seems a good idea to me, must be advertised (i'll take care of this in my RM monthly newsletter when I'll push this patch) No other comment from QA point of view. Please create another bug, attach this patch to it (directly "signed-off", and i'll take care of pushing it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8167 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 --- Comment #18 from Kyle M Hall <kyle.m.hall@gmail.com> --- Done, bug 8167. Kyle (In reply to comment #17)
QA comment: * shouldn't this patch be in another bug ? I've pushed something for 7758 already, and can't push the follow-up/new patch in this branch without pain. Plus it's not really a follow-up, it's a 3.10 enhancement. * Adding an "alert" hash to CanBookBeIssued seems a good idea to me, must be advertised (i'll take care of this in my RM monthly newsletter when I'll push this patch)
No other comment from QA point of view. Please create another bug, attach this patch to it (directly "signed-off", and i'll take care of pushing it
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org