http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime@gmail.com --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> --- (In reply to comment #1)

Changing assignee to Frédérick since he originally designed the theme and can probably fix this.

Could you please remove Fréférick from all the ccsr tickets. He didn't design the theme (he did the mobile part and someone else from libeo and me did the rest) and he is not working anymore on Koha, so he won't be able to fix those bugs. I will do my best to get some time to look at those bugs, but they are all very easy to fix, so no need to assign them. Thanks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pelletiermaxime@gmail.com |oleonard@myacpl.org --- Comment #4 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Changing assignee back to default because i'm not able to fix any ccsr theme bug as we don't use it yet. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #6 from Ed Veal <ed.veal@bywatersolutions.com> --- Jared, I am going to test this but would like to make a suggestion. There are a few sites I am already working with and will be using the opacheader to place a library logo to the right of the search bar as it is functioning now. So if this passes QA and gets patched it will affect these sites. Might we be able to add a new system preference to work like the opacheader is working now on CCSR to accomodate this desired look? Just a thought. Ed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #8 from Ed Veal <ed.veal@bywatersolutions.com> --- Owen, Yes, I agree and that is what I was trying to say. I would like to opacheader work as it should and then add a new preference or just figure out a way to move the logos there. I was just bouncing around the idea. Ed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #9)

Maybe we could just copy from opacheader into the new preference on database update and preserve the current customizations that way?

Wouldn't copying over the contents of 'opacheader' to a new preference cause a bit of a surprise (in the form of duplicate text or the like) for libraries that aren't using CCSR? Also, that begs the question of whether a new system preference is needed -- shifting logos around could be done via OpacUserCSS, and at the moment I'm not convinced that we need to maintain backwards compatibility for what appears to simply have been an oversight. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18261|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18396&action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18396|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19018&action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised with one caveat; the content of opacheader is by default underneath the div "top-bar". A couple breaks in my OpacHeader test made it visible, so I'm going to assume this is a styling issue and not a bug as such. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19027&action=edit Bug 10245: add CSS classes to OPAC detail items table header Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, template changes only. Adds classes and id's to table headers, makes no other changes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19027|0 |1 is obsolete| | --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19028&action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised with one caveat; the content of opacheader is by default underneath the div "top-bar". A couple breaks in my OpacHeader test made it visible, so I'm going to assume this is a styling issue and not a bug as such. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19029|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19198&action=edit Bug 8884: (follow-up) rearrange placement of the top-bar div in CCSR This patch makes it easier to avoid having the top bar overlap other OPAC page content (particularly custom header content set via the opacheader system preference). This is done by moving the top-nav div outside of the main doc3 div and adjusting the CSS accordingly. Yes, this does end up having top-nav.inc be included from opac-bottom.inc, but it would require touching rather more templates to have it be included immediately after the <body> tag. This patch also removes a duplicate instance of the cmspan span. To test: [1] Change to the CCSR OPAC theme. [2] Before applying the patch, open a set of OPAC pages (e.g., main page, user page, search results, bib details) in your web browser. [3] Apply the patch, and open the same OPAC pages in separate tabs. Comparing the pre- and post- version of each page to verify that the placement [4] Add an OpAC header using the opacheader system preference. [5] Verify that the header is displayed without overlapping the top bar. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master along with the follow-up. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- First patch pushed to 3.10.x, will be in 3.10.8 Second does not apply. -- You are receiving this mail because: You are watching all bug changes.