[Bug 10496] New: opac tabs losing focus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Bug ID: 10496 Summary: opac tabs losing focus Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 19161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19161&action=edit title notes tab selected, but not highlighted In the OPAC when on the detail page the tabs in the holdings table don't have any focus in CCSR. I tested on a couple of master installs (one with custom CSS and one without). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- It's not just the detail page but the advanced search page as well - so probably any page with tabs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|opac tabs losing focus |CCSR theme OPAC tabs to not | |show correct active state -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19276&action=edit Bug 10496 - CCSR theme OPAC tabs to not show correct active state When jQueryUI was updated in the CCSR theme the corresponding CSS changes were not copied over at the same time, causing style problems with jQueryUI widgets. This patch makes the necessary changes. To test, apply the patch, clear your browser cache, and view any page which uses jQueryUI tabs (advanced search, bibliographic detail page). Tabs should look correct and correctly show which tab is active. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19276|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 19279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19279&action=edit [SIGNED-OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19279|0 |1 is patch| | Attachment #19279|application/mbox |text/plain mime type| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19279|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19294&action=edit [SIGNED OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state When jQueryUI was updated in the CCSR theme the corresponding CSS changes were not copied over at the same time, causing style problems with jQueryUI widgets. This patch makes the necessary changes. To test, apply the patch, clear your browser cache, and view any page which uses jQueryUI tabs (advanced search, bibliographic detail page). Tabs should look correct and correctly show which tab is active. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> CSS changes only. Confirmed problem in CCSR OPAC templates. Tested advanced search and detail pages in CCSR and prog. In order to fully test advanced search I added location and collection to AdvancedSearchTypes. Also tested the branch tooltip as I spotted some CSS added for that. Works beautifully, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org