[Bug 33390] New: Expand links to authorized values interface when an authval is mentioned in preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Bug ID: 33390 Summary: Expand links to authorized values interface when an authval is mentioned in preferences Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: catrina@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 31730 introduced the functionality to link from a mentioned authorized value to the corresponding authorized value page, showing which values are available to use when setting that system preference. This feature should be consistently available across system preferences, not just those that had been mentioned in the bug. Other system preferences that should be updated with this functionality are listed below. Lost (LOST): DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList Shelving Location (LOC): NewItemsDefaultLocation UpdateItemLocationOnCheckin Not for Loan (NOT_LOAN): SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses Several authorized values: ItemsDeniedRenewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149109&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149109|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149110&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #3 from Catrina Berka <catrina@bywatersolutions.com> --- Thank you, Lucas! This is exactly right and the patch works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Catrina. To complete the sign off, you need to change the status from "Needs Signoff" to "Signed Off". Then you will get the credit on the dashboard (https://dashboard.koha-community.org/). 8-) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #5 from Catrina Berka <catrina@bywatersolutions.com> --- I appreciate your help, David! Just changed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this and as I won't finish right now, leaving a first note: ItemsDeniedRenewal: I feel the placement of the links right after the examples you can copy and paste is not ideal. Maybe we could put them into an explanatory sentence below? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150178&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Looking at this and as I won't finish right now, leaving a first note:
ItemsDeniedRenewal: I feel the placement of the links right after the examples you can copy and paste is not ideal. Maybe we could put them into an explanatory sentence below?
I attached a follow-up to move those links. Let me know if you think that is better! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149110|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150909&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150178|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150910&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150911&action=edit Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried to provide some more context in a few spots. Lucas, if you hate it, please feel free to obsolete :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #12)
I tried to provide some more context in a few spots. Lucas, if you hate it, please feel free to obsolete :)
It looks great to me!! Thanks for the follow-ups! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150909|0 |1 is obsolete| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158191&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150910|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158192&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150911|0 |1 is obsolete| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158193&action=edit Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current master and reset to 'Signed-off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158191|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158200&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158192|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158201&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158193|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158202&action=edit Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to avoid translation work. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org