[Bug 25814] New: SIP: Add a message on successful checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Bug ID: 25814 Summary: SIP: Add a message on successful checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Currently, Koha does not return a message on successful SIP checkin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106058&action=edit Bug 25814: SIP: Add a message on successful checkin. Currently, Koha does not return a message on successful SIP checkin. This patchs adds the following message: - "Item checked-in: {homebranch} - {location}" Test plan: - Perform a successful checkin using SIP - Check that the message is in the checkin response (AF field) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this one is not correct. permanent_locaton != homebranch. But also: What if the item is not returned at the home library? The location might apply to the home library or the holding branch, it's hard to tell. I think I would probably not display it by default. Also I think this would display the codes, not the descriptions? I think I'd maybe leave it at "Item checked in" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106058|0 |1 is obsolete| | --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 154687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154687&action=edit Bug 25814: SIP: Add a message on successful checkin. Currently, Koha does not return a message on successful SIP checkin. This patchs adds the show_checkin_message option to SIPconfig.xml, disabled by default. When enabled, the following message is displayed on SIP checkin: "Item checked-in: {homebranch|permanent_location} - {location}" The UseLocationAsAQInSIP system preference is used to determine whether the homebranch or the permanent location will be used. Test plan: - Perform a successful checkin using SIP - Check that the message is in the checkin response (AF field) - prove t/db_dependent/SIP/Transaction.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Here is a new patch, that makes the message optional, is consistent with the UseLocationAsAQInSIP system preference, and adds unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154687|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 156142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156142&action=edit Bug 25814: SIP: Add a message on successful checkin. Currently, Koha does not return a message on successful SIP checkin. This patchs adds the show_checkin_message option to SIPconfig.xml, disabled by default. When enabled, the following message is displayed on SIP checkin: "Item checked-in: {homebranch|permanent_location} - {location}" The UseLocationAsAQInSIP system preference is used to determine whether the homebranch or the permanent location will be used. Test plan: - Perform a successful checkin using SIP - Check that the message is in the checkin response (AF field) - prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Checked out an item to koha using the staff interface: 39999000011418 2. Checked item in using SIP - no message at end after CRREF|: misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230925 01381820230925 013818APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230925 013818AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|AA42|CRREF| 3. Applied the patches. 4. Edited /etc/koha/sites/kohadev/SIPconfig.xml and added show_checkin_message="1": ... <accounts> <login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" show_checkin_message="1"/> .... 5. Restarted everything (restart_all). 6. Checked out the item again and then checked in using SIP - message displayed when UseLocationAsAQInSIP = permanent_location: misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230925 02031820230925 020318APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230925 020318AOCPL|AB39999000011418|AQGEN|AJProgramming Perl /|AA42|CRREF|AFItem checked-in: GEN - GEN.| 7. Checked out the item again and the checked in using SIP - message displayed when UseLocationAsAQInSIP = homebranch: misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230925 02083420230925 020834APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230925 020834AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|AA42|CRREF|AFItem checked-in: Centerville - GEN.| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to have a look at this one, but I would feel better if someone with more SIP knowledge double checked. Some notes: 0) Set assignee to Matthias 1) We need some perltidy Processing files before patches |========================>| 3 / 3 (100.00%) Processing files after patches |========================>| 3 / 3 (100.00%) WARN C4/SIP/ILS.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 186, now: 189) OK etc/SIPconfig.xml WARN t/db_dependent/SIP/Transaction.t WARN tidiness The file is less tidy than before (bad/messy lines before: 1, now: 17) 2) The tests were failing with me on my test database because I had added some new locations and used them on an item testing bug 21159. After a reset_all the tests are passing. 3) I'd love some type of documentation/notes in SIPconfig.xml to explain the use of the new option. 4) Also, never got a reply to my comment#2 about the codes vs. descriptions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156142|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158273&action=edit Bug 25814: SIP: Add a message on successful checkin. Currently, Koha does not return a message on successful SIP checkin. This patchs adds the show_checkin_message option to SIPconfig.xml, disabled by default. When enabled, the following message is displayed on SIP checkin: "Item checked-in: {homebranch|permanent_location} - {location}" The UseLocationAsAQInSIP system preference is used to determine whether the homebranch or the permanent location will be used. Test plan: - Perform a successful checkin using SIP - Check that the message is in the checkin response (AF field) - prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158274&action=edit Bug 25814: Add comment to example sip config file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158275&action=edit Bug 25814: Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- I've love to see the language moved to TT markup in the sip config, but I don't consider that a blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org