https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41898 |42998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41898 [Bug 41898] Expired bookings do not display when expired filter is used in patron record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42998 [Bug 42998] Allow a requested due date when renewing a checkout via the REST API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201557&action=edit Bug 42790: Unify booking actions and display across patron and biblio tables The patron bookings tab (moremember/circulation) and the biblio bookings page previously offered different actions and rendered status, item and action cells with duplicated, subtly different code. This patch introduces a shared rendering helper (js/bookings/common.js) used by both tables, delivering: * A unified action set gated on booking status and the logged in user's permissions: - new: Edit + Cancel (manage_bookings), Checkout (circulate) - issued: no edit/cancel actions (Extend follows in a later patch) - completed/cancelled: no actions * "Transform to checkout" on the biblio bookings page is renamed "Checkout" and the same shortcut is now offered from the patron bookings tab, posting the patron, barcode and booking end date through to the checkout screen * The patron bookings tab gains the Edit action, opening the same place booking modal used elsewhere (the modal markup and assets are now included on moremember and circulation pages) * For issued bookings, the Item column now also shows the checkout due date and a link to the checkout record (via the item.checkout embed, newly allowed on the biblio bookings endpoint) * New bookings whose collection window has opened are highlighted with table-info; new bookings whose window has passed without collection are highlighted with table-warning Both pages now expose their booking permissions through Koha.addPermissions rather than bare globals. Test plan: 1) yarn api:bundle && restart_all 2) Create a booking; confirm the patron bookings tab (patron details and checkout pages) shows Edit, Cancel and Checkout actions, and that the biblio bookings page shows the same 3) Confirm Edit opens the booking modal pre-populated on all pages 4) Click Checkout and confirm the checkout screen is pre-populated with the patron and item, and the due date defaults to the booking end date 5) Check out a booked item; confirm the Item column shows the due date and a link to the checkout on both displays 6) Create bookings with past start/end dates; confirm the row highlights appear on both displays -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored Comma delimited| |OpenFifth list of Sponsors| |<https://openfifth.co.uk/\> | |, Westminster City Council | |<https://www.westminster.go | |v.uk/\> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202372&action=edit Bug 42790: Add missing Scalar::Util import in Koha::REST::V1::Bookings The error handling in add() already calls blessed() but the module never imported it, so hitting the Koha::Exceptions::Booking::Clash catch branch died with an undefined subroutine error (masked as a 500 either way, but for the wrong reason). Test plan: 1) prove t/db_dependent/api/v1/bookings.t Sponsored-by: OpenFifth <https://openfifth.co.uk/\> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/\> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202374&action=edit Bug 42790: Add booking-aware Extend action for issued bookings This patch adds an Extend action to the bookings tables for issued bookings, visible to users with the circulate permission on both the patron bookings tab and the biblio bookings page. The button opens a new modal showing the current booking end date and the current checkout due date, with a flatpickr date picker that: * blocks the date ranges of any other new or issued booking for the same item * caps the maximum selectable date at the day before the earliest subsequent booking starts On confirm, the extension is performed as a staff authorised renewal of the linked checkout - a single call to POST /api/v1/checkouts/{checkout_id}/renewal with the requested due_date and the renewal_limit override. The server validates the date against bookings for the item and keeps booking.end_date in sync with the renewed due date. Errors (clash with the next booking, renewal limits with overrides disabled) are displayed inside the modal without closing it, so staff can pick an earlier date. The Extend button only renders when the booking has a linked checkout to renew. Test plan: 1) Create a booking, check the item out to the patron (booking becomes issued) and confirm the Extend button appears on both the patron bookings tab and the biblio bookings page 2) Click Extend; confirm the modal shows the current end date and the checkout due date 3) Create a subsequent booking for the same item; re-open the modal and confirm its dates are blocked in the picker and dates beyond its start cannot be selected 4) Select a valid new date and confirm; verify both the booking end_date and the checkout due date are updated 5) Confirm the checkout now shows a renewal in its renewal history Sponsored-by: OpenFifth <https://openfifth.co.uk/\> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/\> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202372|0 |1 is obsolete| | Attachment #202373|0 |1 is obsolete| | Attachment #202374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202499&action=edit Bug 42790: Unify booking actions and display across patron and biblio tables The patron bookings tab (moremember/circulation) and the biblio bookings page previously offered different actions and rendered status, item and action cells with duplicated, subtly different code. This patch introduces a shared rendering helper (js/bookings/common.js) used by both tables, delivering: * A unified action set gated on booking status and the logged in user's permissions: - new: Edit + Cancel (manage_bookings), Checkout (circulate) - issued: no edit/cancel actions (Extend follows in a later patch) - completed/cancelled: no actions * "Transform to checkout" on the biblio bookings page is renamed "Checkout" and the same shortcut is now offered from the patron bookings tab, posting the patron, barcode and booking end date through to the checkout screen * The patron bookings tab gains the Edit action, opening the same place booking modal used elsewhere (the modal markup and assets are now included on moremember and circulation pages) * For issued bookings, the Item column now also shows the checkout due date and a link to the checkout record (via the item.checkout embed, newly allowed on the biblio bookings endpoint) * New bookings whose collection window has opened are highlighted with table-info; new bookings whose window has passed without collection are highlighted with table-warning Both pages now expose their booking permissions through Koha.addPermissions rather than bare globals. Test plan: 1) yarn api:bundle && restart_all 2) Create a booking; confirm the patron bookings tab (patron details and checkout pages) shows Edit, Cancel and Checkout actions, and that the biblio bookings page shows the same 3) Confirm Edit opens the booking modal pre-populated on all pages 4) Click Checkout; the checkout is submitted with the patron, item and the booking end date as due date - confirm you land on the patron's checkout screen with the checkout made (or its confirmation pending, e.g. for an early collection) 5) Check out a booked item; confirm the Item column shows the due date and a link to the checkout on both displays 6) Create bookings with past start/end dates; confirm the row highlights appear on both displays Sponsored-by: OpenFifth <https://openfifth.co.uk/\> Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/\> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202501&action=edit Bug 42790: (QA follow-up) Only treat the booking's own checkout as linked The issued-row due date display and the Extend action trusted the item.checkout embed to be the checkout that collected the booking. A stale 'issued' booking whose item has since been checked out to somebody else would display - and offer to renew - the wrong patron's loan, and that renewal would not touch the booking at all (AddRenewal only syncs bookings linked via issues.booking_id). - resolve the linked checkout by matching checkout.booking_id against the booking before rendering the due date or offering Extend Test plan: 1. Book an item, check it out to its patron; the issued row still shows the checkout due date and the Extend action works as before 2. Clear the link (UPDATE issues SET booking_id = NULL WHERE issue_id = ...) and reload; the due date and Extend action disappear instead of acting on an unlinked loan Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202503&action=edit Bug 42790: (QA follow-up) Anchor the extend picker to the library timezone and floor it after the due date The extend picker did all of its date maths in the browser's local timezone while the API talks in instants and staff-facing displays are rendered in the library's configured timezone ($timezone()). With the two zones apart, the day boundaries drift: the floor, the blocked booking ranges and the submitted end-of-day all land on the wrong calendar day (e.g. a due date of 07/30 23:59 library time producing a floor of 08/01 in a +02:00 browser). The picker also floored at today, so with a due date a week out every selectable day but the last few shortened the loan instead of extending it - while still consuming a renewal. And the native required attribute fought the picker: submitting with an empty field popped the browser's own validation bubble over the calendar instead of the modal's styled error. - do all calendar maths in the library's timezone and hand flatpickr display dates via $toDisplayDate, mirroring the place booking modal (bug 42868) - anchor the submitted end date to the end of the selected day in the library's timezone - floor the picker at the day after the checkout due date (today for overdue checkouts) so only genuine extensions are selectable - mark the form novalidate; the submit handler's styled error message already covers the empty field Test plan: 1. Book an item, check it out and open Extend on the issued row: the first selectable date is the day after the checkout due date, also when the browser and the Koha instance are in different timezones 2. Backdate the checkout due date into the past (or let it lapse) and confirm the picker floors at today instead 3. Extend and confirm checkout due date and booking end date land on 23:59 of the selected day in the instance timezone 4. Submit with an empty date: the styled 'Please select a new end date' message appears in the modal, no browser bubble Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Btw, the move to shared abstractions here is chef's kiss :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 [Bug 41129] Migrate place_booking.js to a Vue island. -- You are receiving this mail because: You are watching all bug changes.