[Bug 22597] New: Remove "more_subfields_xml" from GetPatronInfo response (xml broken)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Bug ID: 22597 Summary: Remove "more_subfields_xml" from GetPatronInfo response (xml broken) Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 87070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87070&action=edit BrokenXml returned from GetPatronInfo with show_loans=1 If value in more_subfields_xml contains xml opening and closing tags then xml structure in broken and response cannot be read by the third-party software. I suggest removing <more_subfields_xml> from the response as it is done for GetRecords. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 87074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87074&action=edit Bug 22597 : Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87074|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87476&action=edit Bug 22597 : Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Signing off, but I think for QA a unit test will be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 87875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87875&action=edit Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #3)
Signing off, but I think for QA a unit test will be needed.
Hmm. For this very small change I will not insist on that. Note that GetPatronInfo is tested and still passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #87476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org