[Bug 21953] New: Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Bug ID: 21953 Summary: Term "Lost item" untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 82872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82872&action=edit pay.pl in French When I mark an item as lost and the fee is charged to the user, the description contains the translated string for "Lost item", followed by "Lost item" in English, followed by the title, the barcode and the title again (?) in parentheses. In English, "Lost item" appears twice: "Lost item, Lost item title barcode (title)". Could it be possible to remove the untranslatable "Lost item" part? To reproduce: 1) Make sure the system preference WhenLostChargeReplacementFee is set to "Charge" 2) Optional: In Administration > Item types, add a default replacement cost to your item types or the item type you plan to use 3) Loan an item to a patron 4) If there is no default replacement cost, make sure your item has a replacement price 5) In the patron's account > Details > Loans, click on the item's barcode 6) Set the Lost status to Lost 7) Go back in the patron's account > Fines 8) Notice it is written "Lost item, Lost item title barcode (title)" 9) If you have another language installed, switch to the other language 10) Notice it is written "Translated string, Lost item title barcode (title)" 11) Click "Pay" 12) Notice it is written "Lost item title barcode" 13) If you switch to your other language, it is still written in English 14) Click on "Account" 15) Notice the description is again "Lost item, Lost item title barcode (title)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 83433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83433&action=edit Bug 21953 - Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83433|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83439&action=edit Bug 21953 - Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 things: - Joubu already pointed out on IRC that there should be a test (change in C4) - Should we update existing data and remove the String there to have a clean state? It's mostly a display issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #3)
2 things:
- Joubu already pointed out on IRC that there should be a test (change in C4) - Should we update existing data and remove the String there to have a clean state? It's mostly a display issue.
In my opinion, this has been wrong from the begining: the information should be built for display using the account_type and the biblio information, but instead we hardcoded those values. Once Koha::Account::add_debit and friends is pushed, I'd review this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- 1. I don't know how to do tests, I'll know in the future not to touch anything in C4 even if it's a simple string patch. I feel it's a bit overkill to do tests just for removing two displayed words. But if someone wants to code tests, it's fine with me. I will de-assign myself the bug since I can't do more than submit the string patch. 2. I'm not sure how I would go about to update the existing data. I'm guessing it's an UPDATE using regex. 3. From Tomás' comment, I understand that this bug is put on the back burner. Should we change it to "in discussion"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|caroline.cyr-la-rose@inlibr |koha-bugs@lists.koha-commun |o.com |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #5)
1. I don't know how to do tests, I'll know in the future not to touch anything in C4 even if it's a simple string patch. I feel it's a bit overkill to do tests just for removing two displayed words. But if someone wants to code tests, it's fine with me. I will de-assign myself the bug since I can't do more than submit the string patch.
2. I'm not sure how I would go about to update the existing data. I'm guessing it's an UPDATE using regex.
3. From Tomás' comment, I understand that this bug is put on the back burner. Should we change it to "in discussion"?
I will try to take a look at the add_debit bugs again and see how it fits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83439|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86209&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86210&action=edit Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86211&action=edit Bug 21953: Update existing rows in DB -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleymapley@catalyst.net.n | |z --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Patch doesn't apply. Applying: Bug 21953: Term 'Lost item' untranslatable Applying: Bug 21953: Add tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t error: Failed to merge in the changes. Patch failed at 0001 Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86210|0 |1 is obsolete| | Attachment #86211|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86405&action=edit Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86406&action=edit Bug 21953: Update existing rows in DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86406|0 |1 is obsolete| | --- Comment #13 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86418&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Test plan passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Caroline but... There's a weird case here where a Lost item could receive two types of charge depending on what system preferences were in play. One with the code 'PF' for "Processing Fee" and another with the code "L" for Lost Item.. The DB update needs to catch both before I can PQA the bug.. Also, do we need to somehow distinguish that the Processing Fee line is attributed to the Lost item? With this patch we're losing that I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Term "Lost item" |Term "Lost item" is |untranslatable |untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 11573 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17413 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86209|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87593&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86405|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87594&action=edit Bug 21953: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86418|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87595&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Test plan passes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87596&action=edit Bug 21953: (QA follow-up) Corrections to DB Update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87597&action=edit Bug 21953: Clarify PF = Lost item processing fee Currently PF is only ever used for lost item processing fees. This patch alters the end user faceing description to clarify that. Note: It may be nice to make the code more descriptive too at some point, but that can happen in another bug in my opinion. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12156 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=12156 |?id=12166 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I've added the required followups myself... back to SO in the hopes I can get a quick QA from someone else on the team. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87593|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87599&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87594|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87600&action=edit Bug 21953: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87595|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87601&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Test plan passes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87596|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87602&action=edit Bug 21953: (QA follow-up) Corrections to DB Update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87597|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87603&action=edit Bug 21953: Clarify PF = Lost item processing fee Currently PF is only ever used for lost item processing fees. This patch alters the end user faceing description to clarify that. Note: It may be nice to make the code more descriptive too at some point, but that can happen in another bug in my opinion. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87599|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87659&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87600|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87660&action=edit Bug 21953: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87601|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87661&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Test plan passes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87602|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87662&action=edit Bug 21953: (QA follow-up) Corrections to DB Update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87603|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87663&action=edit Bug 21953: Clarify PF = Lost item processing fee Currently PF is only ever used for lost item processing fees. This patch alters the end user faceing description to clarify that. Note: It may be nice to make the code more descriptive too at some point, but that can happen in another bug in my opinion. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Caroline and Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- please rebase on top of 12166 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87659|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87782&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87660|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87783&action=edit Bug 21953: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87661|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87784&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Test plan passes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87662|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87785&action=edit Bug 21953: (QA follow-up) Corrections to DB Update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87663|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87786&action=edit Bug 21953: Clarify PF = Lost item processing fee Currently PF is only ever used for lost item processing fees. This patch alters the end user faceing description to clarify that. Note: It may be nice to make the code more descriptive too at some point, but that can happen in another bug in my opinion. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased as requested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Bug 21953 depends on bug 22628, which changed state. Bug 22628 Summary: FFOR and VOID show up as codes to end users in OPAC, SCO and staff https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Long standing bug depends on bug 22628 not in 18.11.x series.. will not be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org