https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75707&action=edit Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75707|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 75935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75935&action=edit Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75935|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76070&action=edit Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Hi, I'm not sure how to apply on 17.11.x since it does not have Asset TT plugin (Bug 20538). Can you provide a rebased patch ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes.