[Bug 39021] New: Badly formatted dropdown on patron account transactions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Bug ID: 39021 Summary: Badly formatted dropdown on patron account transactions page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 35402 If you have UseEmailReceipts enabled, the "Transactions" page has "receipts" menus for some transactions. In these menus the "email" option is badly formatted. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177475&action=edit Bug 39021: Fix badly formatted dropdown on patron account transactions page This patch makes minor markup changes in order for the "Email" menu item to be styled correctly after the Bootstrap upgrade. The patch also simplifies the submission of the form by removing unnecessary JS event handling. To test, apply the patch and locate a patron record to view. - Open the "Accounting" tab - Click "Create manual invoice" - Put a charge on the patron's account and click "Save and pay" - Pay the charge - Click "Transactions" - In the "Actions" column there should be a "Receipt" menu. - The "Email" item should be correctly formatted, matching the "Print" entry. - Clicking "Email" should result in the page refreshing, with the message "Receipt sent" at the top. - If you don't have email set up you can confirm that the message was queued by creating an SQL report: "SELECT * FROM `message_queue`" - The report should show the message with the receipt you emailed. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177475|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 177489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177489&action=edit Bug 39021: Fix badly formatted dropdown on patron account transactions page This patch makes minor markup changes in order for the "Email" menu item to be styled correctly after the Bootstrap upgrade. The patch also simplifies the submission of the form by removing unnecessary JS event handling. To test, apply the patch and locate a patron record to view. - Open the "Accounting" tab - Click "Create manual invoice" - Put a charge on the patron's account and click "Save and pay" - Pay the charge - Click "Transactions" - In the "Actions" column there should be a "Receipt" menu. - The "Email" item should be correctly formatted, matching the "Print" entry. - Clicking "Email" should result in the page refreshing, with the message "Receipt sent" at the top. - If you don't have email set up you can confirm that the message was queued by creating an SQL report: "SELECT * FROM `message_queue`" - The report should show the message with the receipt you emailed. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the misaligned release notes| |"Email" item on the | |"Receipt" action dropdown | |menu for a patron's | |accounting transactions | |page in the staff interface | |(when UseEmailReceipts is | |set to "Send"). (This is | |related to the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177489|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177621&action=edit Bug 39021: Fix badly formatted dropdown on patron account transactions page This patch makes minor markup changes in order for the "Email" menu item to be styled correctly after the Bootstrap upgrade. The patch also simplifies the submission of the form by removing unnecessary JS event handling. To test, apply the patch and locate a patron record to view. - Open the "Accounting" tab - Click "Create manual invoice" - Put a charge on the patron's account and click "Save and pay" - Pay the charge - Click "Transactions" - In the "Actions" column there should be a "Receipt" menu. - The "Email" item should be correctly formatted, matching the "Print" entry. - Clicking "Email" should result in the page refreshing, with the message "Receipt sent" at the top. - If you don't have email set up you can confirm that the message was queued by creating an SQL report: "SELECT * FROM `message_queue`" - The report should show the message with the receipt you emailed. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177621|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177919&action=edit Bug 39021: Fix badly formatted dropdown on patron account transactions page This patch makes minor markup changes in order for the "Email" menu item to be styled correctly after the Bootstrap upgrade. The patch also simplifies the submission of the form by removing unnecessary JS event handling. To test, apply the patch and locate a patron record to view. - Open the "Accounting" tab - Click "Create manual invoice" - Put a charge on the patron's account and click "Save and pay" - Pay the charge - Click "Transactions" - In the "Actions" column there should be a "Receipt" menu. - The "Email" item should be correctly formatted, matching the "Print" entry. - Clicking "Email" should result in the page refreshing, with the message "Receipt sent" at the top. - If you don't have email set up you can confirm that the message was queued by creating an SQL report: "SELECT * FROM `message_queue`" - The report should show the message with the receipt you emailed. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39021 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org