[Bug 38968] New: Identity providers "More" controls broken after Bootstrap 5 upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Bug ID: 38968 Summary: Identity providers "More" controls broken after Bootstrap 5 upgrade Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 When adding or editing an identify provider there are "More" buttons which are supposed to expand hidden help text. During the Bootstrap upgrade these buttons' "data-target" attribute was incorrectly changed with search and replace to "data-bs-target." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177142&action=edit Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177142|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 177143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177143&action=edit Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the identity release notes| |providers add and modify | |form so that the "More" | |buttons now correctly | |expand and show hidden help | |text. (This is related to | |the OPAC and staff | |interface Bootstrap 5 | |upgrade in Koha 24.11.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177143|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177164&action=edit Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 40601 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org