http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17685|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17688&action=edit Bug 10111 - Layout on basket summary page a bit inconsistent Some details in the summary of basket information were not marked up consistently with others on the page. This patch makes the markup consistent for a consistent appearance. To test, view a basket in Acquisitions which is part of a basketgroup. Information should be displayed consistently for baksets in both open and closed basket groups. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Owen, I'm not sure at all but I suspect 1 extra li tag. I got: - If basket is not in a bg: the "basket group" label and select (+ input) are not on the same line. - If basket is in a opened bg: idem - If basket is in a closed bg: the "basket group" label and the text ( "basketname (closed)") are on the same line. Extra li would be at lines 213 and 214. I will submit a patch, mark it as obsolete if it is the expected behavior, else sign off it. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17694|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 17694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17694 Bug 10111 - Followup Layout on basket summary page a bit inconsistent It is a little strange to have the input in a separate <li> than the label, but I think it's more readable that way, especially in a medium-sized browser window. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.