[Bug 37127] New: Authorized value select not working on authority forms.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Bug ID: 37127 Summary: Authorized value select not working on authority forms. Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kdask@altsol.gr QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When connecting an authorized value on a subfield on Authority Type framework configuration (Example: 040$b - Authorized value: LANG) the Select widget (Select2?) on the cataloging form (Edit/New) is not working. This seems to happen for any connection on any authorized values/subfields only on authorities cataloging. Tried creating new authorized value category etc, but the behavior is the same. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | Severity|critical |major Blocks| |36192 Status|NEW |ASSIGNED CC| |phil@chetcolibrary.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167884&action=edit Bug 37127: Authorized value select not working on authority forms Linking an authority subfield to an authorized value just leaves a blank in the form rather than creating a <select>, because there's a stray cud- in the type returned from build_authorized_values_list. Test plan: 1. Without the patch, Administration - Authority types - Actions menu for Default - MARC Structure 2. Actions menu for 040 - Subfields 3. Edit subfields - Tab b - Authorized value - set to LANG - Save changes 4. Authorities - New authority - Default 5. In 040 tag, click CATALOGING SOURCE to expand the tag 6. Note that subfield b has a blank space rather than a dropdown menu 7. Apply patch, restart_all 8. Authorities - New authority - Default 9. In 040 tag, click CATALOGING SOURCE to expand the tag 10. Note that subfield b has a dropdown menu listing language names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167884|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167892&action=edit Bug 37127: Authorized value select not working on authority forms Linking an authority subfield to an authorized value just leaves a blank in the form rather than creating a <select>, because there's a stray cud- in the type returned from build_authorized_values_list. Test plan: 1. Without the patch, Administration - Authority types - Actions menu for Default - MARC Structure 2. Actions menu for 040 - Subfields 3. Edit subfields - Tab b - Authorized value - set to LANG - Save changes 4. Authorities - New authority - Default 5. In 040 tag, click CATALOGING SOURCE to expand the tag 6. Note that subfield b has a blank space rather than a dropdown menu 7. Apply patch, restart_all 8. Authorities - New authority - Default 9. In 040 tag, click CATALOGING SOURCE to expand the tag 10. Note that subfield b has a dropdown menu listing language names Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167892|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167942&action=edit Bug 37127: Authorized value select not working on authority forms Linking an authority subfield to an authorized value just leaves a blank in the form rather than creating a <select>, because there's a stray cud- in the type returned from build_authorized_values_list. Test plan: 1. Without the patch, Administration - Authority types - Actions menu for Default - MARC Structure 2. Actions menu for 040 - Subfields 3. Edit subfields - Tab b - Authorized value - set to LANG - Save changes 4. Authorities - New authority - Default 5. In 040 tag, click CATALOGING SOURCE to expand the tag 6. Note that subfield b has a blank space rather than a dropdown menu 7. Apply patch, restart_all 8. Authorities - New authority - Default 9. In 040 tag, click CATALOGING SOURCE to expand the tag 10. Note that subfield b has a dropdown menu listing language names Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authorized value select not |Authorized values select |working on authority forms. |not working on authority | |forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Full CSRF not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the add and edit release notes| |forms for authority records | |that use authorized values | |for subfields - values for | |these subfields can now be | |selected using a dropdown | |list. After the CSRF | |changes in 24.05 to improve | |form security, no dropdown | |list for selecting the | |subfield value was | |displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Just a temporary bug, nothing to document. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org