https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168006&action=edit Bug 37165: Can't edit frequencies due to stray cud- in modify op The op modify in subscription-frequencies.pl isn't a cud- operation, it's a GET of the editing form, so it shouldn't have been changed to cud-modify. Test plan: 1. Don't apply the patch yet 2. Serials - Manage frequencies - for any frequency click Edit 2. Note that the editing form is empty 3. Apply patch, restart_all 4. Repeat step 2, note that now the editing form has the existing data 5. Change anything, Display order is nice, and save to verify that cud-savemod still works -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168006|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 168026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168026&action=edit Bug 37165: Can't edit frequencies due to stray cud- in modify op The op modify in subscription-frequencies.pl isn't a cud- operation, it's a GET of the editing form, so it shouldn't have been changed to cud-modify. Test plan: 1. Don't apply the patch yet 2. Serials - Manage frequencies - for any frequency click Edit 2. Note that the editing form is empty 3. Apply patch, restart_all 4. Repeat step 2, note that now the editing form has the existing data 5. Change anything, Display order is nice, and save to verify that cud-savemod still works Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the serials release notes| |frequency edit form so that | |they can be edited (Serials | |> Manage frequencies > | |select edit action for a | |frequency). Before this, | |you couldn't edit the | |frequency - the form was | |empty. (This is related to | |the CSRF changes added in | |Koha 24.05 to improve form | |security.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.