[Bug 19481] New: Elasticsearch - Set default fields for sorting in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Bug ID: 19481 Summary: Elasticsearch - Set default fields for sorting in mappings.yaml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com Currently sorting options are hardcoded, some of the options are not defined as sortable in the default ES mappings leading to search errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68241&action=edit Bug 19481 - Set default sort options as sortable in ES default mappings To test: 1 - Setup Koha with ES 2 - perform a search 3 - try sorting by pubdate, acqdate, popularity, or title 4 - Search fails! 5 - Apply patch 6 - visit: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 7 - Re-index ES 8 - Perform search 9 - All sorting options should work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- For UNIMARC, mapping for sorting by popularity is not really defined. We could use 942$0 like in MARC21. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68241|0 |1 is obsolete| | --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68788&action=edit Bug 19481 - Set default sort options as sortable in ES default mappings To test: 1 - Setup Koha with ES 2 - perform a search 3 - try sorting by pubdate, acqdate, popularity, or title 4 - Search fails! 5 - Apply patch 6 - visit: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 7 - Re-index ES 8 - Perform search 9 - All sorting options should work Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com --- Comment #4 from David Bourgault <david.bourgault@inlibro.com> --- Test worked as planned, however sorting by title and author seemed strange. I assume the issue wasn't introduced by this bug, but looking at the results list, it did not seem alphabetical to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 [Bug 19482] Elasticsearch - prevent removal / editing of required indexes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Bourgault from comment #4)
Test worked as planned, however sorting by title and author seemed strange. I assume the issue wasn't introduced by this bug, but looking at the results list, it did not seem alphabetical to me.
See bug 19581 and bug 18827 for ordering issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com QA Contact| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch works as described (except for popularity when in UNIMARC, since the field is not defined). But I wonder about 6th step in test plan. Shouldn't it be done in an updatedatabase script ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Julian Maurice from comment #6)
Patch works as described (except for popularity when in UNIMARC, since the field is not defined). But I wonder about 6th step in test plan. Shouldn't it be done in an updatedatabase script ?
I am not sure - if someone has custom mappings setup for some reasonn I don't think we want to alter them. I think i would prefer to follow up on 19542 and add a warning if standard sort fields are not defined. Does that sound reasonable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Nick Clemens from comment #7)
I am not sure - if someone has custom mappings setup for some reasonn I don't think we want to alter them.
I think i would prefer to follow up on 19542 and add a warning if standard sort fields are not defined. Does that sound reasonable? Ok
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68788|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69224&action=edit Bug 19481 - Set default sort options as sortable in ES default mappings To test: 1 - Setup Koha with ES 2 - perform a search 3 - try sorting by pubdate, acqdate, popularity, or title 4 - Search fails! 5 - Apply patch 6 - visit: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 7 - Re-index ES 8 - Perform search 9 - All sorting options should work Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org